Eclipse Community Forums: DTP » DTP Init Not Thread Safe

Help

Home

Home » Eclipse Projects » DTP » DTP Init Not Thread Safe

Show: Today's Messages :: Show Polls :: Message Navigator

DTP Init Not Thread Safe [message #445493]

Fri, 31 July 2009 19:34

Erik Englund

Messages: 49
Registered: July 2009

Member

Is DTP to be considered Thread safe?

I have run across a problem when multiple threads at startup.

I believe the problem is within
org.eclipse.datatools.connectivity.internal.ConnectionProfil eManager.processExtensions

because the error I am getting is an Assertion failure on multiple
definitions of an attribute.

In my code I am calling
IConnectionProfile.createConnection(ConnectionProfileConstan ts.PING_FACTORY_ID)
and getting those assertion errors.

Report message to a moderator

Re: DTP Init Not Thread Safe [message #446454 is a reply to message #445493]

Fri, 31 July 2009 22:11

Brian Fitzpatrick

Messages: 500
Registered: July 2009

Senior Member

Erik wrote:
> Is DTP to be considered Thread safe?
> I have run across a problem when multiple threads at startup.
>
> I believe the problem is within
> org.eclipse.datatools.connectivity.internal.ConnectionProfil eManager.processExtensions
>
>
> because the error I am getting is an Assertion failure on multiple
> definitions of an attribute.
>
> In my code I am calling
> IConnectionProfile.createConnection(ConnectionProfileConstan ts.PING_FACTORY_ID)
>
> and getting those assertion errors.
>
We have dealt with a few of the thread safety issues in the past, but I
think we're pretty good at this point. Do you have some context for this
issue? You're calling this in an RCP app?

Report message to a moderator

Re: DTP Init Not Thread Safe [message #480404 is a reply to message #446454]

Sun, 16 August 2009 21:06

Erik Englund

Messages: 49
Registered: July 2009

Member

Here is some example code. I run this within a RCP application and it is run simultaneously within two seperate Jobs.

With the synchronized block this works fine. Without it it sometimes doesn't.

ProfileManager profileManager = ProfileManager.getInstance();
synchronized (profileManager) {
if (this.profile != null) {
profileManager.deleteProfile(this.profile);
}
this.profile = profileManager.getProfileByName(profileName);
if (this.profile == null) {
this.profile = null;
profileManager.createProfile(profileName, description, providerId, props);
}
}

I believe the problem lies within the initial Init of the profile manager when you build up all the initial drivers and profiles based off of the DTP extension points.

I am seeing this problem within DTP 1.6 and believe I even saw it within 1.7 but haven't done extensive testing on 1.7

Report message to a moderator