Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » EMF » [CDO] Little patch for setting up the CDO sources workspace
[CDO] Little patch for setting up the CDO sources workspace [message #431313] Wed, 08 July 2009 09:08 Go to next message
Kai Schlamp is currently offline Kai SchlampFriend
Messages: 344
Registered: July 2009
Senior Member
Hi Eike,

below is a little patch for the SetupWorkspace.java for setting up the CDO Sources.
The problem is when you are working on Linux and change url-target.txt and url.baseline.txt as
mentioned on http://wiki.eclipse.org/CDO_Source_Installation#Bootstrap, then those files are not
downloaded correctly.
Was not sure if it is really worth a bug report.

### Eclipse Workspace Patch 1.0
#P develop.setup
Index: src/setup/SetupWorkspace.java
============================================================ =======
RCS file:
/cvsroot/modeling/org.eclipse.emf/org.eclipse.emf.cdo/develo p/setup/src/setup/SetupWorkspace.java,v
retrieving revision 1.1
diff -u -r1.1 SetupWorkspace.java
--- src/setup/SetupWorkspace.java 4 Jul 2009 05:11:43 -0000 1.1
+++ src/setup/SetupWorkspace.java 8 Jul 2009 09:01:51 -0000
@@ -123,7 +123,7 @@

URLConnection connection = url.openConnection();
String contentType = connection.getContentType();
- if (!"application/zip".equals(contentType))
+ if (!"application/zip".equals(contentType) && !"application/x-gzip".equals(contentType))
{
copy((InputStream)connection.getContent(), System.err);
throw new IOException("Invalid content type: " + contentType);

Report message to a moderator

Re: [CDO] Little patch for setting up the CDO sources workspace [message #431370 is a reply to message #431313] Wed, 08 July 2009 09:14 Go to previous messageGo to next message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6505
Registered: July 2009
Senior Member
Kai,

Thx for the hint! Usually we prefer patches on bugzillas, but in this
case no production code is affected. That said, I can't apply the patch.
But the change is simple enough and I can apply it manually ;-)

Cheers
/Eike

----
http://thegordian.blogspot.com
http://twitter.com/eikestepper



Kai Schlamp schrieb:
> Hi Eike,
>
> below is a little patch for the SetupWorkspace.java for setting up the
> CDO Sources.
> The problem is when you are working on Linux and change url-target.txt
> and url.baseline.txt as mentioned on
> http://wiki.eclipse.org/CDO_Source_Installation#Bootstrap, then those
> files are not downloaded correctly.
> Was not sure if it is really worth a bug report.
>
> ### Eclipse Workspace Patch 1.0
> #P develop.setup
> Index: src/setup/SetupWorkspace.java
> ============================================================ =======
> RCS file:
> /cvsroot/modeling/org.eclipse.emf/org.eclipse.emf.cdo/develo p/setup/src/setup/SetupWorkspace.java,v
>
> retrieving revision 1.1
> diff -u -r1.1 SetupWorkspace.java
> --- src/setup/SetupWorkspace.java 4 Jul 2009 05:11:43 -0000 1.1
> +++ src/setup/SetupWorkspace.java 8 Jul 2009 09:01:51 -0000
> @@ -123,7 +123,7 @@
>
> URLConnection connection = url.openConnection();
> String contentType = connection.getContentType();
> - if (!"application/zip".equals(contentType))
> + if (!"application/zip".equals(contentType) &&
> !"application/x-gzip".equals(contentType))
> {
> copy((InputStream)connection.getContent(), System.err);
> throw new IOException("Invalid content type: " + contentType);

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper

Report message to a moderator

Re: [CDO] Little patch for setting up the CDO sources workspace [message #431408 is a reply to message #431370] Wed, 08 July 2009 11:42 Go to previous messageGo to next message
Kai Schlamp is currently offline Kai SchlampFriend
Messages: 344
Registered: July 2009
Senior Member
Another problem is that the tar.gz file is not unpacked into the .target folder (only .zip files are
handled by SetupWorkspace.java).
I'll take a look into that problem, when I have some time.
Do you really develop under Windows, Eike? I tried that once, but Windows (XP, Vista, whatever)
always complained when trying to move or delete files that are in a deep folder structure + have
long path names (like it often happens in Eclipse development). That drove me really crazy.

Report message to a moderator

Re: [CDO] Little patch for setting up the CDO sources workspace [message #431416 is a reply to message #431408] Wed, 08 July 2009 14:33 Go to previous messageGo to next message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6505
Registered: July 2009
Senior Member
Kai Schlamp schrieb:
> Another problem is that the tar.gz file is not unpacked into the
> .target folder (only .zip files are handled by SetupWorkspace.java).
> I'll take a look into that problem, when I have some time.
That would be great!
I really hope that we're soon able to use Buckminster ;-)

> Do you really develop under Windows, Eike? I tried that once, but
> Windows (XP, Vista, whatever) always complained when trying to move or
> delete files that are in a deep folder structure + have long path
> names (like it often happens in Eclipse development). That drove me
> really crazy.
Yes. My workspace is under C:\develop\ws\cdo and under Vista that works
great.

Cheers
/Eike

----
http://thegordian.blogspot.com
http://twitter.com/eikestepper

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper

Report message to a moderator

Re: [CDO] Little patch for setting up the CDO sources workspace [message #431422 is a reply to message #431416] Wed, 08 July 2009 21:28 Go to previous messageGo to next message
Kai Schlamp is currently offline Kai SchlampFriend
Messages: 344
Registered: July 2009
Senior Member
Eike Stepper wrote:
> Kai Schlamp schrieb:
>> Another problem is that the tar.gz file is not unpacked into the
>> .target folder (only .zip files are handled by SetupWorkspace.java).
>> I'll take a look into that problem, when I have some time.
> That would be great!
> I really hope that we're soon able to use Buckminster ;-)

What prevents you from doing so? A missing feature, or simply time?

Report message to a moderator

Re: [CDO] Little patch for setting up the CDO sources workspace [message #431423 is a reply to message #431422] Thu, 09 July 2009 05:37 Go to previous message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6505
Registered: July 2009
Senior Member
Kai Schlamp schrieb:
> Eike Stepper wrote:
>> Kai Schlamp schrieb:
>>> Another problem is that the tar.gz file is not unpacked into the
>>> .target folder (only .zip files are handled by SetupWorkspace.java).
>>> I'll take a look into that problem, when I have some time.
>> That would be great!
>> I really hope that we're soon able to use Buckminster ;-)
>
> What prevents you from doing so? A missing feature, or simply time?
Many things ;-)

Most important: I'd like the central build be the same as my local one
and changing the central build is far beyond my capabilities.

Cloudsmith has offered to invest in helping me setup initial Buckminster
support, so something might happen some time soon...

Cheers
/Eike

----
http://thegordian.blogspot.com
http://twitter.com/eikestepper

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper

Report message to a moderator

Previous Topic:Re: Teneo + EclipseLink simple complete example
Next Topic:[CDO] Need help with the testing framework
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Mon Sep 21 20:24:28 GMT 2020

Powered by FUDForum. Page generated in 0.02368 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top

Sign up to our Newsletter

A fresh new issue delivered monthly