| [CDO] Little patch for setting up the CDO sources workspace [message #431313] |
Wed, 08 July 2009 05:08  |
Eclipse User |
|
|
|
Hi Eike,
below is a little patch for the SetupWorkspace.java for setting up the CDO Sources.
The problem is when you are working on Linux and change url-target.txt and url.baseline.txt as
mentioned on http://wiki.eclipse.org/CDO_Source_Installation#Bootstrap, then those files are not
downloaded correctly.
Was not sure if it is really worth a bug report.
### Eclipse Workspace Patch 1.0
#P develop.setup
Index: src/setup/SetupWorkspace.java
============================================================ =======
RCS file:
/cvsroot/modeling/org.eclipse.emf/org.eclipse.emf.cdo/develo p/setup/src/setup/SetupWorkspace.java,v
retrieving revision 1.1
diff -u -r1.1 SetupWorkspace.java
--- src/setup/SetupWorkspace.java 4 Jul 2009 05:11:43 -0000 1.1
+++ src/setup/SetupWorkspace.java 8 Jul 2009 09:01:51 -0000
@@ -123,7 +123,7 @@
URLConnection connection = url.openConnection();
String contentType = connection.getContentType();
- if (!"application/zip".equals(contentType))
+ if (!"application/zip".equals(contentType) && !"application/x-gzip".equals(contentType))
{
copy((InputStream)connection.getContent(), System.err);
throw new IOException("Invalid content type: " + contentType);
|
|
|
| Re: [CDO] Little patch for setting up the CDO sources workspace [message #431370 is a reply to message #431313] |
Wed, 08 July 2009 05:14  |
| Eclipse User |
|
|
|
Kai,
Thx for the hint! Usually we prefer patches on bugzillas, but in this
case no production code is affected. That said, I can't apply the patch.
But the change is simple enough and I can apply it manually ;-)
Cheers
/Eike
----
http://thegordian.blogspot.com
http://twitter.com/eikestepper
Kai Schlamp schrieb:
> Hi Eike,
>
> below is a little patch for the SetupWorkspace.java for setting up the
> CDO Sources.
> The problem is when you are working on Linux and change url-target.txt
> and url.baseline.txt as mentioned on
> http://wiki.eclipse.org/CDO_Source_Installation#Bootstrap, then those
> files are not downloaded correctly.
> Was not sure if it is really worth a bug report.
>
> ### Eclipse Workspace Patch 1.0
> #P develop.setup
> Index: src/setup/SetupWorkspace.java
> ============================================================ =======
> RCS file:
> /cvsroot/modeling/org.eclipse.emf/org.eclipse.emf.cdo/develo p/setup/src/setup/SetupWorkspace.java,v
>
> retrieving revision 1.1
> diff -u -r1.1 SetupWorkspace.java
> --- src/setup/SetupWorkspace.java 4 Jul 2009 05:11:43 -0000 1.1
> +++ src/setup/SetupWorkspace.java 8 Jul 2009 09:01:51 -0000
> @@ -123,7 +123,7 @@
>
> URLConnection connection = url.openConnection();
> String contentType = connection.getContentType();
> - if (!"application/zip".equals(contentType))
> + if (!"application/zip".equals(contentType) &&
> !"application/x-gzip".equals(contentType))
> {
> copy((InputStream)connection.getContent(), System.err);
> throw new IOException("Invalid content type: " + contentType);
|
|
|
|
|
|
| Re: [CDO] Little patch for setting up the CDO sources workspace [message #431423 is a reply to message #431422] |
Thu, 09 July 2009 01:37 |
| Eclipse User |
|
|
|
Kai Schlamp schrieb:
> Eike Stepper wrote:
>> Kai Schlamp schrieb:
>>> Another problem is that the tar.gz file is not unpacked into the
>>> .target folder (only .zip files are handled by SetupWorkspace.java).
>>> I'll take a look into that problem, when I have some time.
>> That would be great!
>> I really hope that we're soon able to use Buckminster ;-)
>
> What prevents you from doing so? A missing feature, or simply time?
Many things ;-)
Most important: I'd like the central build be the same as my local one
and changing the central build is far beyond my capabilities.
Cloudsmith has offered to invest in helping me setup initial Buckminster
support, so something might happen some time soon...
Cheers
/Eike
----
http://thegordian.blogspot.com
http://twitter.com/eikestepper
|
|
|
Powered by
FUDForum. Page generated in 0.25996 seconds
Home