|
Re: [CDO] New packages [message #421563 is a reply to message #421562] |
Sat, 09 August 2008 16:45 |
|
Simon McDuff schrieb:
> Hi EIke,
>
> I have a question for you.
>
> I have
>
> PackageA with classA1, classA2
> PackageB with classB1, classB2
>
> classA1 extends classB1
>
> - I create an instance of classA2.
> - Persist it.
>
> Should PackageB be transfer to the server as well as PackageA? (The current
> implementation does not transfer it)
>
That depends on how the two packages depend on each other.
If PackageA depends somehow on content of PackageB then both packages
will be committed to the repository.
Only recently Martin and I changed the behaviour slightly in that now
the dependencies of the whole packages are calculated.
Previously only the dependencies of the classes that have istances to be
committed were calculated.
For the DBStore this was enough but it turned out that the
HibernateStore needs the whole dependent package even if it's not
referenced by instances of the commit.
Looking at the source in HEAD though I'm not sure if what we have
discussed is already committed.
Martin, can you remember this discussin?
Cheers
/Eike
Cheers
/Eike
----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper
|
|
|
Re: [CDO] New packages [message #421564 is a reply to message #421563] |
Sat, 09 August 2008 16:49 |
|
Eike Stepper schrieb:
> Simon McDuff schrieb:
>> Hi EIke,
>>
>> I have a question for you.
>>
>> I have
>>
>> PackageA with classA1, classA2
>> PackageB with classB1, classB2
>>
>> classA1 extends classB1
>>
>> - I create an instance of classA2.
>> - Persist it.
>>
>> Should PackageB be transfer to the server as well as PackageA? (The
>> current implementation does not transfer it)
>>
> That depends on how the two packages depend on each other.
> If PackageA depends somehow on content of PackageB then both packages
> will be committed to the repository.
> Only recently Martin and I changed the behaviour slightly in that now
> the dependencies of the whole packages are calculated.
> Previously only the dependencies of the classes that have istances to
> be committed were calculated.
> For the DBStore this was enough but it turned out that the
> HibernateStore needs the whole dependent package even if it's not
> referenced by instances of the commit.
> Looking at the source in HEAD though I'm not sure if what we have
> discussed is already committed.
IIRC I modified org.eclipse.emf.internal.cdo.util.CompletePackageClosure
to exclude EcorePackage for this purpose...
>
> Martin, can you remember this discussin?
>
> Cheers
> /Eike
Cheers
/Eike
----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper
|
|
|
Powered by
FUDForum. Page generated in 0.04096 seconds