|
| Re: Generated editor code [message #416182 is a reply to message #416180] |
Mon, 21 January 2008 15:23  |
 Ed Merks
Messages: 33133
Registered: July 2009 |
Senior Member |
|
|
Eric,
There was some recent discussion about the reason for generating a whack
of code that's mostly generic. On the plus side, you'd have a tiny
editor. On the minus side, every change we make to the base editor
effects everyone directly even if they don't regenerate. It's also less
obvious that you can change anything and everything however you like.
Bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=108470 also deals
with that to an extent. It's certainly reasonable that we could have
another style of editor to generate, but it's more likely I'd want to
focus on eRCP and RAP than on this issue (as if I have time for any of
them)...
Eric Rizzo wrote:
> The generate editor code is, as most generated code tends to be, very
> large and contains a lot of inner classes. It seems that at least some
> of it could be extracted out into configurable (and reusable) classes
> instead of being generated inline with the main editor code.
> I'm look right now at the resourceChangeListener and partListener
> code, but I'd bet there are other opportunities, too.
> Is this worth opening a Bugzilla report for? Let's say I could
> contribute a configurable class that all generated editors could use,
> for example, as their resource change lisetener; what is involved in
> changing the generation templates to use that? IOW, how much effort
> would that be?
>
> Eric
Ed Merks
Professional Support: https://www.macromodeling.com/
|
|
|
Powered by
FUDForum. Page generated in 0.02019 seconds
] 
Search
Help
Register
Login
Home
