Eclipse Community Forums: EMF » EMF queries using SubStringValue can't handle empty Strings

Help

Home

Home » Modeling » EMF » EMF queries using SubStringValue can't handle empty Strings

Show: Today's Messages :: Show Polls :: Message Navigator

EMF queries using SubStringValue can't handle empty Strings [message #414969]

Tue, 27 November 2007 09:14

Jasper

Messages: 84
Registered: July 2009

Member

All:

SubStringValue#isSatisfied calls StringSearch#new, which throws
IllegalArgumentException if the second parameter is a String of zero
length. But isn't it pretty normal for a search to encounter empty
Strings in a model? Yet with the current implementation, any query using
SubStringValue will choke on the first empty String it encounters.

Simplest solution would be to have a guard as the first line of in
SubStringValue#isSatisfied:

if (str == null || str.length() == 0)
return false;

Regards,
Jasper.

Report message to a moderator

Re: EMF queries using SubStringValue can't handle empty Strings [message #414972 is a reply to message #414969]

Tue, 27 November 2007 12:30

Eclipse User

Originally posted by: cdamus.ca.ibm.com

Hi, Jasper,

Yes, this sounds like a bug. Please raise one:

https://bugs.eclipse.org/bugs/enter_bug.cgi?product=EMF& version=1.1&component=Query

Cheers,

Christian

Jasper wrote:

> All:
>
> SubStringValue#isSatisfied calls StringSearch#new, which throws
> IllegalArgumentException if the second parameter is a String of zero
> length. But isn't it pretty normal for a search to encounter empty
> Strings in a model? Yet with the current implementation, any query using
> SubStringValue will choke on the first empty String it encounters.
>
> Simplest solution would be to have a guard as the first line of in
> SubStringValue#isSatisfied:
>
> if (str == null || str.length() == 0)
> return false;
>
> Regards,
> Jasper.

Report message to a moderator

Re: EMF queries using SubStringValue can't handle empty Strings [message #414973 is a reply to message #414969]

Tue, 27 November 2007 12:34

Ed Merks

Messages: 33216
Registered: July 2009

Senior Member

Jasper,

Seems reasonable to me. I'd suggest opening a bugzilla. Personally I
think seems odd that StringSearch itself throws an exception for an
empty string, but it's apparently deliberate...

Jasper wrote:
> All:
>
> SubStringValue#isSatisfied calls StringSearch#new, which throws
> IllegalArgumentException if the second parameter is a String of zero
> length. But isn't it pretty normal for a search to encounter empty
> Strings in a model? Yet with the current implementation, any query
> using SubStringValue will choke on the first empty String it encounters.
>
> Simplest solution would be to have a guard as the first line of in
> SubStringValue#isSatisfied:
>
> if (str == null || str.length() == 0)
> return false;
>
> Regards,
> Jasper.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: EMF queries using SubStringValue can't handle empty Strings [message #414975 is a reply to message #414972]

Tue, 27 November 2007 12:52

Jasper

Messages: 84
Registered: July 2009

Member

Bugzilla #211055

Thanks,
Jasper.

Christian W. Damus wrote:
> Hi, Jasper,
>
> Yes, this sounds like a bug. Please raise one:
>
> https://bugs.eclipse.org/bugs/enter_bug.cgi?product=EMF& version=1.1&component=Query
>
> Cheers,
>
> Christian
>
>
> Jasper wrote:
>
>> All:
>>
>> SubStringValue#isSatisfied calls StringSearch#new, which throws
>> IllegalArgumentException if the second parameter is a String of zero
>> length. But isn't it pretty normal for a search to encounter empty
>> Strings in a model? Yet with the current implementation, any query using
>> SubStringValue will choke on the first empty String it encounters.
>>
>> Simplest solution would be to have a guard as the first line of in
>> SubStringValue#isSatisfied:
>>
>> if (str == null || str.length() == 0)
>> return false;
>>
>> Regards,
>> Jasper.
>

Report message to a moderator

Previous Topic:	Chaging the current object in a property sheet
Next Topic:	error with eKeys() if three plugins are involved.

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat Sep 21 22:49:05 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter