Eclipse Community Forums: C / C++ IDE (CDT) » isExtensionElement check missing in Tool.needsRebuild

Home » Language IDEs » C / C++ IDE (CDT) » isExtensionElement check missing in Tool.needsRebuild(Why 'isExtensionElement()' is not checked before reading 'rebuildState' flag but checked before writing the same flag ?)

Show: Today's Messages :: Show Polls :: Message Navigator

isExtensionElement check missing in Tool.needsRebuild [message #1868796]

Mon, 22 July 2024 10:35

Shiva Sharma

Messages: 7
Registered: January 2014

Junior Member

Hello Team,

I encountered an issue where incremental build (managed build system - Internal builder) did not work for me. The reason was that one of the 'Options' always returned the 'rebuildState' flag as true.

When I looked deeper, I found that the options that have parent 'Tool' as an extension tool are never accessed to write the 'rebuildState' as 'false' after the build is done.
But the 'rebuildState' flag is read (without the extension element check) before a new build is issued.
This created a problem where the 'rebuildState' was always true (due to the default value) and prevented incremental builds and always led to a new build.

I know there should be no 'Option' that is a direct child to an extension tool and I have fixed this issue in my extension code (value handler called while creating C/C++ project must check for extension-element). But what I wanted to report/ask is as following...

What I wanted to report:
The 'Tool' class's 'needsRebuild(...)' does not check for 'isExtensionElement()' for reading the 'rebuildState' flag
BUT
the 'setRebuildState(...)' of same class checks the 'isExtensionElement()' for writing the 'rebuildState' flag.

Is this a bug OR something intentional? Do you plan to fix it, if it is a bug? Can you please explain if the missing check has some purpose, if so?

Thanks & Best Regards,
Shiva Sharma..

Report message to a moderator

Re: isExtensionElement check missing in Tool.needsRebuild [message #1868808 is a reply to message #1868796]

Tue, 23 July 2024 02:02

Nitin Dahyabhai

Messages: 4493
Registered: July 2009

Senior Member

This really is the sort of thing you should take to https://github.com/eclipse-cdt/cdt/discussions as it requires a CDT Committer to answer, or to https://github.com/eclipse-cdt/cdt/issues to actually report it.

_
Nitin Dahyabhai
Eclipse Web Tools Platform

[Updated on: Tue, 23 July 2024 18:13]

Report message to a moderator