Eclipse Community Forums: EGit / JGit

Home » Eclipse Projects » EGit / JGit » EGit Compare Viewer(Shows ID of prior commit, not ID of last change)

Tue, 30 May 2023 17:42

Eclipse User

My last local commit changed main.c and the lower right of the History panel lists that file.

If I double-click main.c in that list, it opens the "C" Compare Viewer. It highlights the changes but the commit ID it references is simply the prior commit, which in this case didn't change main.c.

I suppose this is technically correct but it's also misleading. Shouldn't it by default reference the commit ID that previously changed that file rather than the ID of the prior commit?

Re: EGit Compare Viewer [message #1859405 is a reply to message #1859320]

Mon, 05 June 2023 12:37

Eclipse User

Added image that highlights the issue. Items "A" - "D" in that image are summarized below:

A - Latest commit changed main.c. Double click that file in "changed" list.
B - Compare view shows changes from prior commit (28558f8)
C - That commit didn't change main.c
D - Prior commit that changed main.c is D436726

I have to manually click each commit to find the previous one that changed that file. Not a big deal if repo only has a few commits but it could have many more.

EGit version is 6.5.0.2023

index.php/fa/43237/0/

Attachment: Eclipse forum post - Compare viewer.png
(Size: 231.94KB, Downloaded 308 times)

Re: EGit Compare Viewer [message #1859582 is a reply to message #1859405]

Fri, 16 June 2023 15:46

Eclipse User

We actually had it the way you suggest/expect a while back. That turned out to be confusing in other contexts, though. It also comes with a non-negligible cost -- imagine a file last touched thousands of commits ago: one would have to traverse the history back until one hits that commit.

But EGit could probably choose one or the other method, depending on how exactly the comparison was triggered.

You might also want to explore "Focus on this file" in the history view, which filters the history to only show commits that touch that file. Or the "Link with Editor and Selection" button (top right in the view, two arrows pointing left and right), which does the same based on the current active editor or selection. That can be customized via the "File Scope for History" button (the funnel).

Previous Topic:	EGit still shows remote tracking branch after delete
Next Topic:	Connection failed from Git to Eclipse

Goto Forum:

-=] Back to Top [=-

Current Time: Sat May 24 19:52:35 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter