Eclipse Community Forums: Eclipse Platform » Need help pushing a bug fix to Gerrit

Home » Eclipse Projects » Eclipse Platform » Need help pushing a bug fix to Gerrit(Not sure why I'm getting permission denied)

Show: Today's Messages :: Show Polls :: Message Navigator

Need help pushing a bug fix to Gerrit [message #1852933]

Sat, 11 June 2022 11:24

Alex Mising name

Messages: 149
Registered: March 2010

Senior Member

Hi all,

I'm an occassional contributor (mainly fix the obscure bug that affects me but is finge enough to not get attention).

I'm trying to push a fix to gerrit for code review and I'm getting permission denied. I am using SSH and have just updated my key in gerrint (I was using an old RSA one that is deprecated and failing to authenticate).

Here is my remote (yes my username in gerrit is that weird "amissingnamedcb" due to some migration error ages ago):

user@host /cygdrive/c/Users/user/git/eclipse.platform.debug
$ git remote -v
origin  ssh://amisingnamedcb@git.eclipse.org:29418/platform/eclipse.platform.debug.git (fetch)
origin  ssh://amisingnamedcb@git.eclipse.org:29418/platform/eclipse.platform.debug.git (push)

user@host /cygdrive/c/Users/user/git/eclipse.platform.debug
$ git log -1 | egrep "Change-Id|Signed-off"
    Signed-off-by: My name <my@email.domain>
    Change-Id: Ia099fd81cf1eba237bec3daeaa4ecb4615548431

Now, since I am not a commiter, I believe I need to push for review with git push origin HEAD:refs/for/master but:

user@host /cygdrive/c/Users/user/git/eclipse.platform.debug
$ GIT_SSH_COMMAND="ssh -v" git push origin HEAD:refs/for/master
OpenSSH_9.0p1, OpenSSL 1.1.1o  3 May 2022
debug1: Reading configuration data /home/user/.ssh/config
debug1: /home/user/.ssh/config line 11: Applying options for git.eclipse.org
debug1: Connecting to git.eclipse.org [198.41.30.196] port 29418.
debug1: Connection established.
...
debug1: Will attempt key: /home/user/.ssh/id_ed25519_eclipse ED25519 SHA256:0dCoVaYYNddbKCNksk0qcBK6mQRbvA4LI0N7RSfUR/c explicit agent
debug1: SSH2_MSG_SERVICE_ACCEPT received
debug1: Authentications that can continue: publickey
debug1: Next authentication method: publickey
debug1: Offering public key: /home/user/.ssh/id_ed25519_eclipse ED25519 SHA256:0dCoVaYYNddbKCNksk0qcBK6mQRbvA4LI0N7RSfUR/c explicit agent
debug1: Server accepts key: /home/user/.ssh/id_ed25519_eclipse ED25519 SHA256:0dCoVaYYNddbKCNksk0qcBK6mQRbvA4LI0N7RSfUR/c explicit agent
Authenticated to git.eclipse.org ([198.41.30.196]:29418) using "publickey".

^^^ My key looks good now, but:

debug1: channel 0: new [client-session]
debug1: Entering interactive session.
debug1: pledge: filesystem
debug1: Sending command: git-receive-pack '/platform/eclipse.platform.debug.git'
Enumerating objects: 49, done.
Counting objects: 100% (49/49), done.
Delta compression using up to 8 threads
Compressing objects: 100% (18/18), done.
debug1: client_input_channel_req: channel 0 rtype exit-status reply 0
fatal: Unpack error, check server log
debug1: channel 0: free: client-session, nchannels 1
Transferred: sent 18920, received 462168 bytes, in 1.6 seconds
Bytes per second: sent 11679.5, received 285300.4
debug1: Exit status 128
error: remote unpack failed: error Permission denied
To ssh://git.eclipse.org:29418/platform/eclipse.platform.debug.git
 ! [remote rejected]     HEAD -> refs/for/master (n/a (unpacker error))
error: failed to push some refs to 'ssh://git.eclipse.org:29418/platform/eclipse.platform.debug.git'

What am I doing wrong here?

[Updated on: Sat, 11 June 2022 11:25]

Report message to a moderator

Re: Need help pushing a bug fix to Gerrit [message #1852935 is a reply to message #1852933]

Sat, 11 June 2022 14:35

Nitin Dahyabhai

Messages: 4507
Registered: July 2009

Senior Member

That repository has been moved to https://github.com/eclipse-platform/eclipse.platform.debug . There's little in the old location to indicate this, though.

_
Nitin Dahyabhai
Eclipse Web Tools Platform

Report message to a moderator

Re: Need help pushing a bug fix to Gerrit [message #1852936 is a reply to message #1852935]

Sat, 11 June 2022 15:09

Alex Mising name

Messages: 149
Registered: March 2010

Senior Member

So, in order to submit a patch, do you use the GIT workflow now (instead of Gerrit)? Meaning I should fork in github, and raise a PR?

Do I need to raise an issue in github or do we still reference bugs.eclipse.org?

Report message to a moderator

Re: Need help pushing a bug fix to Gerrit [message #1852937 is a reply to message #1852936]

Sat, 11 June 2022 15:45

Alex Mising name

Messages: 149
Registered: March 2010

Senior Member

Ok, looks like it's now the github fork and raise PR to upstream project model

There's an updated CONTRIBUTING.md file here.

I still can't find an updated PSF to pull the platform from there though. That would've been useful...

Report message to a moderator

Re: Need help pushing a bug fix to Gerrit [message #1852938 is a reply to message #1852937]

Sat, 11 June 2022 16:00

Alex Mising name

Messages: 149
Registered: March 2010

Senior Member

Ok so there is aggregator project here that helps. I'd assume you use that to get your basline, then fork and replace whatever you want to contribute to with your fork (in your workspace).

Report message to a moderator

Re: Need help pushing a bug fix to Gerrit [message #1852948 is a reply to message #1852938]

Sun, 12 June 2022 13:04

Ed Merks

Messages: 33263
Registered: July 2009

Senior Member

The easiest way to setup up the environment is to use the Oomph setup:

https://www.eclipse.org/setups/installer/?url=https://raw.githubusercontent.com/eclipse-platform/eclipse.platform.releng.aggregator/master/oomph/PlatformSDKConfiguration.setup&show=true

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Need help pushing a bug fix to Gerrit [message #1853121 is a reply to message #1852948]

Sun, 19 June 2022 13:07

Alex Mising name

Messages: 149
Registered: March 2010

Senior Member

So, this worked for me on Linux back when you posted, and I was able to get my PR merged. I wanted to do some testing on Windows though and today I am getting this message when the installer starts.

Processing index:/org.eclipse.setup#//@projectCatalogs[name='org.eclipse']/@projects[name='equinox'/@projects[name='bundles']/@streams[name='master']
The referenced stream cannot be resolved

Processing index:/org.eclipse.setup#//@ projectCatalogs[name='org.eclipse']/@projects[name="equinox']/@projects[name= 'framework']/@streams[name='master']
The referenced stream cannot be resolved

I retried on Linux (where this worked a few days ago) and get the same message, so it seems something is broken?

If I ignore the message, instalaltion proceeds (all repos are cloned, the P2 director fetches all bundles needed and the new instance starts and goes through startup tasks), but after cloning a ton of git repos, it comes back with this error

Going back and removing these two tasks to bypass them, I then get stack to the modular target creation:

Performing Targlets Modular Target (ECF Dependency + EMF Dependency + Eclipse Platform + Equinox Binaries + Equinox P2 + Equinox Platform + JDT Core + JDT Core Test Binaries + JDT Core Tests + JDT Debug + JDT Debug Tests + JDT Features + JDT Platform + JDT UI + JDT UI Examples + JDT UI Tests + PDE + Platform + Platform Base, Update, and Ant + Platform Build Tools + Platform Debug + Platform Documentation + Platform Images + Platform News + Platform Releng + Platform Releng Aggregator + Platform Resources + Platform Team + Platform Text + Platform UA + Platform UI + Platform UI Tools + Platform Website + SWT + SWT Binaries + SWT Website), activate
Repository https://download.eclipse.org/eclipse/updates/4.25-I-builds
Repository https://download.eclipse.org/cbi/updates/license
...
...
Adding repository https://download.eclipse.org/reddeer/releases/latest
Calculating requirements and dependencies.
Cannot complete the request. Generating details.
ERROR: org.eclipse.pde.core code=0 Problems occurred while resolving the target contents
...
...
ERROR: org.eclipse.equinox.p2.director code=10053 Cannot complete the install because one or more required items could not be found.
ERROR: org.eclipse.equinox.p2.director code=0 Software being installed: artificial_root 1.0.0.v1655638808144
ERROR: org.eclipse.equinox.p2.director code=0 Missing requirement: artificial_root 1.0.0.v1655638808144 requires 'org.eclipse.equinox.p2.iu; org.eclipse.jdt.core.internal.tools 0.0.0' but it could not be found

If I go back and untick this task, I end up with a workspace with lots of git repos cloned, and lots of working sets defined, but with no projects in the workspace (apparently no projects are imported)

Just wondering:

1. What does the original message when starting the installer mean?
2. Is it related to the subsequent problem to set up the target, or if both are independent of each other?
3. For each of the two, are they server-side issues that need to be fixed and then I can retry, or is there something I can do on my end to fix this?

I've cleaned up my home (.p2 for bundle pool and .eclipse for settings) but am still getting these errors...

Report message to a moderator

Re: Need help pushing a bug fix to Gerrit [message #1853122 is a reply to message #1853121]

Sun, 19 June 2022 13:27

Ed Merks

Messages: 33263
Registered: July 2009

Senior Member

Sorry, the platform keeps renaming and merging repositories making it difficult to maintain a working state.

Last week this new repository was created:

https://github.com/eclipse-equinox/equinox

And into that repository the contents of these two repositories were merged making those obsolete:

https://github.com/eclipse-equinox/equinox.bundles
https://github.com/eclipse-equinox/equinox.framework

So I had to adjust the setup accordingly and deleted the project setups for equinox.bundles and equinox.framework. That causes the errors you see. In particular, if you use Navigate -> Open Setup -> Workspace you will see it has those broken links to the streams of those two projects. They need to be removed from the workspace.setup. If you do all this, the Equinox setup for the new Equinox "core" project will be missing. From the Setup editor context menu you can use Open in Text Editor. The three entries for equinox should look like this:

  <stream href="index:/org.eclipse.setup#//@projectCatalogs[name='org.eclipse']/@projects[name='equinox']/@projects[name='binaries']/@streams[name='master']"/>
  <stream href="index:/org.eclipse.setup#//@projectCatalogs[name='org.eclipse']/@projects[name='equinox']/@projects[name='core']/@streams[name='master']"/>
  <stream href="index:/org.eclipse.setup#//@projectCatalogs[name='org.eclipse']/@projects[name='equinox']/@projects[name='p2']/@streams[name='master']"/>

Then the platform has been changing the TP and so I had to adjust one of the setups (PDE) to find an older RedDeer Orbit dependency that is not in the latest Orbit. I generally select all repositories in the repositories view and do a pull; that would pull in the updated setups which are maintained in the projects themselves.

Now the problem will be that you have already imported projects from the two obsolete Equinox repos. So what I did is went to the project explorer view and deleted all projects, though only from the workspace, not from disk. Then I ran the setup again and it cloned the new Equinox clone, and resolves the TP, importing all the projects. Alternatively, you could delete the two obsolete Equinox repos, including the working tree such that their workspace projects are deleted/removed and then run the setup.

It will sure be nice when this stabilizes again...

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Need help pushing a bug fix to Gerrit [message #1853123 is a reply to message #1853122]

Sun, 19 June 2022 14:13

Alex Mising name

Messages: 149
Registered: March 2010

Senior Member

Hmm, so inded the "core" stream was missing, so I manually added that line and re-ran startup tasks.

This cloned equinox.git but now the target creation fails with missing RCP bundles:

  ERROR: org.eclipse.equinox.p2.director code=10053 Cannot complete the install because one or more required items could not be found.
    ERROR: org.eclipse.equinox.p2.director code=0 Software being installed: artificial_root 1.0.0.v1655647559881
    ERROR: org.eclipse.equinox.p2.director code=0 Missing requirement: Eclipse 4 Rich Client Platform 4.25.0.v20220617-1839 (org.eclipse.e4.rcp.feature.group 4.25.0.v20220617-1839) requires 'org.eclipse.equinox.p2.iu; org.osgi.service.cm 0.0.0' but it could not be found
    ERROR: org.eclipse.equinox.p2.director code=0 Missing requirement: Eclipse 4 Rich Client Platform 4.25.0.v20220618-0417 (org.eclipse.e4.rcp.feature.group 4.25.0.v20220618-0417) requires 'org.eclipse.equinox.p2.iu; org.osgi.service.cm 0.0.0' but it could not be found
    ERROR: org.eclipse.equinox.p2.director code=1 Cannot satisfy dependency:
      ERROR: org.eclipse.equinox.p2.director code=0 From: artificial_root 1.0.0.v1655647559881
      ERROR: org.eclipse.equinox.p2.director code=0 To: org.eclipse.equinox.p2.iu; org.eclipse.e4.rcp.feature.group 0.0.0

So I assume more repos have been moved?

Either way, it seems all this is due to some ongoing migration to github, so perhaps the simplest thing is to wait a week and try again?

Report message to a moderator