Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Remote Application Platform (RAP) » Property to make ServiceManager.getServiceHandlerUrl() return relative URLs
Property to make ServiceManager.getServiceHandlerUrl() return relative URLs [message #1826206] Tue, 21 April 2020 07:41 Go to next message
Linuxhippy Mising name is currently offline Linuxhippy Mising nameFriend
Messages: 61
Registered: July 2009
Member
Hi,

I am currently working on "mainstreaming" an application which was developed against Rap 3.1 in order to allow it tun run with upstream rap.

One patch was against ServiceManager.getServiceHandlerUrl() to make it generate relative URLs. The reason is the same application can be reached via different portals, so not only the domain is changing but also the context.

so in our case the same app is reachable via:
company1.com/app/
portal.com/company1/app

Therefore I would like to propose a property to make ServiceManager generate relative URLs when the property is set.

Please have a look at the following pull request: https://github.com/eclipse/rap/pull/16
The property name is open for debate of course ;)

Thanks & best regards, Clemens

Re: Property to make ServiceManager.getServiceHandlerUrl() return relative URLs [message #1826208 is a reply to message #1826206] Tue, 21 April 2020 07:53 Go to previous messageGo to next message
Ivan Furnadjiev is currently offline Ivan FurnadjievFriend
Messages: 2358
Registered: July 2009
Location: Sofia, Bulgaria
Senior Member
Hi Clemens,

could you please provide this change in Gerrit against current RAP master branch.

Thanks,
Ivan
Re: Property to make ServiceManager.getServiceHandlerUrl() return relative URLs [message #1826211 is a reply to message #1826208] Tue, 21 April 2020 08:29 Go to previous messageGo to next message
Linuxhippy Mising name is currently offline Linuxhippy Mising nameFriend
Messages: 61
Registered: July 2009
Member
Hi Ivan,

I tried, but get the following error:

To ssh://git.eclipse.org:29418/rap/org.eclipse.rap.git
! [remote rejected] develop -> develop (prohibited by Gerrit: create access denied for refs/heads/develop)
error: Fehler beim Versenden einiger Referenzen nach 'ssh://lmisingnamel78@git.eclipse.org:29418/rap/org.eclipse.rap.git'


Re: Property to make ServiceManager.getServiceHandlerUrl() return relative URLs [message #1826214 is a reply to message #1826211] Tue, 21 April 2020 09:12 Go to previous messageGo to next message
Linuxhippy Mising name is currently offline Linuxhippy Mising nameFriend
Messages: 61
Registered: July 2009
Member
it finally worked: https://git.eclipse.org/r/#/c/161276/
Re: Property to make ServiceManager.getServiceHandlerUrl() return relative URLs [message #1826726 is a reply to message #1826214] Wed, 29 April 2020 14:03 Go to previous messageGo to next message
Linuxhippy Mising name is currently offline Linuxhippy Mising nameFriend
Messages: 61
Registered: July 2009
Member
opinions? any chance to get the upstream?
Re: Property to make ServiceManager.getServiceHandlerUrl() return relative URLs [message #1835211 is a reply to message #1826726] Fri, 27 November 2020 08:21 Go to previous messageGo to next message
Linuxhippy Mising name is currently offline Linuxhippy Mising nameFriend
Messages: 61
Registered: July 2009
Member
Ping. Is there any chance to get this change upstream?
As far as I can see the change has almost zero risk for the default configuration, yet it would help to run unpatched RAP in "special" environments where RAP apps are embedded into portals.
Re: Property to make ServiceManager.getServiceHandlerUrl() return relative URLs [message #1836543 is a reply to message #1835211] Thu, 07 January 2021 08:51 Go to previous messageGo to next message
Ivan Furnadjiev is currently offline Ivan FurnadjievFriend
Messages: 2358
Registered: July 2009
Location: Sofia, Bulgaria
Senior Member
Hi,

we will reconsider it for RAP 3.16.

Regards,
Ivan
Re: Property to make ServiceManager.getServiceHandlerUrl() return relative URLs [message #1843441 is a reply to message #1836543] Thu, 29 July 2021 20:46 Go to previous message
Linuxhippy Mising name is currently offline Linuxhippy Mising nameFriend
Messages: 61
Registered: July 2009
Member
3.17 has already arived, any chance to get this upstream with 3.18?
As far as I can see the change should be low-risk for existing environments - and doesn't add that much complexity.
Previous Topic:How to access the request parameters?
Next Topic:current master does not build due to jetty repo not reachable
Goto Forum:
  


Current Time: Tue Sep 21 12:29:24 GMT 2021

Powered by FUDForum. Page generated in 0.02479 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top