Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » EGit / JGit » EGit signing somehow not accepted by GitLab, works fine for GitHub(GitLab commit signing issues)
EGit signing somehow not accepted by GitLab, works fine for GitHub [message #1822837] Sun, 15 March 2020 08:48 Go to next message
PT 400C is currently offline PT 400CFriend
Messages: 19
Registered: July 2019
Junior Member
Hey,

today I discovered a weird problem with EGit in relation to GitLab.

Signing commits with Git Bash and then pushing them to GL works just fine. They get the "Verified" badge automatically. But when I try using EGit the process of signing and pushing also works, but at the end the commits aren't "Verified" on GitLab's end.

Both times I used exactly the same email, GPG-key and project, just signed and commited with GitBash and after that with EGit.

(Committed with GitBash, Committed with EGit)

Java:

1.8.0_221

Eclipse:

Version: 2019-12 (4.14.0)
Build id: 20191212-1212

EGit:

Version: 5.6.1

(Also tested with the nightly build 5.8.0.202003121753)

Is the problem on my end?

PT400C

"PS:" Everything works fine when using GitHub.

[Updated on: Sun, 15 March 2020 09:15]

Report message to a moderator

Re: EGit signing somehow not accepted by GitLab, works fine for GitHub [message #1822848 is a reply to message #1822837] Sun, 15 March 2020 16:28 Go to previous messageGo to next message
Thomas Wolf is currently offline Thomas WolfFriend
Messages: 364
Registered: August 2016
Senior Member
See bug 553206. The BouncyCastle library that is used by JGit to sign commits supports only an older standard, not the newest draft standard. Gitlab OTOH properly recognizes only that newer draft standard.

So, no, the problem is not on your end; it's in the Bouncy Castle library and in Gitlab.

See also

Re: EGit signing somehow not accepted by GitLab, works fine for GitHub [message #1822851 is a reply to message #1822848] Sun, 15 March 2020 17:54 Go to previous messageGo to next message
PT 400C is currently offline PT 400CFriend
Messages: 19
Registered: July 2019
Junior Member
Thank you very much for that clarification! I literally spent multiple hours reinstalling, setting up VMs and debugging the commit network packets - not finding out the actual cause of the problem.

Out of your experience, do you know how long it might take the people from bc-java to fix that? (As the problem isn't actually that new)

[Updated on: Sun, 15 March 2020 17:56]

Report message to a moderator

Re: EGit signing somehow not accepted by GitLab, works fine for GitHub [message #1822888 is a reply to message #1822851] Mon, 16 March 2020 12:07 Go to previous messageGo to next message
PT 400C is currently offline PT 400CFriend
Messages: 19
Registered: July 2019
Junior Member
Oh and one addition to that message ^ : Signed EGit merge commits actually appear to be "Verified" on GitLab. Can't explain why though.
Re: EGit signing somehow not accepted by GitLab, works fine for GitHub [message #1822928 is a reply to message #1822851] Mon, 16 March 2020 22:24 Go to previous messageGo to next message
Thomas Wolf is currently offline Thomas WolfFriend
Messages: 364
Registered: August 2016
Senior Member
PT 400C wrote on Sun, 15 March 2020 17:54
Out of your experience, do you know how long it might take the people from bc-java to fix that? (As the problem isn't actually that new)

Got no experience with bc-java. It's an open-source project; I could imagine they're just as understaffed as we are, and until a regular committer gets around to it may take a long time. It might help if a kind soul created a quality PR including tests.
Re: EGit signing somehow not accepted by GitLab, works fine for GitHub [message #1822940 is a reply to message #1822928] Tue, 17 March 2020 07:47 Go to previous messageGo to next message
PT 400C is currently offline PT 400CFriend
Messages: 19
Registered: July 2019
Junior Member
Alright. Just noticed that they replied here
Re: EGit signing somehow not accepted by GitLab, works fine for GitHub [message #1823583 is a reply to message #1822837] Sun, 29 March 2020 15:22 Go to previous messageGo to next message
PT 400C is currently offline PT 400CFriend
Messages: 19
Registered: July 2019
Junior Member
Okay, somehow it works again. Probably GitLab added the support of the old protocol again.
Re: EGit signing somehow not accepted by GitLab, works fine for GitHub [message #1828813 is a reply to message #1823583] Fri, 19 June 2020 06:51 Go to previous message
Thomas Wolf is currently offline Thomas WolfFriend
Messages: 364
Registered: August 2016
Senior Member
Gitlab versions < 12.10 had a bug that makes signature verification fail for commits with commit messages that do not end in a newline. See https://gitlab.com/gitlab-org/gitaly/-/issues/2545 and bug 564428 comment 5.
Previous Topic:Signing not shown as verified by GitLab
Next Topic:Cannot Open Compare Editor - This is a merge commit with more than one ancestor
Goto Forum:
  


Current Time: Wed Jun 16 01:11:12 GMT 2021

Powered by FUDForum. Page generated in 0.01997 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top