Eclipse Community Forums: EGit / JGit

Home » Eclipse Projects » EGit / JGit » Invalid branch name(JGit throwing InvalidRefNameException (used to work in version 4))

Thu, 23 August 2018 18:48

Messages: 2
Registered: June 2018

Junior Member

Hi,

I have migrated to version 5.0.2 and trying to create a new branch name with "-feat--ure/1.0-" .

Repository.isValidRefName("-feat--ure/1.0-")

returns true.
But I am still getting the exception when doing

git.branchCreate().setName("-feat--ure/1.0-").call()

.
It used to work in version 4.11.0

Has this validation changed?

Starting dash seems to be the problem. Command line Git allows that.

Thanks

[Updated on: Thu, 23 August 2018 19:03]

Fri, 24 August 2018 12:54

Messages: 1039
Registered: July 2009

Senior Member

yes, see [1] which fixes [2]. Now branch names cannot start with a '-' anymore which is also rejected by native git.

The following checks need to pass with result true for a branch name to be valid [3]:
- Repository.isValidRefName(String refName)
- CreateBranchCommand.isValidBranchName(String branchName)

[1] https://git.eclipse.org/r/#/c/124272/
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=535655
[3] https://git.eclipse.org/r/plugins/gitiles/jgit/jgit/+/master/org.eclipse.jgit/src/org/eclipse/jgit/api/CreateBranchCommand.java#288

Previous Topic:	Java 11 Compatibility check: JGit
Next Topic:	Wanna use 'org.eclipse.egit.github.core' in a project

Goto Forum:

]

Current Time: Mon Nov 19 21:31:29 GMT 2018

.:: Contact :: Home ::.

Sign up to our Newsletter