Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » Eclipse Layout Kernel » Issue with Sirius Custom Layout and ELK Layout
Issue with Sirius Custom Layout and ELK Layout [message #1792793] Tue, 24 July 2018 07:43 Go to next message
Rakesh Nidavani is currently offline Rakesh NidavaniFriend
Messages: 10
Registered: March 2018
Junior Member
Hello ,

When using Sirius with our custom layouts, we encountered an issue due to the presence of ELK plugins.

ELK Defines a generic laout provider which is contributed using the extension : org.eclipse.gmf.runtime.diagram.ui.layoutProviders
Plugin : org.eclipse.elk.conn.gmf

Problem 1 : The ELK Layout provider has a very general "provides" method :
/**
* {@inheritDoc}
*/
public boolean provides(final IOperation operation) {
return operation instanceof ILayoutNodeOperation;
}

Due to this, the layout provider is applicable for almost all use cases.
This is not an issue on its own, since a generic layout provider is expected to work this way.

However,

Problem 2 : The ELK Layout Provider is also contributed with the highest possible priority.
In the extension specification, the provider is assigned with the priority "Highest".

Due to the above two points, it is impossible to have a custom layout contributed when ELK Layout is included in the list of plugins.

Proposal :
Change the priority of the ELK Layout contribution to a lower value.
This will ensure that other custom layouts can be integrated along with ELK Layouts.


Regards,
Rakesh

[Updated on: Tue, 24 July 2018 07:44]

Report message to a moderator

Re: Issue with Sirius Custom Layout and ELK Layout [message #1792803 is a reply to message #1792793] Tue, 24 July 2018 09:29 Go to previous messageGo to next message
Miro Spönemann is currently offline Miro SpönemannFriend
Messages: 49
Registered: March 2015
Location: Kiel, Germany
Member

Please write a GitHub issue for this.
Re: Issue with Sirius Custom Layout and ELK Layout [message #1792809 is a reply to message #1792803] Tue, 24 July 2018 09:53 Go to previous message
Rakesh Nidavani is currently offline Rakesh NidavaniFriend
Messages: 10
Registered: March 2018
Junior Member
Hello ,

We have created a new issue.

https://github.com/eclipse/elk/issues/356

Regards,
Rakesh
Previous Topic:[ELK] NPE exception in ELK 0.4.0
Next Topic:Deactivate ELK
Goto Forum:
  


Current Time: Sat Sep 22 17:31:41 GMT 2018

Powered by FUDForum. Page generated in 0.01432 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top