Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » TMF (Xtext) » Content Assist problem
Content Assist problem [message #1778788] Thu, 21 December 2017 13:05 Go to next message
Romain Bernard is currently offline Romain BernardFriend
Messages: 27
Registered: July 2009
Junior Member
Hi Xtext team,

I have a strange content assist problem for a language that extends xbase. In some very specific and strange circumstances (see tests below), the content assist does not work anymore, and seems to depend on other elements defined before the place where the problem occurs.
As far as I understand, the computation of followElements by the parser does not produce the right elements in the test with errors...

I also attach a complete example...

In advance, thank you for your help !
Kind regards,
Romain

grammar :
grammar org.xtext.example.buggy.MyDsl with org.eclipse.xtext.xbase.annotations.XbaseWithAnnotations

generate myDsl "http://www.xtext.org/example/buggy/MyDsl"
import 'http://www.eclipse.org/xtext/xbase/Xbase' as xbase

Model:
	package=PackageDeclaration;

PackageDeclaration:
	'package' name=QualifiedName ';'?
	importSection=XImportSection?
	rootElement=RootElement;
	
RootElement:
	'class' name=ID body=XBlockExpression;
	
AbstractElement returns xbase::XExpression:
	InstructionA | InstructionB
;

InstructionA returns xbase::XExpression:
	{InstructionA} 'A' "intProperty:" intProperty=XExpression body=XBlockExpression
;

InstructionB returns xbase::XExpression:
	{InstructionB}
	'B' "enumProperty:" enumProperty=EnumType body=XBlockExpression;

enum EnumType:
	literal1 = "literal1" | literal2 = "literal2"
;

@ Override XExpression returns xbase::XExpression:
	XAssignment | AbstractElement;


JvmModelInferrer:
package org.xtext.example.buggy.jvmmodel

import com.google.inject.Inject
import org.eclipse.xtext.xbase.jvmmodel.AbstractModelInferrer
import org.eclipse.xtext.xbase.jvmmodel.IJvmDeclaredTypeAcceptor
import org.eclipse.xtext.xbase.jvmmodel.JvmTypesBuilder
import org.xtext.example.buggy.myDsl.Model

class MyDslJvmModelInferrer extends AbstractModelInferrer {

	@Inject extension JvmTypesBuilder

	def dispatch void infer(Model element, IJvmDeclaredTypeAcceptor acceptor, boolean isPreIndexingPhase) {
		val pkg = element.package
		val rootElement = pkg?.rootElement

 		acceptor.accept(element.toClass(pkg.name + "." + rootElement.name)) [
			
 			members += element.toMethod("main", typeRef("void")) [
 				body = rootElement.body
 			]

		]
	}
}


Compiler:
package org.xtext.example.buggy.jvmmodel

import org.eclipse.xtext.xbase.XExpression
import org.eclipse.xtext.xbase.compiler.XbaseCompiler
import org.eclipse.xtext.xbase.compiler.output.ITreeAppendable
import org.xtext.example.buggy.myDsl.InstructionA
import org.xtext.example.buggy.myDsl.InstructionB

class MyDslCompiler extends XbaseCompiler {

	override protected doInternalToJavaStatement(XExpression expr, ITreeAppendable it, boolean isReferenced) {
		switch expr {
			InstructionA: {
				newLine
				append('''// code comes here for InstructionA''')
				expr.body.internalToJavaStatement(it, false)
			}
			InstructionB: {
				newLine
				append('''// code comes here for InstructionA''')
				expr.body.internalToJavaStatement(it, false)
			}
			default: {
				super.doInternalToJavaStatement(expr, it, isReferenced)
			}
		}
	}

	override protected internalToConvertedExpression(XExpression obj, ITreeAppendable it) {
		if (hasName(obj)) {
			append(getName(obj))
		} else
			super.internalToConvertedExpression(obj, it)
	}

}


TypesComputer:
package org.xtext.example.buggy.jvmmodel

import org.eclipse.xtext.xbase.XExpression
import org.eclipse.xtext.xbase.annotations.typesystem.XbaseWithAnnotationsTypeComputer
import org.eclipse.xtext.xbase.typesystem.computation.ITypeComputationState
import org.xtext.example.buggy.myDsl.InstructionA
import org.xtext.example.buggy.myDsl.InstructionB
import org.xtext.example.buggy.myDsl.RootElement

class MyDslTypeComputer extends XbaseWithAnnotationsTypeComputer {

	override computeTypes(XExpression expression, ITypeComputationState state) {
		if (expression instanceof InstructionA) {
			_computeTypes(expression, state);
		} else if (expression instanceof InstructionB) {
			_computeTypes(expression, state);
		} else if (expression instanceof RootElement) {
			_computeTypes(expression, state);
		} else {
			super.computeTypes(expression, state)
		}
	}

	protected def _computeTypes(RootElement expression, ITypeComputationState state) {
		state.acceptActualType(getTypeForName(Void.TYPE, state));
		if (expression.body !== null) {
			computeTypes(expression.body, state)
		}
	}

	protected def _computeTypes(InstructionA expression, ITypeComputationState state) {
		state.acceptActualType(getTypeForName(Void.TYPE, state));
		if (expression.intProperty !== null) {
			computeTypes(expression.intProperty, state)
		}
		if (expression.body !== null) {
			computeTypes(expression.body, state)
		}
	}

	protected def _computeTypes(InstructionB expression, ITypeComputationState state) {
		state.acceptActualType(getTypeForName(Void.TYPE, state));
		if (expression.body !== null) {
			computeTypes(expression.body, state)
		}
	}

}


Validator:
package org.xtext.example.buggy.validation

import org.eclipse.xtext.xbase.XExpression

class MyDslValidator extends AbstractMyDslValidator {

	def override checkInnerExpressions(XExpression expr) {
	}

}


I wrote tests to reproduce the problem :
package org.xtext.example.buggy.ui.tests

import org.eclipse.xtext.testing.InjectWith
import org.eclipse.xtext.testing.XtextRunner
import org.eclipse.xtext.xbase.junit.ui.AbstractContentAssistTest
import org.junit.Test
import org.junit.runner.RunWith

@RunWith(XtextRunner)
@InjectWith(MyDslUiInjectorProvider)
class ContentAssistTest extends AbstractContentAssistTest {
	
	/**
	 * Always work outside of a for() {} instruction
	 */
	@Test
	def void testWithSuccess1() {
		newBuilder.append('''package aaa
		
		class Test { 
			  
			A intProperty:10 {	}
			B enumProperty: ''').assertText("literal1", "literal2")
	}
	
	/**
	 * Works inside a for instruction, if not preceded by A
	 */
	@Test
	def void testWithSuccess2() {
		newBuilder.append('''
		package aaa
		
		class Test { 
			  
			for (var i = 1; i < 10; i++) { 
				B enumProperty: ''').assertText("literal1", "literal2")
	}
	
	/**
	 * FIXME
	 * Does not work if preceded by A, and if A's intProperty uses a XNumberLiteral
	 */
	@Test
	def void testWithError1() {
		newBuilder.append('''
		package aaa
		
		class Test { 
			  
			for (var i = 1; i < 10; i++) { 
				A intProperty:10 {	}
				B enumProperty: ''').assertText("literal1", "literal2")
	}
	
	/**
	 * But works if preceded by a A instruction with a XFeatureCall integer expression (here a simple reference to a variable) !
	 */
	@Test
	def void testWithSuccess3() {
		newBuilder.append('''
		package aaa
		
		class Test { 
			
			var intValue = 10
			for (var i = 1; i < 10; i++) { 
				A intProperty:intValue {	}
				B enumProperty: ''').assertText("literal1", "literal2")
	}
	
	/**
	 * Works inside while
	 */
	@Test
	def void testWithSuccess4() {
		newBuilder.append('''
		package aaa
		
		class Test { 
			
			var intValue = 10
			while (intValue < 70) {
					A intProperty:10 {	}
					B enumProperty: ''').assertText("literal1", "literal2")
	}
	
	
	/**
	 * Works inside if
	 */
	 @Test
	def void testWithSuccess5() {
		newBuilder.append('''
		package aaa
		
		class Test { 
			
			var intValue = 10
			if (intValue>80) {
					A intProperty:10 {	}
					B enumProperty: ''').assertText("literal1", "literal2")
	}
	
}

Re: Content Assist problem [message #1778789 is a reply to message #1778788] Thu, 21 December 2017 13:08 Go to previous messageGo to next message
Romain Bernard is currently offline Romain BernardFriend
Messages: 27
Registered: July 2009
Junior Member
It seems that the attchment was not really attached. Second try...
Re: Content Assist problem [message #1781040 is a reply to message #1778789] Wed, 31 January 2018 17:35 Go to previous messageGo to next message
Romain Bernard is currently offline Romain BernardFriend
Messages: 27
Registered: July 2009
Junior Member
Hi,

As far as I understand while debugging this problem, the problem is related to the computation of FollowElements, that do not behave as expected depending of the xtext model.

Any hint to avoid this ? Or should I open a bug ?

Regards
Romain
Re: Content Assist problem [message #1781046 is a reply to message #1781040] Wed, 31 January 2018 18:36 Go to previous messageGo to next message
Christian Dietrich is currently offline Christian DietrichFriend
Messages: 12229
Registered: July 2009
Senior Member
Sorry I have no idea.
You can file a bug but I have doubt it would be investigated soon


Need professional support for Xtext, Xpand, EMF?
Go to: https://xtext.itemis.com
Twitter : @chrdietrich
Blog : https://www.dietrich-it.de
Re: Content Assist problem [message #1781049 is a reply to message #1781046] Wed, 31 January 2018 19:19 Go to previous messageGo to next message
Christian Dietrich is currently offline Christian DietrichFriend
Messages: 12229
Registered: July 2009
Senior Member
i tested this in a running eclipse with xtext 2.14 nightly and the content assist was fine when run manually.


Need professional support for Xtext, Xpand, EMF?
Go to: https://xtext.itemis.com
Twitter : @chrdietrich
Blog : https://www.dietrich-it.de
Re: Content Assist problem [message #1781071 is a reply to message #1781049] Thu, 01 February 2018 07:50 Go to previous messageGo to next message
Romain Bernard is currently offline Romain BernardFriend
Messages: 27
Registered: July 2009
Junior Member
No Message Body

[Updated on: Thu, 01 February 2018 07:53]

Report message to a moderator

Re: Content Assist problem [message #1781072 is a reply to message #1781049] Thu, 01 February 2018 07:51 Go to previous messageGo to next message
Romain Bernard is currently offline Romain BernardFriend
Messages: 27
Registered: July 2009
Junior Member
No Message Body

[Updated on: Thu, 01 February 2018 07:52]

Report message to a moderator

Re: Content Assist problem [message #1781073 is a reply to message #1781049] Thu, 01 February 2018 07:51 Go to previous messageGo to next message
Romain Bernard is currently offline Romain BernardFriend
Messages: 27
Registered: July 2009
Junior Member
Thank you for your response.

I have installed Xtext 2.14 but the 'ui.tests' demo project is still KO when running the JUnit plugin tests...
Regards
Re: Content Assist problem [message #1781075 is a reply to message #1781073] Thu, 01 February 2018 08:28 Go to previous messageGo to next message
Christian Dietrich is currently offline Christian DietrichFriend
Messages: 12229
Registered: July 2009
Senior Member
question: does it fail in tests only or in manual invocation in the ide as well

Need professional support for Xtext, Xpand, EMF?
Go to: https://xtext.itemis.com
Twitter : @chrdietrich
Blog : https://www.dietrich-it.de
Re: Content Assist problem [message #1781078 is a reply to message #1781075] Thu, 01 February 2018 08:51 Go to previous messageGo to next message
Romain Bernard is currently offline Romain BernardFriend
Messages: 27
Registered: July 2009
Junior Member
In manual as well (still with Xtext14)...

package aaa

class Test {
	
	// Does not work
	for (var i = 1; i < 10; i++) { 
		A intProperty:10 {	}
		B enumProperty: // <-- content assist here
		literal1 {}
	}
	
	// Works !!!
	for (var i = 1; i < 10; i++) { 
		//A intProperty:10 {	}
		B enumProperty: // <-- content assist here
		literal1 {}
	}
}


Re: Content Assist problem [message #1781085 is a reply to message #1781078] Thu, 01 February 2018 09:26 Go to previous messageGo to next message
Romain Bernard is currently offline Romain BernardFriend
Messages: 27
Registered: July 2009
Junior Member
As far as I understand, when failing, the FollowElementComputer.computeFollowElements returns an empty list, => no context can be found for the ProposalProvider (and as a result, the expected complete_EClass_feature method is never called in the ProposalProvider).
Re: Content Assist problem [message #1781092 is a reply to message #1781085] Thu, 01 February 2018 10:13 Go to previous messageGo to next message
Christian Dietrich is currently offline Christian DietrichFriend
Messages: 12229
Registered: July 2009
Senior Member
hmmm please open a bug at xtext-core

Need professional support for Xtext, Xpand, EMF?
Go to: https://xtext.itemis.com
Twitter : @chrdietrich
Blog : https://www.dietrich-it.de
Re: Content Assist problem [message #1781111 is a reply to message #1781092] Thu, 01 February 2018 14:11 Go to previous message
Romain Bernard is currently offline Romain BernardFriend
Messages: 27
Registered: July 2009
Junior Member
Issue opened (https://github.com/eclipse/xtext-core/issues/629).
Thanks for your support !
Previous Topic:Validate two models of different metamodels
Next Topic:Xbase DSL run codegen with Maven
Goto Forum:
  


Current Time: Wed Sep 19 09:28:53 GMT 2018

Powered by FUDForum. Page generated in 0.02314 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top