Eclipse Community Forums: Rich Client Platform (RCP) » IEvaluationService variableFilter Set

Home » Eclipse Projects » Rich Client Platform (RCP) » IEvaluationService variableFilter Set(Why is ISources.ACTIVE_EDITOR_NAME omitted?)

Show: Today's Messages :: Show Polls :: Message Navigator

IEvaluationService variableFilter Set [message #1773522]

Thu, 28 September 2017 19:27

darrel karisch

Messages: 13
Registered: July 2012

Junior Member

IEvaluationService variableFilter is loaded with several, but not all, ISources values...

{ ISources.ACTIVE_WORKBENCH_WINDOW_NAME,
ISources.ACTIVE_WORKBENCH_WINDOW_SHELL_NAME, ISources.ACTIVE_EDITOR_ID_NAME,
ISources.ACTIVE_EDITOR_INPUT_NAME,
ISources.SHOW_IN_INPUT,
ISources.SHOW_IN_SELECTION,
ISources.ACTIVE_PART_NAME,
ISources.ACTIVE_PART_ID_NAME,
ISources.ACTIVE_SITE_NAME,
ISources.ACTIVE_CONTEXT_NAME,
ISources.ACTIVE_CURRENT_SELECTION_NAME }

Why is ISources.ACTIVE_EDITOR_NAME omitted?

is this an intentional omission?

it seems that it belongs among them considering the inclusion of other ACTIVE_EDITOR values.

Report message to a moderator

Re: IEvaluationService variableFilter Set [message #1780809 is a reply to message #1773522]

Sun, 28 January 2018 11:52

Wim Jongman

Messages: 432
Registered: July 2009

Senior Member

Hi Darrel,

Editors and Views are both Parts.

Cheers,

Wim

[Updated on: Sun, 28 January 2018 11:53]

Report message to a moderator

Re: IEvaluationService variableFilter Set [message #1780877 is a reply to message #1780809]

Mon, 29 January 2018 13:32

darrel karisch

Messages: 13
Registered: July 2012

Junior Member

Thank you for your response, but it does not answer the question.

As you know ISources are the values behind core expression variables... https://wiki.eclipse.org/Command_Core_Expressions#Variables_and_the_Command_Framework

... and ISources.ACTIVE_EDITOR_NAME corresponds to activeEditor.

variableFilter prevents values in the Set from being added or removed from the workbench IEclipseContext in EvaluationService.changeVariable method.

My question is why is ACTIVE_EDITOR_NAME omitted from the Set?

WorkbenchSourceProvider sets all of the variableFilter ISources values. Only ISources.ACTIVE_EDITOR_NAME is allowed through the filter. This seems like an error of omission. Or is there some rationale for omitting it?

Report message to a moderator

Previous Topic:	Change <launcher>.ini File
Next Topic:	MalformedURLException for Welcome (intro) page on 64-bit RHEL

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat Nov 17 21:04:54 GMT 2018

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter