Eclipse Community Forums: scout » Form validation in Contacts Application

Home » Eclipse Projects » scout » Form validation in Contacts Application(The validation of first name and last name does not seem to work properly)

Show: Today's Messages :: Show Polls :: Message Navigator

Form validation in Contacts Application [message #1767676]

Sun, 09 July 2017 09:32

Stéphane Levy

Messages: 6
Registered: July 2017

Junior Member

Hello,

I am experimenting a strange behavior on the "New person" form of the Contacts Application. It concerns the validation of the first name and last name, one of them at least must be fill.
This works properly at the beginning, I am able to enter a person with only a first name or a last ame.
The problem occurs when I follow this actions :
- I first submit a form without a first name and a last name
- I get an alert : Missing Name (this alert is normal)
- I then fill a first name or a last name or both and when I submit, I have an alert different from the first one : "The following fields are invalid : General : Missing name"
- The form can not be submitted any more.

I have reproduced this behavior with eclipse scout 6.0.300.RC2 and 7.0.0-SNAPSHOT and in the deployed app in https:// scout.bsi-software.com/contacts/

I am using Firefox 54.0 (32 bits) on Ubuntu 16.

I don't think this behavior is normal, can you reproduce it ?
Is it a bug ?

Thank you very much.

Report message to a moderator

Re: Form validation in Contacts Application [message #1767677 is a reply to message #1767676]

Sun, 09 July 2017 09:52

Matthias Zimmermann

Messages: 207
Registered: June 2015

Senior Member

definitively sound's like a bug, thanks for reporting. we will look into this shortly.
matthias

Report message to a moderator

Re: Form validation in Contacts Application [message #1767694 is a reply to message #1767677]

Mon, 10 July 2017 04:23

Matthias Otterbach

Messages: 22
Registered: August 2015
Location: Munich

Junior Member

I can confirm this bug, there is a custom org.eclipse.scout.contacts.client.person.PersonForm.execValidate() method which adds an error status to the PersonForm.MainBox.GeneralBoxGeneralBox on the first time either the first or the last name field is not filled correctly.

The next time the form is validated every field is checked if they are valid. As the PersonForm.MainBox.GeneralBoxGeneralBox is not valid anymore (an error status was added the last time the form was validated) the second message is shown. As there are already invalid fields, the whole form is not validated again anymore (the execValidate method above is not called again even though this one seems to be implemented to remove the error status from the group box if all fields are valid now).

Report message to a moderator

Re: Form validation in Contacts Application [message #1768295 is a reply to message #1767694]

Mon, 17 July 2017 07:46

Beat Schwarzentrub

Messages: 104
Registered: November 2010

Senior Member

Stéphane,

Matthias is right, the form validation code here is not quite correct. I will try to improve the form in the following weeks. Thanks for pointing that out!

Basically, manually adding an error status to a field is only required for complex cases. If you do that, you have to make sure the status is also removed when the field values become correct. (This is what doesn't happen in the contacts app.)

For most cases however it should be sufficient to override execValidateValue() (field validation) or execValidate() (form or form handler validation) and throw a VetoException with a corresponding message if the validation fails. Mandatory fields can be marked by setting getConfiguredMandatory() to true. This property can also be manipulated at runtime using field.setMandatory(true), for example in the execValueChanged() of another field.

Regards,
Beat

Report message to a moderator