Eclipse Community Forums: EMF » Resources loaded from platform:/plugin URIs are not considered read-only by EcoreEditor

Help

Home

Home » Modeling » EMF » Resources loaded from platform:/plugin URIs are not considered read-only by EcoreEditor

Show: Today's Messages :: Show Polls :: Message Navigator

Resources loaded from platform:/plugin URIs are not considered read-only by EcoreEditor [message #1759197]

Fri, 07 April 2017 14:50

Abel Hegedus

Messages: 187
Registered: September 2015

Senior Member

When using "Load resource" in the Sample Reflective Ecore Editor and using a platform:/plugin URI (e.g. for development version of registered packages), the user can change the model since neither org.eclipse.emf.edit.domain.AdapterFactoryEditingDomain.isReadOnly(Resource) nor isReadOnly() implementation of the anonymous AdapterFactoryEditingDomain class in org.eclipse.emf.ecore.presentation.EcoreEditor.initializeEditingDomain() returns true for such URIs.

Is this intentional?

Saving the editor after modifying such resources also results in an exception:

java.io.IOException: cannot delete D:\tools\eclipse\p2\pool\plugins\org.eclipse.xtext_2.9.1.v201512180746.jar
	at org.eclipse.emf.common.archive.ArchiveURLConnection$2.close(ArchiveURLConnection.java:524)
	at org.eclipse.emf.ecore.resource.impl.ResourceImpl.saveOnlyIfChangedWithMemoryBuffer(ResourceImpl.java:1241)
	at org.eclipse.emf.ecore.resource.impl.ResourceImpl.save(ResourceImpl.java:985)
	at org.eclipse.emf.ecore.presentation.EcoreEditor$15.execute(EcoreEditor.java:1669)
	at org.eclipse.ui.actions.WorkspaceModifyOperation$1.run(WorkspaceModifyOperation.java:108)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2241)
	at org.eclipse.ui.actions.WorkspaceModifyOperation.run(WorkspaceModifyOperation.java:130)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:119)

Report message to a moderator

Re: Resources loaded from platform:/plugin URIs are not considered read-only by EcoreEditor [message #1759203 is a reply to message #1759197]

Fri, 07 April 2017 08:02

Ed Merks

Messages: 29325
Registered: July 2009

Senior Member

No, that seems kind of bad. I guess mostly it's gone unnoticed because the resource isn't changed so saving it doesn't need to save anything.

Please open a Bugzilla.

Report message to a moderator

Re: Resources loaded from platform:/plugin URIs are not considered read-only by EcoreEditor [message #1759283 is a reply to message #1759197]

Mon, 10 April 2017 07:22

Abel Hegedus

Messages: 187
Registered: September 2015

Senior Member

Done: https://bugs.eclipse.org/bugs/show_bug.cgi?id=514947 and already fixed. Thanks, Ed!

Report message to a moderator

Previous Topic:	How to do JAXB annotations in ecore?
Next Topic:	[CDO/Papyrus] Marte profile issue

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Mon Apr 23 21:39:33 GMT 2018

.:: Contact :: Home ::.