|
| Re: WorkspaceCommandStackImpl should probably override isSaveNeeded and saveIsDone of BasicCommandSt [message #33601 is a reply to message #33567] |
Mon, 08 May 2006 12:49   |
Eclipse User |
|
|
|
Originally posted by: merks.ca.ibm.com
Alexander,
Please open a bugzilla when bugzilla is back on line.
Alexander Nyßen wrote:
>Hallo,
>
>as I was currently not able to connect to the Eclipse bugs portal (reason is
>too many connections), I think I could post my bug-report/change-request in
>this newsgroup:
>
>I am working with the WorkspaceCommandStackImpl of the
>org.eclipse.emf.workspace project. I noticed that it subclasses
>org.eclipse.emf.common.command.BasicCommandStack but does not make any use
>the of the super implementations of execute, undo and redo.
>
>BasicCommandStack offers some methods to set resp. retrieve the dirty state
>of the command stack, namely isSaveNeeded and saveIsDone. The implementation
>of these methods is based on correct calls to execute, redo and undo methods
>(in BasicCommandStack). As WorkspaceCommandStackImpl does not call the super
>implementations, isSaveNeeded and saveIsDone do no longer work when being
>called.
>
>I would propose to either reimplement these methods in
>WorkspaceCommandStackImpl to give them correct behaviour or at least
>override them and raise an UnsupportedOperationException inside, so a caller
>of this method gets notified about the missing behaviour.
>
>Regards
>Alexander Nyßen
>
>
>
>
>
>
>
|
|
|
|
| Re: WorkspaceCommandStackImpl should probably override isSaveNeeded and saveIsDone of BasicCommandSt [message #577102 is a reply to message #33567] |
Mon, 08 May 2006 12:49 |
 Ed Merks
Messages: 33216
Registered: July 2009 |
Senior Member |
|
|
Alexander,
Please open a bugzilla when bugzilla is back on line.
Alexander Nyßen wrote:
>Hallo,
>
>as I was currently not able to connect to the Eclipse bugs portal (reason is
>too many connections), I think I could post my bug-report/change-request in
>this newsgroup:
>
>I am working with the WorkspaceCommandStackImpl of the
>org.eclipse.emf.workspace project. I noticed that it subclasses
>org.eclipse.emf.common.command.BasicCommandStack but does not make any use
>the of the super implementations of execute, undo and redo.
>
>BasicCommandStack offers some methods to set resp. retrieve the dirty state
>of the command stack, namely isSaveNeeded and saveIsDone. The implementation
>of these methods is based on correct calls to execute, redo and undo methods
>(in BasicCommandStack). As WorkspaceCommandStackImpl does not call the super
>implementations, isSaveNeeded and saveIsDone do no longer work when being
>called.
>
>I would propose to either reimplement these methods in
>WorkspaceCommandStackImpl to give them correct behaviour or at least
>override them and raise an UnsupportedOperationException inside, so a caller
>of this method gets notified about the missing behaviour.
>
>Regards
>Alexander Nyßen
>
>
>
>
>
>
>
Ed Merks
Professional Support: https://www.macromodeling.com/
|
|
|
|
Powered by
FUDForum. Page generated in 0.03448 seconds
] 
Search
Help
Register
Login
Home
