Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » EMF "Technology" (Ecore Tools, EMFatic, etc)  » WorkspaceCommandStackImpl should probably override isSaveNeeded and saveIsDone of BasicCommandStack
WorkspaceCommandStackImpl should probably override isSaveNeeded and saveIsDone of BasicCommandStack [message #33567] Mon, 08 May 2006 11:58 Go to next message
Alexander NyÃ?en is currently offline Alexander NyÃ?enFriend
Messages: 38
Registered: July 2009
Member
Hallo,

as I was currently not able to connect to the Eclipse bugs portal (reason is
too many connections), I think I could post my bug-report/change-request in
this newsgroup:

I am working with the WorkspaceCommandStackImpl of the
org.eclipse.emf.workspace project. I noticed that it subclasses
org.eclipse.emf.common.command.BasicCommandStack but does not make any use
the of the super implementations of execute, undo and redo.

BasicCommandStack offers some methods to set resp. retrieve the dirty state
of the command stack, namely isSaveNeeded and saveIsDone. The implementation
of these methods is based on correct calls to execute, redo and undo methods
(in BasicCommandStack). As WorkspaceCommandStackImpl does not call the super
implementations, isSaveNeeded and saveIsDone do no longer work when being
called.

I would propose to either reimplement these methods in
WorkspaceCommandStackImpl to give them correct behaviour or at least
override them and raise an UnsupportedOperationException inside, so a caller
of this method gets notified about the missing behaviour.

Regards
Alexander Ny
Re: WorkspaceCommandStackImpl should probably override isSaveNeeded and saveIsDone of BasicCommandSt [message #33601 is a reply to message #33567] Mon, 08 May 2006 12:49 Go to previous messageGo to next message
Eclipse UserFriend
Originally posted by: merks.ca.ibm.com

Alexander,

Please open a bugzilla when bugzilla is back on line.


Alexander Nyßen wrote:

>Hallo,
>
>as I was currently not able to connect to the Eclipse bugs portal (reason is
>too many connections), I think I could post my bug-report/change-request in
>this newsgroup:
>
>I am working with the WorkspaceCommandStackImpl of the
>org.eclipse.emf.workspace project. I noticed that it subclasses
>org.eclipse.emf.common.command.BasicCommandStack but does not make any use
>the of the super implementations of execute, undo and redo.
>
>BasicCommandStack offers some methods to set resp. retrieve the dirty state
>of the command stack, namely isSaveNeeded and saveIsDone. The implementation
>of these methods is based on correct calls to execute, redo and undo methods
>(in BasicCommandStack). As WorkspaceCommandStackImpl does not call the super
>implementations, isSaveNeeded and saveIsDone do no longer work when being
>called.
>
>I would propose to either reimplement these methods in
>WorkspaceCommandStackImpl to give them correct behaviour or at least
>override them and raise an UnsupportedOperationException inside, so a caller
>of this method gets notified about the missing behaviour.
>
>Regards
>Alexander Nyßen
>
>
>
>
>
>
>
Re: WorkspaceCommandStackImpl should probably override isSaveNeeded and saveIsDone of BasicCommandSt [message #33635 is a reply to message #33601] Mon, 08 May 2006 13:16 Go to previous message
Alexander NyÃ?en is currently offline Alexander NyÃ?enFriend
Messages: 38
Registered: July 2009
Member
Ok, did it. Newly created bug is #140552.

Regards
Alexander Ny
Re: WorkspaceCommandStackImpl should probably override isSaveNeeded and saveIsDone of BasicCommandSt [message #577102 is a reply to message #33567] Mon, 08 May 2006 12:49 Go to previous message
Ed Merks is currently offline Ed MerksFriend
Messages: 33149
Registered: July 2009
Senior Member
Alexander,

Please open a bugzilla when bugzilla is back on line.


Alexander Nyßen wrote:

>Hallo,
>
>as I was currently not able to connect to the Eclipse bugs portal (reason is
>too many connections), I think I could post my bug-report/change-request in
>this newsgroup:
>
>I am working with the WorkspaceCommandStackImpl of the
>org.eclipse.emf.workspace project. I noticed that it subclasses
>org.eclipse.emf.common.command.BasicCommandStack but does not make any use
>the of the super implementations of execute, undo and redo.
>
>BasicCommandStack offers some methods to set resp. retrieve the dirty state
>of the command stack, namely isSaveNeeded and saveIsDone. The implementation
>of these methods is based on correct calls to execute, redo and undo methods
>(in BasicCommandStack). As WorkspaceCommandStackImpl does not call the super
>implementations, isSaveNeeded and saveIsDone do no longer work when being
>called.
>
>I would propose to either reimplement these methods in
>WorkspaceCommandStackImpl to give them correct behaviour or at least
>override them and raise an UnsupportedOperationException inside, so a caller
>of this method gets notified about the missing behaviour.
>
>Regards
>Alexander Nyßen
>
>
>
>
>
>
>


Ed Merks
Professional Support: https://www.macromodeling.com/
Re: WorkspaceCommandStackImpl should probably override isSaveNeeded and saveIsDone of BasicCommandSt [message #577122 is a reply to message #33601] Mon, 08 May 2006 13:16 Go to previous message
Alexander NyÃ?en is currently offline Alexander NyÃ?enFriend
Messages: 38
Registered: July 2009
Member
Ok, did it. Newly created bug is #140552.

Regards
Alexander Ny
Previous Topic:WorkspaceCommandStackImpl should probably override isSaveNeeded and saveIsDone of BasicCommandStack
Next Topic:Validation & OCL
Goto Forum:
  


Current Time: Wed May 22 14:05:43 GMT 2024

Powered by FUDForum. Page generated in 0.04852 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top