Eclipse Community Forums: EMF "Technology" (Ecore Tools, EMFatic, etc)

Home » Modeling » EMF "Technology" (Ecore Tools, EMFatic, etc) » [EMFFORMS] TreeViewerSWTFactory and RAP(dependencies compatibility with TreeViewerSWTFactory and RAP)

[EMFFORMS] TreeViewerSWTFactory and RAP [message #1748130]

Fri, 18 November 2016 12:56

Eclipse User

This description of TreeViewerSWTFactory didn't mention any restrictions for use in RAP, but when I tried to use it in my RAP application, it was requiring additional dependencies. Before I go to extra trouble of debugging this, I just wanted to confirm if TreeViewerSWTFactory and TableViewerFactory are also intended for use in RAP.
Thanks,
Jay

http://eclipsesource.com/blogs/2016/03/09/emf-forms-1-8-0-feature-factories-for-treeviewer-and-tableviewer/

Re: [EMFFORMS] TreeViewerSWTFactory and RAP [message #1748231 is a reply to message #1748130]

Mon, 21 November 2016 07:25

Eclipse User

Hi,

we did not use it ourselves in any project. There might be minor things, which do not work. If you identify those, it is likely possible to fix them.
Best regards
Jonas

Re: [EMFFORMS] TreeViewerSWTFactory and RAP [message #1748586 is a reply to message #1748231]

Thu, 24 November 2016 14:18

Eclipse User

Ok, I used the eclipse rap/rcp neon platform.
I created the makeithappen RAP example, and set the workspace to use its target. No problem with the default.

Then I modified its View.java to use the UserGroup class for display.

No problem with this, other than the scrolling range not working well.

final UserGroup ug = TaskFactory.eINSTANCE.createUserGroup();
ug.setName("group1");
for (int i = 0; i < 10; i++) {
final User usi = TaskFactory.eINSTANCE.createUser();
usi.setLastName("UsLast" + i);
usi.setEmail("UsEmail" + i);
ug.getUsers().add(usi);
}

render = ECPSWTViewRenderer.INSTANCE.render(content, ug);

content.layout();

-----------------
Now I simply remove the 'render =' line, replace it with
TreeViewerSWTFactory.createTreeViewer(content, ug);

add the import:
import org.eclipse.emfforms.spi.swt.treemasterdetail.TreeViewerSWTFactory;
and the dependency.

check the bundles ... it requires first the treemasterdetail.
add that, check bundles again, then it requires:
treemasterdetail.model and org.eclipse.emf.edit.ui
add those, check bundles again, then it requires:
emf.common.ui, eclipse.ui.views, eclipse.ui.workbench

At this point, I'm assuming this wasn't tested for RAP, and bail.

I could use something like this, though , since the RAP view render doesn't support selection listeners on the tree.

[Updated on: Thu, 24 November 2016 14:19] by Moderator

Re: [EMFFORMS] TreeViewerSWTFactory and RAP [message #1748603 is a reply to message #1748586]

Fri, 25 November 2016 03:07

Eclipse User

Hi Jay,

maybe you add those dependencies and try, if it works, or more precisely what doesn't work. Otherwise, you could consider sponsoring a compatibility check. Are you interested in that?

Best regards
Jonas

Re: [EMFFORMS] TreeViewerSTWFactory and RAP [message #1748729 is a reply to message #1748603]

Mon, 28 November 2016 00:25

Eclipse User

I think it is probably a lost cause trying to use that particular org.eclipse.emfforms.spi.swt.treemasterdetail.TreeViewerSWTFactory bundle in RAP. I believe I ran into the same problem earlier when trying to use the treemasterdetail viewer code from that same bundle. In that case, I was able to solve the problem by instead using treemasterdetail code from the org.eclipse.emf.ecp.view.treemasterdetail.* bundles, without it leading to all the extra imports. However, in this case I haven't seen anything to indicate that there is TreeViewerSTWFactory code available from elsewhere.

It doesn't seem reasonable to me to have to import all that extra eclipse ui and workbench code just to get a simple emf tree view with access to a selection listener. I'm guessing this is the reason there are dual sources for the treemasterdetail code.

Re: [EMFFORMS] TreeViewerSTWFactory and RAP [message #1748840 is a reply to message #1748729]

Tue, 29 November 2016 04:15

Eclipse User

Hi Jay,
So the main problem here is the dependency to emf.edit.ui as a bundle.
Could you please open a bug for this.

Thank you and cheers,
Eugen

Re: [EMFFORMS] TreeViewerSTWFactory and RAP [message #1749184 is a reply to message #1748840]

Fri, 02 December 2016 14:16

Eclipse User

Ok, thanks. I opened this bug report:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=508620

Re: [EMFFORMS] TreeViewerSTWFactory and RAP [message #1749285 is a reply to message #1749184]

Mon, 05 December 2016 03:34

Eclipse User

Thank you