Eclipse Community Forums: JFace » [HiDPI icons] How to migrate from ImageDescriptor#createFromFile to #createFromURL?

Home » Eclipse Projects » JFace » [HiDPI icons] How to migrate from ImageDescriptor#createFromFile to #createFromURL?

Show: Today's Messages :: Show Polls :: Message Navigator

[HiDPI icons] How to migrate from ImageDescriptor#createFromFile to #createFromURL? [message #1740762]

Thu, 18 August 2016 10:41

Andreas Sewe

Messages: 111
Registered: June 2013

Senior Member

Hi,

I want to make use of the HiDPI icon support added in Neon. Now, my code creates ImageDescriptors using ImageDescriptor#createFromFile(Class, URL) rather than ImageDescriptor#createFromURL(URL). Unfortunately, the former method does not search for available HiDPI icons; only the latter does (as documented in the Neon release notes).

Hence, I have to migrate from createFromFile(Class, URL) to createFromURL(URL), but am at a loss as to how to convert my Class + URL to an absolute URL of the form bundleentry://.../path apprently required by ImageDescriptor#createFromURL(URL).

Any pointers on how to do this migration are hence greatly appreciated.

Andreas

Report message to a moderator

Re: [HiDPI icons] How to migrate from ImageDescriptor#createFromFile to #createFromURL? [message #1740766 is a reply to message #1740762]

Thu, 18 August 2016 11:27

Andreas Sewe

Messages: 111
Registered: June 2013

Senior Member

Made some progress using org.osgi.framework.FrameworkUtil#getBundle(Class) and org.eclipse.ui.internal.util.BundleUtility#find(Bundle, String). The latter is unfortunately marked as internal. If someone has an idea how to avoid BundleUtility, I'd like to hear it.

Report message to a moderator

Re: [HiDPI icons] How to migrate from ImageDescriptor#createFromFile to #createFromURL? [message #1740777 is a reply to message #1740762]

Thu, 18 August 2016 13:26

Brian de Alwis

Messages: 865
Registered: January 2012

Senior Member

I think you must mean ImageDescriptor.createFromFile(Class, String), not URL.

If your class a.b.c.C is in bundle B, and the image name is F, then use:

platform:/plugin/B/a/b/c/F

That's assuming your bundle follows the normal layout, where the classes are laid out from the root of the bundle.

Brian.

Eclipse Platform committer. Ask me about Eclipse support, training, and consulting.

Report message to a moderator

Re: [HiDPI icons] How to migrate from ImageDescriptor#createFromFile to #createFromURL? [message #1740778 is a reply to message #1740777]

Thu, 18 August 2016 13:39

Andreas Sewe

Messages: 111
Registered: June 2013

Senior Member

Brian de Alwis wrote on Thu, 18 August 2016 09:26

I think you must mean ImageDescriptor.createFromFile(Class, String), not URL.

Right. That was a copy-and-paste error.

Quote:

If your class a.b.c.C is in bundle B, and the image name is F, then use:
platform:/plugin/B/a/b/c/F
That's assuming your bundle follows the normal layout, where the classes are laid out from the root of the bundle.

I was hoping to avoid hard-coding the bundle name (in addition to the path); createFromFile's use of Class instances is very convenient in this respect.

But you are right: platform:/ URIs work, although they are less convenient than using createFromFile.

FWIW, is there any reason why createFromFile doesn't search for @2x images? That ImageDescriptor#createFromURL is the only method that got HiDPI-enabled with Neon seems like an oversight to me.

Report message to a moderator

Re: [HiDPI icons] How to migrate from ImageDescriptor#createFromFile to #createFromURL? [message #1740816 is a reply to message #1740778]

Thu, 18 August 2016 17:05

Brian de Alwis

Messages: 865
Registered: January 2012

Senior Member

I don't know why createFromFile() was not updated. Patches welcome, of course Smile

Eclipse Platform committer. Ask me about Eclipse support, training, and consulting.

Report message to a moderator

Re: [HiDPI icons] How to migrate from ImageDescriptor#createFromFile to #createFromURL? [message #1740858 is a reply to message #1740816]

Fri, 19 August 2016 07:29

Andreas Sewe

Messages: 111
Registered: June 2013

Senior Member

Brian de Alwis wrote on Thu, 18 August 2016 13:05

I don't know why createFromFile() was not updated. Patches welcome, of course

Of course. Not sure whether I'm familiar enough with the ImageDescriptor code to do this, though.

But I've filled Bug 499964 at least, so this issue doesn't get lost.

Report message to a moderator

Previous Topic:	[Databinding/E4] Binding of nested properties
Next Topic:	Add Scroller to a long JFace MenuManager

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat Dec 07 01:11:04 GMT 2019

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter