Eclipse Community Forums: Linux Tools Project » GCov plugin handling of linked resources and binutilites

Help

Home

Home » Eclipse Projects » Linux Tools Project » GCov plugin handling of linked resources and binutilites

Show: Today's Messages :: Show Polls :: Message Navigator

GCov plugin handling of linked resources and binutilites [message #1732900]

Sun, 22 May 2016 13:30

Eugene K

Messages: 11
Registered: February 2010

Junior Member

Hello,

I've been using GCov plugin since Juno on Windows platform and each time I had to patch linked resource handling and handling of binutilies.

Linked Resources:
All path resolutions are done using org.eclipse.core.resources.IWorkspaceRoot.getFileForLocation() which does not work on linked resources.

Binutilites:
Assumption is made that tools are on the path and are the same for all projects. This is not always the case. Each project might point to its own tools and requires local resolution. Binutilities extension helps but there is still code which makes indirect assumptions about tools e.g. CovManager should be always aware of the IProject.

I have the patch for these issues but not sure how and whom to contact as it is MS Windows port rather than Linux. The patch is based on the Git master.

Regards,
Eugene

Report message to a moderator

Re: GCov plugin handling of linked resources and binutilites [message #1732911 is a reply to message #1732900]

Mon, 23 May 2016 00:39

Jeff Johnston

Messages: 206
Registered: July 2009

Senior Member

Hi Eugene, do you have a CLA? If you do, open a bug against 4.2.2 gcov and submit a patch to gerrit with the bug number referenced in first line of commit log. e.g. Bug 40234 - fix gcov for linked resources

That said, I have made a few fixes recently that fix linked resources and no additional scenarios have been added. For the bug, you need to specify a scenario that is currently failing for you to help verify your change works and is needed. Time is of the essence as we are heading to Neon RC2 on Tuesday and Monday is a holiday here in Canada. There is a high probability this will have to wait until the Neon.1 update in the fall, but if the code changes are simple, then there is a chance.

Report message to a moderator

Re: GCov plugin handling of linked resources and binutilites [message #1732971 is a reply to message #1732911]

Mon, 23 May 2016 06:33

Eugene K

Messages: 11
Registered: February 2010

Junior Member

Hi Jeff,

I have entered https://bugs.eclipse.org/bugs/show_bug.cgi?id=494296 and attached patch file.

Please keep in mind that these are the changes which worked for me and my projects. All projects I use are based on linked resources including binaries.

Eugene

Report message to a moderator

Previous Topic:	Linux Tools 4.2.1 is released
Next Topic:	Building linuxtools

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Wed Sep 26 10:27:20 GMT 2018

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter