Eclipse Community Forums: Oomph » Targlet with Feature Patch

Help

Home

Home » Eclipse Projects » Oomph » Targlet with Feature Patch

Show: Today's Messages :: Show Polls :: Message Navigator

Targlet with Feature Patch [message #1728751]

Thu, 07 April 2016 05:37

Tobias Pongs

Messages: 9
Registered: July 2015

Junior Member

Hi,

in my setup file, I have defined the following targlet:

    <setupTask
        xsi:type="setup.targlets:TargletTask">
      <targlet
          name="MyTarglet"
          includeAllPlatforms="true">
        <requirement
            name="org.example.feature.feature.group"/>
        <requirement
            name="org.eclipse.e4.rcp.feature.group"
            versionRange="[1.4.1,1.4.2)"/>
        <repositoryList>
          <repository
              url="http://download.eclipse.org/releases/mars"/>
          <repository
              url="file:///D:/updatesites/EclipsePatches"/>
        </repositoryList>
      </targlet>
    </setupTask>

The "org.example.feature.feature.group" contains a feature patch, which patches the "org.eclipse.osgi" plugin.

If the includeAllPlatforms="false" is set, then I see my patched plugin in the target platform. But if includeAllPatforms is set to "true", then the original plugin is installed.

What is the cause for this behavior?

Best regards
Tobias

Here the Feature:

<feature id="org.example.feature" label="Feature" version="1.0.0.qualifier">
   <includes id="org.example.patch" version="0.0.0"/>
</feature>

Here the Patch:

<feature id="org.example.patch" label="Patch" version="1.0.0">
   <requires>
      <import feature="org.eclipse.e4.rcp" version="1.4.1.v20160212-1350" patch="true"/>
   </requires>
   <plugin id="org.eclipse.osgi" version="0.0.0" unpack="false"/>
</feature>

Report message to a moderator

Re: Targlet with Feature Patch [message #1728754 is a reply to message #1728751]

Thu, 07 April 2016 06:06

Ed Merks

Messages: 33142
Registered: July 2009

Senior Member

Tobias,

I'm not sure what would cause this.

The only thing that jumps to mind is that in the case of
includeAllPlatforms, we "mangle" the metadata of the IUs to remove the
filters that would otherwise prevent the installation of IUs. Somehow
that must be involved...

We could look at how to fix such a problem, but would need a
reproducible scenario to see the original problem and to be sure that
any changes we need to make fix that problem.

This Bugzilla is a good example of how such a problem report could be
authored.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=490985

I.e., it provides an update site in the form of a zipped/jarred
repository and a setup that will use this repository. In your case it
would need to be a project setup, not a product setup, and should
include your targlet task...

On 07.04.2016 07:38, Tobias Pongs wrote:
> Hi,
>
> in my setup file, I have defined the following targlet:
>
> <setupTask
> xsi:type="setup.targlets:TargletTask">
> <targlet
> name="MyTarglet"
> includeAllPlatforms="true">
> <requirement
> name="org.example.feature.feature.group"/>
> <requirement
> name="org.eclipse.e4.rcp.feature.group"
> versionRange="[1.4.1,1.4.2)"/>
> <repositoryList>
> <repository
> url="http://download.eclipse.org/releases/mars"/>
> <repository
> url="file:///D:/updatesites/EclipsePatches"/>
> </repositoryList>
> </targlet>
> </setupTask>
>
>
> The "org.example.feature.feature.group" contains a feature patch,
> which patches the "org.eclipse.osgi" plugin.
>
> If the includeAllPlatforms="false" is set, then I see my patched
> plugin in the target platform. But if includeAllPatforms is set to
> "true", then the original plugin is installed.
>
> What is the cause for this behavior?
>
> Best regards
> Tobias
>
> Here the Feature:
>
> <feature id="org.example.feature" label="Feature"
> version="1.0.0.qualifier">
> <includes id="org.example.patch" version="0.0.0"/>
> </feature>
>
> Here the Patch:
>
> <feature id="org.example.patch" label="Patch" version="1.0.0">
> <requires>
> <import feature="org.eclipse.e4.rcp"
> version="1.4.1.v20160212-1350" patch="true"/>
> </requires>
> <plugin id="org.eclipse.osgi" version="0.0.0" unpack="false"/>
> </feature>
>
>

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator