Eclipse Community Forums: Eclipse Scout » Undefined texts: "ui.browser*"

Help

Home

Home » Eclipse Projects » Eclipse Scout » Undefined texts: "ui.browser*"

Show: Today's Messages :: Show Polls :: Message Navigator

Undefined texts: "ui.browser*" [message #1726418]

Sun, 13 March 2016 10:49

Jeremie Bresson

Messages: 1252
Registered: October 2011

Senior Member

I got this message from "Rene Eigenheer":

Quote:

Step to reproduce:
* Create a new Scout Project in Eclipse IDE
* Start the Server
* Start the UI
* Visit http://localhost:8082 with an old browser

The file corresponding to this page is:

/{your-app}.ui.html/src/main/resources/WebContent/unsupported-browser.html

By default the content is:

<scout:message key="ui.browserTooOld" />

<ul>
  <li><scout:message key="ui.browserChrome" /></li>
  <li><scout:message key="ui.browserFirefox" /></li>
  <li><scout:message key="ui.browserInternetExplorer" /></li>
</ul>

<div class="button-bar">
  <button class="button"><scout:message key="ui.ContinueAnyway" /></button>
</div>

I am not sure what the problem is. The texts files are present in the "org.eclipse.scout.rt.ui.html-5.2.0.M5.jar":
* /org/eclipse/scout/rt/ui/html/texts/Texts.properties
* /org/eclipse/scout/rt/ui/html/texts/Texts_de.properties

See the corresponding texts folder in the Git Repository.

There is also a class "UiTextProviderService" linking those properties file...
Very strange for me: the Text in the Button seems to work...

Attachment: undefined_texts.gif
(Size: 4.90KB, Downloaded 471 times)

Report message to a moderator

Re: Undefined texts: "ui.browser*" [message #1727160 is a reply to message #1726418]

Sun, 20 March 2016 13:05

Rene Eigenheer

Messages: 109
Registered: July 2009

Senior Member

Hi Jeremie

I debugged and remarked the following mistake:

In the unsupported-browser.html the key ui.browserChrome uses a lowercase b for browser whereas in properties files there is a uppercase B -> ui.BrowserChrome=Google Chrome.

Which one fits the naming standards ? Wink

-Rene

Report message to a moderator

Re: Undefined texts: "ui.browser*" [message #1727163 is a reply to message #1727160]

Sun, 20 March 2016 16:42

Jeremie Bresson

Messages: 1252
Registered: October 2011

Senior Member

By looking at the Texts.properties in the "scout.rt.ui.html" project, I am not sure if there is a naming convention at all...

My guess is that the html file should be changed to:

<scout:message key="ui.BrowserTooOld" />

<ul>
  <li><scout:message key="ui.BrowserChrome" /></li>
  <li><scout:message key="ui.BrowserFirefox" /></li>
  <li><scout:message key="ui.BrowserInternetExplorer" /></li>
</ul>

<div class="button-bar">
  <button class="button"><scout:message key="ui.ContinueAnyway" /></button>
</div>

I could verify the fix by opening this page in my browser:

http://localhost:8082/unsupported-browser.html

Can you contribute a fix for the corresponding file? It is the file unsupported-browser.html in the SDK Repository.

M6 will be built in the next days, can you do it quickly (or do you prefer that someone from our team fix it for you)?

[Updated on: Sun, 20 March 2016 16:49]

Report message to a moderator

Re: Undefined texts: "ui.browser*" [message #1727183 is a reply to message #1727163]

Mon, 21 March 2016 06:24

Jeremie Bresson

Messages: 1252
Registered: October 2011

Senior Member

Jeremie Bresson wrote on Sun, 20 March 2016 17:42

M6 will be built in the next days, can you do it quickly (or do you prefer that someone from our team fix it for you)?

We are building M6 today! I have made the change:

http://git.eclipse.org/c/scout/org.eclipse.scout.sdk.git/commit/?h=releases/5.2.x&id=ce1c046a1844a88e6cb62bc16e3f80e52066d142

Thank you for your analysis! And for sharing it here... Your help is appreciated!

Report message to a moderator

Re: Undefined texts: "ui.browser*" [message #1727190 is a reply to message #1727183]

Mon, 21 March 2016 08:02

Rene Eigenheer

Messages: 109
Registered: July 2009

Senior Member

Thank you Jeremie
I just started reading the contribution process https://wiki.eclipse.org/Scout/Contribution#Neon Wink

For the next time: would Branch: releases/5.2.x still be correct ?

BTW: Is there a what's new in M6 page? I'm curious whether something related to mobile support was added Wink

Report message to a moderator

Re: Undefined texts: "ui.browser*" [message #1727329 is a reply to message #1727190]

Tue, 22 March 2016 08:21

Jeremie Bresson

Messages: 1252
Registered: October 2011

Senior Member

About the branches:
* releases/5.2.x is a branch for pre-neon releases: Neon.M5 and previous were built from this branch. We continue to build internal release from this branch.
* releases/6.0.x is a branch for the neon release (and some of the Milestone releases before newon). Neon.M6 this week will be built from the 6.0-Branch and will be our first beta-release having a version number 6.0.*.****. This branch is the Branch for official Scout Release.

For the moment (Mars 2016):
* We still do a lot of development on the 5.2.x Branch (bug fixes, documentation improvements, SDK work) and our release engineer merge the changes from the 5.2.x branch to 6.0.x...
* Some changes in Scout RT that break the API are only made on the 6.0.x Branch.
* We try to keep 5.2.x and 6.0.x as close as possible

This is why I made the change on the 5.2.x Branch.

------------

I think we do not have release notes "per Milestone Release" as we did in the past. I think that the framework is evolving to fast to do something like that. I do not know the status of the mobile support with M6.
I think that Matthias Zimmerman will be able to tell what is new with this release (I think he will publish a blog post).

Report message to a moderator

Previous Topic:	[neon] ClientNotification
Next Topic:	[neon] Desktop.setStatusText()

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat May 04 21:42:25 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter