Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Sirius » Resource reloading
Resource reloading [message #1723830] Thu, 18 February 2016 10:07 Go to next message
Adam Lengyel is currently offline Adam LengyelFriend
Messages: 8
Registered: October 2014
Junior Member
Hi,

I ran into something strange while I browse the sources of Sirius...

In the org.eclipse.sirius.common plugin org.eclipse.sirius.common.tools.internal.resource/EditingSessionWorkspaceListener class has a resourceChanged(...) method, where you instantiate a ResourceSyncClientNotifier instance and call the run(...) method on it.

Is this intentional? Because In this case the Job won't be scheduled and the SchedulingRule which is implemented inside the ResourceSyncClientNotifier class will be ignored too. Don't you think you should call schedule() instead?

Thank you for your help!

Adam

Re: Resource reloading [message #1723895 is a reply to message #1723830] Thu, 18 February 2016 21:28 Go to previous messageGo to next message
Felix Dorner is currently offline Felix DornerFriend
Messages: 372
Registered: December 2015
Senior Member
On 18-Feb-16 11:07, Adam Lengyel wrote:
> Hi,
>
> I ran into something strange while I browse the sources of Sirius...
>
> In the org.eclipse.sirius.common plugin
> org.eclipse.sirius.common.tools.internal.resource/EditingSessionWorkspaceListener
> class has a resourceChanged(...) method, where you instantiate a
> ResourceSyncClientNotifier instance and call the run(...) method on it.
>
> Is this intentional? Because In this case the Job won't be scheduled and
> the SchedulingRule which is implemented inside the
> ResourceSyncClientNotifier class will be ignored too. Don't you think
> you should call schedule() instead?

Maybe you could look at
https://bugs.eclipse.org/bugs/show_bug.cgi?id=470457 and see if your
findings are already documented in any of the related bugs.

Felix
Re: Resource reloading [message #1724543 is a reply to message #1723895] Wed, 24 February 2016 14:03 Go to previous messageGo to next message
Adam Lengyel is currently offline Adam LengyelFriend
Messages: 8
Registered: October 2014
Junior Member
Dear Felix,

Thank you for your help!

I checked the link you sent me, and I didn't find any bugreport which describes the problem I mentioned. Should I send a bugreport about it?

Adam
Re: Resource reloading [message #1725154 is a reply to message #1724543] Tue, 01 March 2016 09:46 Go to previous message
Laurent Fasani is currently offline Laurent FasaniFriend
Messages: 174
Registered: October 2014
Senior Member
Hello Adam,

This code as been modified through the bug 447042.
ResourceSyncClientNotifier is not used as Job anymore.
Perhaps the async aspect of some part of sirius will be reworked in
https://bugs.eclipse.org/bugs/show_bug.cgi?id=470457 which you explain
that ResourceSyncClientNotifier as not be changed removing the Job behavior.

Regards
Laurent

Le 24/02/2016 15:03, Adam Lengyel a écrit :
> Dear Felix,
>
> Thank you for your help!
>
> I checked the link you sent me, and I didn't find any bugreport which
> describes the problem I mentioned. Should I send a bugreport about it?
>
> Adam


Laurent Fasani - Obeo
Need training or professional services for Sirius?
http://www.obeodesigner.com/sirius
Previous Topic:Diagram refresh problem
Next Topic:Programmatically Hide Diagram Elements
Goto Forum:
  


Current Time: Sat Jan 23 05:45:51 GMT 2021

Powered by FUDForum. Page generated in 0.02256 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top