Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » e(fx)clipse » DnD doesn't work after updating to efxcipse 2.2.0
DnD doesn't work after updating to efxcipse 2.2.0 [message #1720694] Wed, 20 January 2016 10:21 Go to next message
crothy donald is currently offline crothy donaldFriend
Messages: 31
Registered: September 2013
Member
Hi,

today I found another bug in my application after updating to efxclipse 2.2.0 (after the Min/Max bug from one of my previous posts).

Drag & Drop doesn't work anymore. Please note, it worked with the previous version of efxclipse.

After debuging the application I found out that the DnDService in the DndAddon is null with results in the NPE in org.eclipse.fx.ui.workbench.renderers.base.addons.DnDAddon.dragStartHandler(DnDAddon.java:262)

The service is annotated as @Optional

@Inject
@Optional
DnDService dndService;

but the dragStartHandler doesn't check if the service is initialized so the statement

return Boolean.valueOf(this.dndService.dragAllowed(d.container, d.item));

produce an NPE.

Well, are there more of this side-effects to be feared. Are there any documents to help migrating an efxclipse application from 2.1.0 to 2.2.0

What shall I do with the DnDService. Do I have to add the service as component. Any examples of this?

Greets,
Christian
Re: DnD doesn't work after updating to efxcipse 2.2.0 [message #1720771 is a reply to message #1720694] Wed, 20 January 2016 20:41 Go to previous messageGo to next message
Thomas Schindl is currently offline Thomas SchindlFriend
Messages: 6313
Registered: July 2009
Senior Member
Hi,

On 20.01.16 11:21, crothy donald wrote:
> Hi,
>
> today I found another bug in my application after updating to efxclipse
> 2.2.0 (after the Min/Max bug from one of my previous posts).
>
> Drag & Drop doesn't work anymore. Please note, it worked with the
> previous version of efxclipse.
> After debuging the application I found out that the DnDService in the
> DndAddon is null with results in the NPE in
> org.eclipse.fx.ui.workbench.renderers.base.addons.DnDAddon.dragStartHandler(DnDAddon.java:262)
>
>
> The service is annotated as @Optional
>
> @Inject
> @Optional
> DnDService dndService;
>
> but the dragStartHandler doesn't check if the service is initialized so
> the statement
>
> return Boolean.valueOf(this.dndService.dragAllowed(d.container, d.item));
>

File a bug!

> produce an NPE.
>
> Well, are there more of this side-effects to be feared. Are there any
> documents to help migrating an efxclipse application from 2.1.0 to 2.2.0
>

I hope not, the applications i used for testing had DnDService in it so
it has not been discovered. What strikes me is that the eclipse static
code analysis should show an error there.

We always ask people to test their application with the nightly builds
so that we could catch those errors before releasing.


> What shall I do with the DnDService. Do I have to add the service as
> component. Any examples of this?


If you have the ds-annotation processor installed it's nothing more than

@Component
class MyDnDDummy implements DnDService {
// return true for all methods
}

somewhere in your code

Tom
Re: DnD doesn't work after updating to efxcipse 2.2.0 [message #1720772 is a reply to message #1720771] Wed, 20 January 2016 20:53 Go to previous messageGo to next message
Thomas Schindl is currently offline Thomas SchindlFriend
Messages: 6313
Registered: July 2009
Senior Member
Filed myself and fixed https://bugs.eclipse.org/bugs/show_bug.cgi?id=486200

Tom

On 20.01.16 21:41, Tom Schindl wrote:
> Hi,
>
> On 20.01.16 11:21, crothy donald wrote:
>> Hi,
>>
>> today I found another bug in my application after updating to efxclipse
>> 2.2.0 (after the Min/Max bug from one of my previous posts).
>>
>> Drag & Drop doesn't work anymore. Please note, it worked with the
>> previous version of efxclipse.
>> After debuging the application I found out that the DnDService in the
>> DndAddon is null with results in the NPE in
>> org.eclipse.fx.ui.workbench.renderers.base.addons.DnDAddon.dragStartHandler(DnDAddon.java:262)
>>
>>
>> The service is annotated as @Optional
>>
>> @Inject
>> @Optional
>> DnDService dndService;
>>
>> but the dragStartHandler doesn't check if the service is initialized so
>> the statement
>>
>> return Boolean.valueOf(this.dndService.dragAllowed(d.container, d.item));
>>
>
> File a bug!
>
>> produce an NPE.
>>
>> Well, are there more of this side-effects to be feared. Are there any
>> documents to help migrating an efxclipse application from 2.1.0 to 2.2.0
>>
>
> I hope not, the applications i used for testing had DnDService in it so
> it has not been discovered. What strikes me is that the eclipse static
> code analysis should show an error there.
>
> We always ask people to test their application with the nightly builds
> so that we could catch those errors before releasing.
>
>
>> What shall I do with the DnDService. Do I have to add the service as
>> component. Any examples of this?
>
>
> If you have the ds-annotation processor installed it's nothing more than
>
> @Component
> class MyDnDDummy implements DnDService {
> // return true for all methods
> }
>
> somewhere in your code
>
> Tom
>
Re: DnD doesn't work after updating to efxcipse 2.2.0 [message #1720774 is a reply to message #1720694] Wed, 20 January 2016 21:28 Go to previous messageGo to next message
Thomas Schindl is currently offline Thomas SchindlFriend
Messages: 6313
Registered: July 2009
Senior Member
[...]

> Well, are there more of this side-effects to be feared. Are there any
> documents to help migrating an efxclipse application from 2.1.0 to 2.2.0
>

There are not migration documents because ideally those bugs would have
been found before the release 2.2.0 should 100% compatible (for stuff we
have declared as API!) with 2.1.0.

Let me repeat that we really need your help in testing nightlies!

We do the testing with our customers applications but there might be
combintations we are not testing.

To give you an example:
- the min/max problem has not been encountered because the application
we added this feature for consumes the double clicks themselves
because the Tab-Area is filled with our editor, all other
applications don't enable min/max

- although many people publicly requested the dnd stuff, most of our
customers don't require that in their apps and if they do they
control what can be dragged tightly pushing a DnDService instance
hence once more we did not detect this bug

- Unfortunately we are NOT allowed to use TestFX at Eclipse.org
(licensing problems) so we can not run automated tests. I've been
thinking about this and I think we need to push forward a custom
implementation

So unless you want to dedicate in writing an UI-TestFramework and
contribute all adopters could at least test their apps before the final
release.

Tom
Re: DnD doesn't work after updating to efxcipse 2.2.0 [message #1720776 is a reply to message #1720774] Wed, 20 January 2016 22:16 Go to previous messageGo to next message
Thomas Schindl is currently offline Thomas SchindlFriend
Messages: 6313
Registered: July 2009
Senior Member
last reply - as embarrassing as those 2 problems are (they really should
not have been unnoticed), you can always sign a support contract with
BestSolution.at and we'll provide you with 2.2.1 builds/releases ;-)

Tom


On 20.01.16 22:28, Tom Schindl wrote:
> [...]
>
>> Well, are there more of this side-effects to be feared. Are there any
>> documents to help migrating an efxclipse application from 2.1.0 to 2.2.0
>>
>
> There are not migration documents because ideally those bugs would have
> been found before the release 2.2.0 should 100% compatible (for stuff we
> have declared as API!) with 2.1.0.
>
> Let me repeat that we really need your help in testing nightlies!
>
> We do the testing with our customers applications but there might be
> combintations we are not testing.
>
> To give you an example:
> - the min/max problem has not been encountered because the application
> we added this feature for consumes the double clicks themselves
> because the Tab-Area is filled with our editor, all other
> applications don't enable min/max
>
> - although many people publicly requested the dnd stuff, most of our
> customers don't require that in their apps and if they do they
> control what can be dragged tightly pushing a DnDService instance
> hence once more we did not detect this bug
>
> - Unfortunately we are NOT allowed to use TestFX at Eclipse.org
> (licensing problems) so we can not run automated tests. I've been
> thinking about this and I think we need to push forward a custom
> implementation
>
> So unless you want to dedicate in writing an UI-TestFramework and
> contribute all adopters could at least test their apps before the final
> release.
>
> Tom
>
Re: DnD doesn't work after updating to efxcipse 2.2.0 [message #1720806 is a reply to message #1720776] Thu, 21 January 2016 08:03 Go to previous messageGo to next message
crothy donald is currently offline crothy donaldFriend
Messages: 31
Registered: September 2013
Member
Hi,

thanks again for the quick reply.
I agree with you. It is exactly what I am doing right know: as adopter I test my application with the new release of efxclipse, no complain at all.
I promise myself to setup an eclipse user account in order to contribute to efxclipse. Hopefully, help is still needed...

Btw, I tested my application with the nightlies and both Min/Max and Dnd works o.k. Just a last question: Where can I found the fx.code.editors & fx.text bundles? They are not in http://download.eclipse.org/efxclipse/runtime-nightly/site repo.

Christian


Re: DnD doesn't work after updating to efxcipse 2.2.0 [message #1720807 is a reply to message #1720806] Thu, 21 January 2016 08:06 Go to previous message
Thomas Schindl is currently offline Thomas SchindlFriend
Messages: 6313
Registered: July 2009
Senior Member
They are there if you use the "Code editing target platform"

Tom

On 21.01.16 09:03, crothy donald wrote:
> Hi,
>
> thanks again for the quick reply. I agree with you. It is exactly what I
> am doing right know: as adopter I test my application with the new
> release of efxclipse, no complain at all.
> I promise myself to setup an eclipse user account in order to contribute
> to efxclipse. Hopefully, help is still needed...
>
> Btw, I tested my application with the nightlies and both Min/Max and Dnd
> works o.k. Just a last question: Where can I found the fx.code.editors
> & fx.text bundles? They are not in
> http://download.eclipse.org/efxclipse/runtime-nightly/site repo.
>
> Christian
>
>
Previous Topic:Native launcher artifacts for efxclipse application
Next Topic:Native launcher for windows build (maven-tycho + ant) is not working for e4 OSGI application
Goto Forum:
  


Current Time: Thu May 25 05:10:11 GMT 2017

Powered by FUDForum. Page generated in 0.03484 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software