|
|
|
|
|
|
Re: minimize/maximize of parts and stacks [message #1714538 is a reply to message #1703967] |
Fri, 13 November 2015 13:12 |
Sun Volland Messages: 29 Registered: September 2010 |
Junior Member |
|
|
Hi,
I started implementing a maximization service that can maximize/unmaximize an element into a perspective, following Tom's initial idea.
Here is a small video showing the result, where maximization is triggered by buttons or a key-binding - sorry for the poor quality.
Basically changes are limited to the org.eclipse.fx.ui.workbench.renderers.base and org.eclipse.fx.ui.workbench.renderers.fx bundles, where 3 new interfaces were introduced :
- org.eclipse.fx.ui.workbench.renderers.base.services.MaximizationService, providing the actual maximization api. There's one instance per perspective, built by a context function.
- org.eclipse.fx.ui.workbench.renderers.base.services.MaximizationTransitionService, responsible for the maximization/unmaximization animation. Current implementation does the growing/shrinking animation, but any other impl. can be provided as an OSGi service
- org.eclipse.fx.ui.workbench.renderers.base.widget.WMaximizationHost, a widget abstraction for widgets supporting a maximized content actually implemented by WPerspective
The maximization state is stored as persisted data in the model, so it is restored when restarting the app.
Branch of modified efxclipse is at https://github.com/svolland/efxclipse
Demo project is at https://github.com/svolland/e4fx_demo (running against the above branch + 2.1.0 target)
It's basically functionnal but surely needs more work/review to properly handle all cases, and an ui max/unmax control could be nice too.
Sun
|
|
|
Re: minimize/maximize of parts and stacks [message #1714545 is a reply to message #1714538] |
Fri, 13 November 2015 13:34 |
Thomas Schindl Messages: 6651 Registered: July 2009 |
Senior Member |
|
|
Hi,
This is wonderful!
I talked with Christoph Keimel at EclipseCon Europe last week and your
approach is exactly what I and Christoph agreed to give a try.
Unfortunately the github repo is empty so I don't see how you
implemented it but I expect you reparent the widget-node and keep the
static node at it position?
Tom
On 13.11.15 14:12, Sun Volland wrote:
> Hi,
>
> I started implementing a maximization service that can
> maximize/unmaximize an element into a perspective, following Tom's
> initial idea.
>
> Here is a small https://youtu.be/1xBzZfAZbLg showing the result, where
> maximization is triggered by buttons or a key-binding - sorry for the
> poor quality.
>
> Basically changes are limited to the
> org.eclipse.fx.ui.workbench.renderers.base and
> org.eclipse.fx.ui.workbench.renderers.fx bundles, where 3 new interfaces
> were introduced :
>
>
> org.eclipse.fx.ui.workbench.renderers.base.services.MaximizationService,
> providing the actual maximization api. There's one instance per
> perspective, built by a context function.
> org.eclipse.fx.ui.workbench.renderers.base.services.MaximizationTransitionService,
> responsible for the maximization/unmaximization animation. Current
> implementation does the growing/shrinking animation, but any other impl.
> can be provided as an OSGi service
> org.eclipse.fx.ui.workbench.renderers.base.widget.WMaximizationHost, a
> widget abstraction for widgets supporting a maximized content actually
> implemented by WPerspective
>
>
> The maximization state is stored as persisted data in the model, so it
> is restored when restarting the app.
> Branch of modified efxclipse is at https://github.com/svolland/efxclipse
> Demo project is at https://github.com/svolland/e4fx_demo (running
> against the above branch + 2.1.0 target)
>
> It's basically functionnal but surely needs more work/review to properly
> handle all cases, and an ui max/unmax control could be nice too.
>
> Sun
>
|
|
|
Re: minimize/maximize of parts and stacks [message #1714548 is a reply to message #1714545] |
Fri, 13 November 2015 13:36 |
Thomas Schindl Messages: 6651 Registered: July 2009 |
Senior Member |
|
|
If you plan to contribute this - it would be nice if you would create a
gerrit-review.
I'd even merge the current version (even if not perfect yet) because it
is better than nothing.
Tom
On 13.11.15 14:34, Tom Schindl wrote:
> Hi,
>
> This is wonderful!
>
> I talked with Christoph Keimel at EclipseCon Europe last week and your
> approach is exactly what I and Christoph agreed to give a try.
>
> Unfortunately the github repo is empty so I don't see how you
> implemented it but I expect you reparent the widget-node and keep the
> static node at it position?
>
> Tom
>
> On 13.11.15 14:12, Sun Volland wrote:
>> Hi,
>>
>> I started implementing a maximization service that can
>> maximize/unmaximize an element into a perspective, following Tom's
>> initial idea.
>>
>> Here is a small https://youtu.be/1xBzZfAZbLg showing the result, where
>> maximization is triggered by buttons or a key-binding - sorry for the
>> poor quality.
>>
>> Basically changes are limited to the
>> org.eclipse.fx.ui.workbench.renderers.base and
>> org.eclipse.fx.ui.workbench.renderers.fx bundles, where 3 new interfaces
>> were introduced :
>>
>>
>> org.eclipse.fx.ui.workbench.renderers.base.services.MaximizationService,
>> providing the actual maximization api. There's one instance per
>> perspective, built by a context function.
>> org.eclipse.fx.ui.workbench.renderers.base.services.MaximizationTransitionService,
>> responsible for the maximization/unmaximization animation. Current
>> implementation does the growing/shrinking animation, but any other impl.
>> can be provided as an OSGi service
>> org.eclipse.fx.ui.workbench.renderers.base.widget.WMaximizationHost, a
>> widget abstraction for widgets supporting a maximized content actually
>> implemented by WPerspective
>>
>>
>> The maximization state is stored as persisted data in the model, so it
>> is restored when restarting the app.
>> Branch of modified efxclipse is at https://github.com/svolland/efxclipse
>> Demo project is at https://github.com/svolland/e4fx_demo (running
>> against the above branch + 2.1.0 target)
>>
>> It's basically functionnal but surely needs more work/review to properly
>> handle all cases, and an ui max/unmax control could be nice too.
>>
>> Sun
>>
>
|
|
|
|
|
|
Powered by
FUDForum. Page generated in 0.05037 seconds