Eclipse Community Forums: TMF (Xtext) » Formatter2: how to correctly format a block (indentation)

Help

Home

Home » Modeling » TMF (Xtext) » Formatter2: how to correctly format a block (indentation)

Show: Today's Messages :: Show Polls :: Message Navigator

Formatter2: how to correctly format a block (indentation) [message #1693828]

Tue, 28 April 2015 14:58

Markus Duft

Messages: 30
Registered: March 2015

Member

Hey,

I'm trying to format something like this:

enumeration Enum1 {
	
	
			/** documentation */
		literal A;
	
	/** documentation */
literal B;
	
		literal C;
	
}

my formatter2 based formatting code looks like this:

	def dispatch void format(Enumeration enumeration, extension IFormattableDocument document) {
		enumeration.regionForKeyword("{").append[newLine; increaseIndentation]
		for (EnumerationLiteral literals : enumeration.getLiterals()) {
			format(literals, document);
		}
		enumeration.regionForKeyword("}").prepend[newLine; decreaseIndentation].append[newLine]
	}

the format(EnumerationLiteral) method does /not/ exist - it seems that the formatter2 fragment only generates methods for things that contain other elements - which the literals do not. Is it a problem that this method is not there? The default is an empty method enyhow, and actually I don't (currently) want to format the literal itself.

When run, the above code produces this:

enumeration Enum1 {
	/** documentation */
	literal A;
	
	/** documentation */
literal B;
	
		literal C;
}

which is close, but not quite there Wink

Whey is the indentation of the first comment and literal corrected, but the other literals stay where they are?

Any hints appreciated!

P.S.: good thing is that the first comment is formatted correctly, which was not possible with the old formatting API.

Report message to a moderator

Re: Formatter2: how to correctly format a block (indentation) [message #1693852 is a reply to message #1693828]

Tue, 28 April 2015 18:26

Christian Dietrich

Messages: 13876
Registered: July 2009

Senior Member

looks like a bug to me (not generating the method)

but adding it and formatting the newline does the

def dispatch void format(EnumerationLiteral l, extension IFormattableDocument document) {
		l.prepend[newLine]
	}

Need professional support for Xtext, Xpand, EMF?
Go to: https://www.itemis.com/en/it-services/methods-and-tools/xtext
Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

[Updated on: Tue, 28 April 2015 18:27]

Report message to a moderator

Re: Formatter2: how to correctly format a block (indentation) [message #1693885 is a reply to message #1693852]

Wed, 29 April 2015 06:58

Markus Duft

Messages: 30
Registered: March 2015

Member

Thanks, that helped Smile

Is there any way to influence the formatting of a ML_COMMENT (or any other hidden object)?

Report message to a moderator

Re: Formatter2: how to correctly format a block (indentation) [message #1694096 is a reply to message #1693885]

Thu, 30 April 2015 14:18

Markus Duft

Messages: 30
Registered: March 2015

Member

ping

Report message to a moderator

Re: Formatter2: how to correctly format a block (indentation) [message #1694111 is a reply to message #1694096]

Thu, 30 April 2015 15:00

Christian Dietrich

Messages: 13876
Registered: July 2009

Senior Member

if i knew the aswer i would have answered

Need professional support for Xtext, Xpand, EMF?
Go to: https://www.itemis.com/en/it-services/methods-and-tools/xtext
Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Previous Topic:	assigned value will possible override itself
Next Topic:	Xtext debugging without Xbase

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat Apr 10 19:25:17 GMT 2021

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter