Home » Eclipse Projects » Eclipse Platform » [PDE] Externalizing Strings dialog and ignore pattern
| [PDE] Externalizing Strings dialog and ignore pattern [message #323986] |
Tue, 15 January 2008 09:27  |
Eclipse User |
|
|
|
Originally posted by: atoulme.intalio.com
Hi all,
when typing //$NON-NLS-1$ to ignore a string, the PDE dialog to help
externalizing does not recognize that pattern when adding a space
between // and $NON-NLS-1$. Is it a bug, or just a limit ?
On the whole, is it possible to have someone type:
System.out.print("Hello"); // blablabla $NON-NLS-1$
If that is not permitted, I'd like to open a request for enhancement to
chase such patterns and mark them as errors, or at least warnings, so
people don't mess up NLS patterns.
Thanks,
Antoine
--
Intalio, the Open Source BPMS Company
<a href="http://www.intalio.com">http://www.intalio.com</a>
<a href="http://bpms.intalio.com">Community website</a>
|
|
| |
| Re: [PDE] Externalizing Strings dialog and ignore pattern [message #324025 is a reply to message #323986] |
Wed, 16 January 2008 12:37  |
| Eclipse User |
|
|
|
Originally posted by: atoulme.intalio.com
It seems I'm better off filing a bug.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=215466
Thanks,
Antoine
Antoine Toulme wrote:
> Hi all,
>
> when typing //$NON-NLS-1$ to ignore a string, the PDE dialog to help
> externalizing does not recognize that pattern when adding a space
> between // and $NON-NLS-1$. Is it a bug, or just a limit ?
>
> On the whole, is it possible to have someone type:
> System.out.print("Hello"); // blablabla $NON-NLS-1$
>
> If that is not permitted, I'd like to open a request for enhancement to
> chase such patterns and mark them as errors, or at least warnings, so
> people don't mess up NLS patterns.
>
>
> Thanks,
>
> Antoine
--
Intalio, the Open Source BPMS Company
<a href="http://www.intalio.com">http://www.intalio.com</a>
<a href="http://bpms.intalio.com">Community website</a>
|
|
|
| Re: [PDE] Externalizing Strings dialog and ignore pattern [message #324714 is a reply to message #324019] |
Wed, 30 January 2008 21:50 |
| Eclipse User |
|
|
|
Originally posted by: atoulme.intalio.com
Daniel Megert wrote:
> Antoine Toulme wrote:
>
>> Hi all,
>>
>> when typing //$NON-NLS-1$ to ignore a string, the PDE dialog to help
>> externalizing does not recognize that pattern when adding a space
>> between // and $NON-NLS-1$. Is it a bug, or just a limit ?
>
> Intended behavior.
>
>>
>> On the whole, is it possible to have someone type:
>> System.out.print("Hello"); // blablabla $NON-NLS-1$
>>
>> If that is not permitted, I'd like to open a request for enhancement
>> to chase such patterns and mark them as errors, or at least warnings,
>> so people don't mess up NLS patterns.
>
> You do get a warning on the string and hence you detect the mistake.
Maybe implementing a quick fix would do good there, then ?
What do you think ?
Cheers,
Antoine
>
> Dani
>
>>
>>
>> Thanks,
>>
>> Antoine
--
Intalio, the Open Source BPMS Company
<a href="http://www.intalio.com">http://www.intalio.com</a>
<a href="http://bpms.intalio.com">Community website</a>
|
|
|
| Re: [PDE] Externalizing Strings dialog and ignore pattern [message #324723 is a reply to message #324714] |
Thu, 31 January 2008 04:41 |
| Eclipse User |
|
|
|
Antoine Toulme wrote:
> Daniel Megert wrote:
>
>> Antoine Toulme wrote:
>>
>>> Hi all,
>>>
>>> when typing //$NON-NLS-1$ to ignore a string, the PDE dialog to help
>>> externalizing does not recognize that pattern when adding a space
>>> between // and $NON-NLS-1$. Is it a bug, or just a limit ?
>>
>>
>> Intended behavior.
>>
>>>
>>> On the whole, is it possible to have someone type:
>>> System.out.print("Hello"); // blablabla $NON-NLS-1$
>>>
>>> If that is not permitted, I'd like to open a request for enhancement
>>> to chase such patterns and mark them as errors, or at least
>>> warnings, so people don't mess up NLS patterns.
>>
>>
>> You do get a warning on the string and hence you detect the mistake.
>
> Maybe implementing a quick fix would do good there, then ?
There's a quick fix to add it but we can't guess that you just missed
the //. What if you wrote $NO-NLS$, or $NO-NL$? Should we offer a quick
fix to remove those? I don't think so.
Dani
>
> What do you think ?
>
> Cheers,
>
> Antoine
>
>>
>> Dani
>>
>>>
>>>
>>> Thanks,
>>>
>>> Antoine
>>
>
>
|
|
|
Goto Forum:
Current Time: Thu Jul 17 23:53:10 EDT 2025
Powered by FUDForum. Page generated in 0.09523 seconds |
Home