| Indexer for multiple languages [message #1672218] |
Fri, 13 March 2015 18:55 |
Eclipse User |
|
|
|
Hello,
I am trying to use the DLTK's indexing system but my project has more than one project's nature. So, I've found one bit of code that just search for the LanguageToolkit based on the project nature.
org.eclipse.dltk.internal.core.search.ProjectIndexerManager.reconciled(ISourceModule) - Line 364
/**
* @param workingCopy
*/
public static void reconciled(ISourceModule workingCopy) {
final IScriptProject project = workingCopy.getScriptProject();
if (project == null) {
return;
}
if (!isIndexerEnabled(project.getProject())) {
return;
}
final IDLTKLanguageToolkit toolkit = DLTKLanguageManager
.getLanguageToolkit(project);
if (toolkit == null) {
return;
}
final IProjectIndexer[] indexers = getIndexers(toolkit.getNatureId());
if (indexers != null) {
for (int i = 0; i < indexers.length; ++i) {
indexers[i].reconciled(workingCopy, toolkit);
}
}
}
Considering that I don´t have a nature with a LanguageToolkit bound, my project is considered closed, so the DLTKLanguageManager don´t return the correct languageToolkit. If the workingCopy were passed as an argument to the LanguageManager the correct Toolkit would be returned as I required.
So my question is: "There is any problem if I make that change and propose a pull request to the DLTK's github? What would be the problems that would cause to the system's architecture"
|
|
|
Powered by
FUDForum. Page generated in 0.06619 seconds
Home