Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Dynamic Languages Toolkit (DLTK) » Indexer for multiple languages(Fix to allow DLTK's indexing system to work with multiple languages)
Indexer for multiple languages [message #1672218] Fri, 13 March 2015 22:55
Eriky Raggeoto Kashivagui is currently offline Eriky Raggeoto KashivaguiFriend
Messages: 7
Registered: October 2014
Junior Member
Hello,
I am trying to use the DLTK's indexing system but my project has more than one project's nature. So, I've found one bit of code that just search for the LanguageToolkit based on the project nature.

org.eclipse.dltk.internal.core.search.ProjectIndexerManager.reconciled(ISourceModule) - Line 364
	/**
	 * @param workingCopy
	 */
	public static void reconciled(ISourceModule workingCopy) {
		final IScriptProject project = workingCopy.getScriptProject();
		if (project == null) {
			return;
		}
		if (!isIndexerEnabled(project.getProject())) {
			return;
		}
		final IDLTKLanguageToolkit toolkit = DLTKLanguageManager
				.getLanguageToolkit(project);
		if (toolkit == null) {
			return;
		}
		final IProjectIndexer[] indexers = getIndexers(toolkit.getNatureId());
		if (indexers != null) {
			for (int i = 0; i < indexers.length; ++i) {
				indexers[i].reconciled(workingCopy, toolkit);
			}
		}
	}


Considering that I don´t have a nature with a LanguageToolkit bound, my project is considered closed, so the DLTKLanguageManager don´t return the correct languageToolkit. If the workingCopy were passed as an argument to the LanguageManager the correct Toolkit would be returned as I required.

So my question is: "There is any problem if I make that change and propose a pull request to the DLTK's github? What would be the problems that would cause to the system's architecture"
Previous Topic:DLTK Multiple Language Initiative
Next Topic:Reindex and refresh a file on tab switch
Goto Forum:
  


Current Time: Fri Sep 21 13:46:40 GMT 2018

Powered by FUDForum. Page generated in 0.02753 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top