| CompareUI.openCompareDialog [message #310022] |
Wed, 15 November 2006 21:49  |
Eclipse User |
|
|
|
Forgive my newbie-ness, but is this the correct group to post a question
on the CompareUI functionality?
I've been trying to get the CompareDialog to work when passed a
CompareEditorInput containing a CompareNode that implements
IEditableContent (i.e. allows saving of data from within the compare dialog)
I've found what I think are a couple of bugs, around when you press the
Commit button to save the changes made. Basically it doesn't
instantiate a progress monitor correctly for the corresponding
WorkspaceModificationOperation and also it doesn't actually pass the
contents of the modified part to the CompareNode (due to the dialog
parts having been already disposed by the time the save method is being
processed). CompareEditor works just great however.
Anyway, I was wanting to have a chat with the appropriate folks first to
make sure I wasn't being really dumb before I create a bug and submit a
patch.
If this is the wrong group, but you happen to know where the clever
compare folks hang out then please let me know.
Many thanks,
Martin.
|
|
|
|
| Re: CompareUI.openCompareDialog [message #310035 is a reply to message #310032] |
Thu, 16 November 2006 15:28  |
| Eclipse User |
|
|
|
Fantastic - thanks Michael. In the end I just rolled my own
CompareDialog with my fixes incorporated so that it will work in Eclipse
3.0 and up (the joys of supporting RAD :-) ) - but I'll go take a look
at the fixes you made to see what I should have done..
Glad to see I wasn't going totally crazy :-)
M.
Michael Valenta wrote:
> Martin,
>
> I discovered this a few weeks ago as well and have released a fix to
> 3.3. You will need the latest I-build to get the fix.
>
> Michael
>
> Martin Woodward wrote:
>> Forgive my newbie-ness, but is this the correct group to post a question
>> on the CompareUI functionality?
>>
>> I've been trying to get the CompareDialog to work when passed a
>> CompareEditorInput containing a CompareNode that implements
>> IEditableContent (i.e. allows saving of data from within the compare
>> dialog)
>>
>> I've found what I think are a couple of bugs, around when you press the
>> Commit button to save the changes made. Basically it doesn't
>> instantiate a progress monitor correctly for the corresponding
>> WorkspaceModificationOperation and also it doesn't actually pass the
>> contents of the modified part to the CompareNode (due to the dialog
>> parts having been already disposed by the time the save method is being
>> processed). CompareEditor works just great however.
>>
>> Anyway, I was wanting to have a chat with the appropriate folks first to
>> make sure I wasn't being really dumb before I create a bug and submit a
>> patch.
>>
>> If this is the wrong group, but you happen to know where the clever
>> compare folks hang out then please let me know.
>>
>> Many thanks,
>>
>> Martin.
|
|
|
Powered by
FUDForum. Page generated in 0.25029 seconds
Home