|
|
|
Re: PHP class autocomplete [message #1389163 is a reply to message #1328461] |
Fri, 27 June 2014 12:22 |
|
Daniel Mising name wrote on Fri, 02 May 2014 18:08Also, please don't use eval(), it makes old devs nervous.
Well it should make any dev nervous, because it is:
- dangerous piece of code opening potential security holes
- evidence of bad design, which reduces the readability of the code
There are some scenarious where this might be necessary. But your code, Tobias, is not one of them.
Daniel Mising name wrote on Fri, 02 May 2014 18:08Instead it is neater to do this:
$key = strtoupper($key);
$classname = 'nCore_' . $value;
$this->{$key} = new $classname($this);
Braces around $key are unnecessary. You could use them to call strtoupper inside, but
this might look ugly:
$this->{strtoupper($key)} = new $classname($this);
Magento developer at pneumatyka
[Updated on: Tue, 01 July 2014 13:52] Report message to a moderator
|
|
|
Powered by
FUDForum. Page generated in 0.02435 seconds