Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » Graphiti » Enable injecting behavior objects in DiagramBehavior
Enable injecting behavior objects in DiagramBehavior [message #1018920] Thu, 14 March 2013 13:32 Go to next message
Hallvard Traetteberg is currently offline Hallvard Traetteberg
Messages: 594
Registered: July 2009
Location: Trondheim, Norway
Senior Member
Hi,

I just cloned the graphiti git repository to (locally) fix the problem I
reported concerning DoubleClickContext. A lot of errors popped up
concerning the switch to DiagramBehavior, which were easy to fix. Thank
you for this new feature and the explanation of how to update the code.

However, I also noticed that the various behavior objects for
persistency, update etc. were created in DiagramBehavior's constructor.
As discussed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=394315,
this makes it difficult to @Inject these objects, since they are created
before the injector has a chance to provide them. This was fixed for
DiagramEditor, according to the bug, and should also be fixed in
DiagramBehavior, IMO.

Hallvard
Re: Enable injecting behavior objects in DiagramBehavior [message #1019370 is a reply to message #1018920] Fri, 15 March 2013 10:59 Go to previous messageGo to next message
Felix Velasco is currently offline Felix Velasco
Messages: 43
Registered: July 2009
Member
That bug's solution is currently awating review in gerrit, it'll be modified to preserve the functionality in the new structure
Re: Enable injecting behavior objects in DiagramBehavior [message #1020608 is a reply to message #1019370] Mon, 18 March 2013 10:56 Go to previous message
Michael Wenz is currently offline Michael Wenz
Messages: 1590
Registered: July 2009
Location: Walldorf, Germany
Senior Member
I have merged that change today, it is now part of the master branch.

Michael
Previous Topic:Why graphiti is better than GEF
Next Topic:Loading an existing model to a Graphiti Editor
Goto Forum:
  


Current Time: Sat Aug 30 06:27:55 EDT 2014

Powered by FUDForum. Page generated in 0.10721 seconds