Skip to main content



      Home
Home » Eclipse Projects » Subversive » [RESOLVED] Empty "Post-commit hook failure notification" dialog is always raised
[RESOLVED] Empty "Post-commit hook failure notification" dialog is always raised [message #1016504] Wed, 06 March 2013 12:04 Go to next message
Eclipse UserFriend
I just updated subversive to 1.0.1 (org.eclipse.team.svn.ui_1.0.1.I20130301-1700), and I have now a warning message dialog "Post-commit hook failure notification" opened without any text inside after each commit.

After a quick look to the code, it seems to be a bug in the code of subversive. In the class ShowPostCommitErrorsOperation, there is the following check before opening the message dialog:

protected void runImpl(IProgressMonitor monitor) throws Exception {
      SVNPostCommitError []errors = this.provider.getPostCommitErrors();
      if (errors != null) {
            ... (display error message)
      }
}


But, lokking a operation providing postCommitErrors, they always initialize the error array at the beginning, and then fill it if needed. So the above check always get an array (empty in there is no problem) instead of null, and so always displays the error message...

[Updated on: Wed, 13 March 2013 05:08] by Moderator

Re: Empty "Post-commit hook failure notification" dialog is always raised [message #1016514 is a reply to message #1016504] Wed, 06 March 2013 12:54 Go to previous messageGo to next message
Eclipse UserFriend
Sorry, I posted the wrong piece of code. I changed it into the initial post.
Re: Empty "Post-commit hook failure notification" dialog is always raised [message #1016755 is a reply to message #1016514] Thu, 07 March 2013 10:22 Go to previous messageGo to next message
Eclipse UserFriend
https://bugs.eclipse.org/bugs/show_bug.cgi?id=402491. It is already fixed in the latest update.
Re: Empty "Post-commit hook failure notification" dialog is always raised [message #1018149 is a reply to message #1016755] Wed, 13 March 2013 05:08 Go to previous message
Eclipse UserFriend
Great !
Previous Topic:{root_prefix} label decorator does not work in Juno, worked in indigo
Next Topic:label decorator does not work in Juno
Goto Forum:
  


Current Time: Fri Jul 25 08:02:40 EDT 2025

Powered by FUDForum. Page generated in 0.04031 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top