Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Remote Application Platform (RAP) » Design Question about IServiceHandler
Design Question about IServiceHandler [message #933700] Fri, 05 October 2012 04:56 Go to next message
Christian Schwarz is currently offline Christian Schwarz
Messages: 31
Registered: July 2009
Member
I am currently implementing my first org.eclipse.rwt.service.IServiceHandler. I wonder why IServiceHandler#service() takes no HttpServlerRequest/Response arguments, instead one have to call the static RWT.getRequest() and RWT.getResponse(). To me it smells bad, who prevent me to call these static methods anywhere else in my code, and what is the effect? Its also hard to test the IServiceHandler implementation.
Wouldn't IServiceHandler#service(HttpServletRequest,HttpServletResponse) fit better here? Hopefully RAP 2.0 can fix this.

[Updated on: Fri, 05 October 2012 06:55]

Report message to a moderator

Re: Design Question about IServiceHandler [message #936624 is a reply to message #933700] Mon, 08 October 2012 02:51 Go to previous messageGo to next message
Ivan Furnadjiev is currently offline Ivan Furnadjiev
Messages: 1421
Registered: July 2009
Senior Member
Hi Christian,
could you please open an enhancement request with your suggestion?
Thanks,
Ivan

On 10/5/2012 11:56 AM, Christian Schwarz wrote:
> I am currently implementing my first
> org.eclipse.rwt.service.IServiceHandler. I wonder why
> IServiceHandler#service() takes no HttpServlerRequest/Response
> arguments. Instead one have to call the static RWT.getRequest() and
> RWT.getResponse(). To me it smells bad, who prevent me to call these
> static methods anywhere else in my code, and what is the effect?
> Wouldn't
> IServiceHandler#service(HttpServletRequest,HttpServletResponse) fit
> better here? Hopefully RAP 2.0 can fix this.

--
Ivan Furnadjiev

Twitter: @EclipseRAP
Blog: http://eclipsesource.com/blogs/

Professional services for RAP and RCP?
http://eclipsesource.com/services/rap/

Report message to a moderator

Re: Design Question about IServiceHandler [message #936669 is a reply to message #933700] Mon, 08 October 2012 03:58 Go to previous messageGo to next message
Ralf Sternberg is currently offline Ralf Sternberg
Messages: 1146
Registered: July 2009
Senior Member
Hi Christian,

IServiceHandler is a pretty old interface and I completely agree with
your criticism. But instead of changing this interface, I would prefer
to deprecate it and to allow registering real Servlets instead. At any
rate, an enhancement request would be good.

Best regards,
Ralf

--
Ralf Sternberg

Twitter: @EclipseRAP
Blog: http://eclipsesource.com/blogs/

Professional services for RAP and RCP?
http://eclipsesource.com/services/rap/

Report message to a moderator

Re: Design Question about IServiceHandler [message #936946 is a reply to message #936669] Mon, 08 October 2012 10:03 Go to previous message
Christian Schwarz is currently offline Christian Schwarz
Messages: 31
Registered: July 2009
Member
I've opened a enhancement request: https://bugs.eclipse.org/bugs/show_bug.cgi?id=391353

Report message to a moderator

Previous Topic:Java-Version of WAR product
Next Topic:RAP 1.5 GUI testing
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Sat May 18 08:55:49 EDT 2013

Powered by FUDForum. Page generated in 0.01620 seconds