Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » DSDP - Target Management » Terminal Editor instead of View?
Terminal Editor instead of View? [message #9022] Thu, 17 May 2007 19:58 Go to next message
Eclipse User
Originally posted by: mphippard.collab.net

Did you ever consider using an Editor instead of a view for the Terminal?
There are some editor semantics that you'd have to turn off, but from a UI
and window management point of view it seems like it would work better if it
could live in the editor area.

Mark
Re: Terminal Editor instead of View? [message #9148 is a reply to message #9022] Mon, 21 May 2007 16:02 Go to previous messageGo to next message
Martin Oberhuber is currently offline Martin Oberhuber
Messages: 984
Registered: July 2009
Senior Member
The org.eclipse.rse.terminal is a widget that is designed to be embedded
wherever you want it - even on embedded / eRCP (with minor tweaks).

The org.eclipse.rse.terminal.view is a view using that widget. There
isn't a lot of code associated with the view -- for the terminal
functionality it's just using the widget.

That being said, if you want to create an editor embedding the terminal
widget, just go forward and do it. If you'd like to contribute your work
back into open source, there may be others who like it and help you
improve it. Writing a bugzilla enhancement would be the first step. On
Bugzilla, we could have more discussions about this idea. Eventually,
you might end up attaching your source code (under EPL) to that bug.

I cannot guarantee that we'd accept such a contribution into the
standard downloads, but I could imagine it being a programming example.
For more details on how to contribute, see the TM and RSE FAQ on the
Wiki, http://wiki.eclipse.org/index.php/TM_and_RSE_FAQ

Cheers,
Martin
Re: Terminal Editor instead of View? [message #9208 is a reply to message #9148] Tue, 22 May 2007 16:06 Go to previous messageGo to next message
Steve Elsemore is currently offline Steve Elsemore
Messages: 9
Registered: July 2009
Junior Member
Thanks, Martin. Embedding the terminal widget in my editor worked well.
I did have to make use of several internal packages, however (for example,
ITerminalListener, ITerminalConnector, TerminalState).
Re: Terminal Editor instead of View? [message #9228 is a reply to message #9208] Thu, 24 May 2007 15:41 Go to previous messageGo to next message
Martin Oberhuber is currently offline Martin Oberhuber
Messages: 984
Registered: July 2009
Senior Member
Yes, the terminal API is not yet complete to a stage
where we could guarantee binary compatibility over
multiple releases. Therefore we kept it internal for now.

If you'd like helping evolve the API, you are more than
welcome to participate in a discussion. I'd recommend
filing specific bugzilla enhancement requests against
DSDP-Target Management if you have concrete suggestions
how to improve the API.

Currently,
org.eclipse.tm.internal.terminal.provisional.api
contains those classes and interfaces that we intend to
make API in the future.

Thanks,
--
Martin Oberhuber
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm


Steve Elsemore wrote:
> Thanks, Martin. Embedding the terminal widget in my editor worked
> well. I did have to make use of several internal packages, however (for
> example, ITerminalListener, ITerminalConnector, TerminalState).
>
Re: Terminal Editor instead of View? [message #10221 is a reply to message #9208] Fri, 25 May 2007 01:12 Go to previous messageGo to next message
Michael Scharf is currently offline Michael Scharf
Messages: 298
Registered: July 2009
Senior Member
Steve Elsemore wrote:
> Thanks, Martin. Embedding the terminal widget in my editor worked
> well. I did have to make use of several internal packages, however (for
> example, ITerminalListener, ITerminalConnector, TerminalState).
>

Hi Steve,
I am currently heavily refactoring the terminal. It would be
very interesting for me to know how exactly you are using
the terminal inside the editor. Unfortunately the refactoring
work is not my highest priority, so it might take a while
to finish. This means there will be several releases with
changing APIs :-(

I don't know what kind of project you are working on and
if you consider making it open source. But the terminal in
an editor would be a great example project for the
terminal. It could also help making currently internal
classes API...

...and as Marting suggested: bugzilla is your friend ;-)

Michael

--
Michael Scharf
Wind River Systems GmbH
http://www.WindRiver.com
http://MichaelScharf.blogspot.com/
Re: Terminal Editor instead of View? [message #10252 is a reply to message #10221] Fri, 25 May 2007 15:40 Go to previous messageGo to next message
Eclipse User
Originally posted by: mphippard.collab.net

On 5/24/07 9:12 PM, in article 465637E9.1020205@windriver.com, "Michael
Scharf" <Michael.Scharf@windriver.com> wrote:

> Steve Elsemore wrote:
>> Thanks, Martin. Embedding the terminal widget in my editor worked
>> well. I did have to make use of several internal packages, however (for
>> example, ITerminalListener, ITerminalConnector, TerminalState).
>>
>
> Hi Steve,
> I am currently heavily refactoring the terminal. It would be
> very interesting for me to know how exactly you are using
> the terminal inside the editor. Unfortunately the refactoring
> work is not my highest priority, so it might take a while
> to finish. This means there will be several releases with
> changing APIs :-(

Steve has been on a mini-vacation. So I will answer for him as best I can.

We basically just wrapped the Terminal widget with an editor as opposed to a
view. I think it works better for our perspective layout as the Terminal
editor has the right "shape" to support what someone would want when using
it.

We are only supporting SSH, and we made the editor allow us to open it to a
specific host. I do not think we have done a lot more than re-use your
controls, hook up the menus and toolbar actions etc. It works pretty cool.

In terms of your refactoring, aren't you getting pretty close to lockdown
for Eclipse 3.3 release? We would not try to release anything before then.

> I don't know what kind of project you are working on and
> if you consider making it open source. But the terminal in
> an editor would be a great example project for the
> terminal. It could also help making currently internal
> classes API...
>
> ..and as Marting suggested: bugzilla is your friend ;-)

I think our needs are pretty lite. We probably would not need to ask for
much if anything. We'd be happy to contribute what we have done back to
you. We might not have the time to prepare it as a proper submission
though. But if you just want the code as an example, we would be happy to
do so.

Mark
Re: Terminal Editor instead of View? [message #10350 is a reply to message #10252] Tue, 29 May 2007 16:49 Go to previous messageGo to next message
Martin Oberhuber is currently offline Martin Oberhuber
Messages: 984
Registered: July 2009
Senior Member
Yes we're locking down TM 2.0, and while doing so
we decided that the Terminal was not quite ready
for locking down an official public API that would
be supportable over multiple releases.

So we refactored it to
org.eclipse.tm.internal.terminal.provisional.api
for now. Which doesn't mean it's unusable, it just
means that it may change next year with TM 3.0.

Yes if you'd like to submit your code that would
be very interesting. We could probably make an
Example for embedding the terminal out of it.
I'd suggest submitting as a bugzilla enhancement
request and attaching the code to it.

For having it usable in Eclipse, it would be best
if you could license it under EPL. And verify that
you are the original authors of it (without copying
any non-EPL stuff. See the TM and RSE FAQ for
details:
http://wiki.eclipse.org/index.php/TM_and_RSE_FAQ

Thanks,
--
Martin Oberhuber
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm


Mark Phippard wrote:
> On 5/24/07 9:12 PM, in article 465637E9.1020205@windriver.com, "Michael
> Scharf" <Michael.Scharf@windriver.com> wrote:
>
>> Steve Elsemore wrote:
>>> Thanks, Martin. Embedding the terminal widget in my editor worked
>>> well. I did have to make use of several internal packages, however (for
>>> example, ITerminalListener, ITerminalConnector, TerminalState).
>>>
>> Hi Steve,
>> I am currently heavily refactoring the terminal. It would be
>> very interesting for me to know how exactly you are using
>> the terminal inside the editor. Unfortunately the refactoring
>> work is not my highest priority, so it might take a while
>> to finish. This means there will be several releases with
>> changing APIs :-(
>
> Steve has been on a mini-vacation. So I will answer for him as best I can.
>
> We basically just wrapped the Terminal widget with an editor as opposed to a
> view. I think it works better for our perspective layout as the Terminal
> editor has the right "shape" to support what someone would want when using
> it.
>
> We are only supporting SSH, and we made the editor allow us to open it to a
> specific host. I do not think we have done a lot more than re-use your
> controls, hook up the menus and toolbar actions etc. It works pretty cool.
>
> In terms of your refactoring, aren't you getting pretty close to lockdown
> for Eclipse 3.3 release? We would not try to release anything before then.
>
>> I don't know what kind of project you are working on and
>> if you consider making it open source. But the terminal in
>> an editor would be a great example project for the
>> terminal. It could also help making currently internal
>> classes API...
>>
>> ..and as Marting suggested: bugzilla is your friend ;-)
>
> I think our needs are pretty lite. We probably would not need to ask for
> much if anything. We'd be happy to contribute what we have done back to
> you. We might not have the time to prepare it as a proper submission
> though. But if you just want the code as an example, we would be happy to
> do so.
>
> Mark
>
>
Re: Terminal Editor instead of View? [message #10828 is a reply to message #10221] Fri, 15 June 2007 21:07 Go to previous messageGo to next message
Eclipse User
Originally posted by: mphippard.collab.net

On 5/24/07 9:12 PM, in article 465637E9.1020205@windriver.com, "Michael
Scharf" <Michael.Scharf@windriver.com> wrote:

> Steve Elsemore wrote:
>> Thanks, Martin. Embedding the terminal widget in my editor worked
>> well. I did have to make use of several internal packages, however (for
>> example, ITerminalListener, ITerminalConnector, TerminalState).
>>
>
> Hi Steve,
> I am currently heavily refactoring the terminal. It would be
> very interesting for me to know how exactly you are using
> the terminal inside the editor. Unfortunately the refactoring
> work is not my highest priority, so it might take a while
> to finish. This means there will be several releases with
> changing APIs :-(
>
> I don't know what kind of project you are working on and
> if you consider making it open source. But the terminal in
> an editor would be a great example project for the
> terminal. It could also help making currently internal
> classes API...
>
> ..and as Marting suggested: bugzilla is your friend ;-)
>
>
> Michael

Michael,

I just updated to 2.0RC3 and you are right, you did a lot of refactoring.
Some of it looked straightforward. The only thing I seemed to have to
change was some places that used ITerminalConnector and now needed to use
ITerminalConnectorInfo.

The one thing I am stuck on is that our code used to be contructing an
SshConnector object directly and then setting that on the
ITerminalViewControl#setConnector method. This method now wants an
ITerminalConnectorInfo and I am at a loss as to how to provide it the one
for the SshConnector.

Should I just find the ID for that connector and then walk the array of
objects to get it?

I am sure there is a "right way" to do this, and I am still just
prototyping. But we basically want to open up an SSH Terminal to a host.

Mark
Re: Terminal Editor instead of View? [message #11965 is a reply to message #10828] Tue, 26 June 2007 04:18 Go to previous messageGo to next message
Michael Scharf is currently offline Michael Scharf
Messages: 298
Registered: July 2009
Senior Member
Mark Phippard wrote:
> I just updated to 2.0RC3 and you are right, you did a lot of refactoring.
> Some of it looked straightforward. The only thing I seemed to have to
> change was some places that used ITerminalConnector and now needed to use
> ITerminalConnectorInfo.
>
> The one thing I am stuck on is that our code used to be contructing an
> SshConnector object directly and then setting that on the
> ITerminalViewControl#setConnector method. This method now wants an
> ITerminalConnectorInfo and I am at a loss as to how to provide it the one
> for the SshConnector.

To have the same semantics, instead of setting the SshConnector,
create an instance of ITerminalConnectorInfo:

new ITerminalConnectorInfo(){
public ITerminalConnector getConnector() {
return new SshConnector(....);
}
public String getId() {
return "com.yourdomain.ssh";
}
public String getInitializationErrorMessage() {
return null;
}
public String getName() {
return "SSH";
}
public boolean isInitialized() {
return true;
}};



> Should I just find the ID for that connector and then walk the array of
> objects to get it?

That would probably be the easiest, because the extension would
create the SshConnection for you:

ITerminalConnectorInfo getSsh() {
ITerminalConnectorInfo[] c = TerminalConnectorExtension.getTerminalConnectors();
for (int i = 0; i < c.length; i++) {
if("org.eclipse.tm.internal.terminal.ssh.SshConnector".equals(c[i]))
return c[i];
}
return null;
}

This is probably more robust (in the sense that it is less
likely to change) than the method above..

> I am sure there is a "right way" to do this, and I am still just
> prototyping. But we basically want to open up an SSH Terminal to a host.

There is currently no "right way" of doing this, but I'd suggest to iterate
over the extensions.


Michael
--
http://MichaelScharf.blogspot.com/
Re: Terminal Editor instead of View? [message #12015 is a reply to message #11965] Mon, 02 July 2007 18:43 Go to previous message
Eclipse User
Originally posted by: mphippard.collab.net

On 6/26/07 12:18 AM, in article 4680937C.4030703@windriver.com, "Michael
Scharf" <Michael.Scharf@windriver.com> wrote:

> Mark Phippard wrote:
>> I just updated to 2.0RC3 and you are right, you did a lot of refactoring.
>> Some of it looked straightforward. The only thing I seemed to have to
>> change was some places that used ITerminalConnector and now needed to use
>> ITerminalConnectorInfo.
>>
>> The one thing I am stuck on is that our code used to be contructing an
>> SshConnector object directly and then setting that on the
>> ITerminalViewControl#setConnector method. This method now wants an
>> ITerminalConnectorInfo and I am at a loss as to how to provide it the one
>> for the SshConnector.
>
> To have the same semantics, instead of setting the SshConnector,
> create an instance of ITerminalConnectorInfo:
>
> new ITerminalConnectorInfo(){
> public ITerminalConnector getConnector() {
> return new SshConnector(....);
> }
> public String getId() {
> return "com.yourdomain.ssh";
> }
> public String getInitializationErrorMessage() {
> return null;
> }
> public String getName() {
> return "SSH";
> }
> public boolean isInitialized() {
> return true;
> }};
>
>
>
>> Should I just find the ID for that connector and then walk the array of
>> objects to get it?
>
> That would probably be the easiest, because the extension would
> create the SshConnection for you:
>
> ITerminalConnectorInfo getSsh() {
> ITerminalConnectorInfo[] c =
> TerminalConnectorExtension.getTerminalConnectors();
> for (int i = 0; i < c.length; i++) {
> if("org.eclipse.tm.internal.terminal.ssh.SshConnector".equals(c[i]))
> return c[i];
> }
> return null;
> }
>
> This is probably more robust (in the sense that it is less
> likely to change) than the method above..
>
>> I am sure there is a "right way" to do this, and I am still just
>> prototyping. But we basically want to open up an SSH Terminal to a host.
>
> There is currently no "right way" of doing this, but I'd suggest to iterate
> over the extensions.

We are using this latter approach successfully. Another question has come
up. Is there a way to provide our own connection settings page? We wanted
to customize it a bit and do things like offer to remember passwords.

Mark
Re: Terminal Editor instead of View? [message #567642 is a reply to message #9022] Mon, 21 May 2007 16:02 Go to previous message
Martin Oberhuber is currently offline Martin Oberhuber
Messages: 984
Registered: July 2009
Senior Member
The org.eclipse.rse.terminal is a widget that is designed to be embedded
wherever you want it - even on embedded / eRCP (with minor tweaks).

The org.eclipse.rse.terminal.view is a view using that widget. There
isn't a lot of code associated with the view -- for the terminal
functionality it's just using the widget.

That being said, if you want to create an editor embedding the terminal
widget, just go forward and do it. If you'd like to contribute your work
back into open source, there may be others who like it and help you
improve it. Writing a bugzilla enhancement would be the first step. On
Bugzilla, we could have more discussions about this idea. Eventually,
you might end up attaching your source code (under EPL) to that bug.

I cannot guarantee that we'd accept such a contribution into the
standard downloads, but I could imagine it being a programming example.
For more details on how to contribute, see the TM and RSE FAQ on the
Wiki, http://wiki.eclipse.org/index.php/TM_and_RSE_FAQ

Cheers,
Martin
Re: Terminal Editor instead of View? [message #567697 is a reply to message #9148] Tue, 22 May 2007 16:06 Go to previous message
Steve Elsemore is currently offline Steve Elsemore
Messages: 9
Registered: July 2009
Junior Member
Thanks, Martin. Embedding the terminal widget in my editor worked well.
I did have to make use of several internal packages, however (for example,
ITerminalListener, ITerminalConnector, TerminalState).
Re: Terminal Editor instead of View? [message #567719 is a reply to message #9208] Thu, 24 May 2007 15:41 Go to previous message
Martin Oberhuber is currently offline Martin Oberhuber
Messages: 984
Registered: July 2009
Senior Member
Yes, the terminal API is not yet complete to a stage
where we could guarantee binary compatibility over
multiple releases. Therefore we kept it internal for now.

If you'd like helping evolve the API, you are more than
welcome to participate in a discussion. I'd recommend
filing specific bugzilla enhancement requests against
DSDP-Target Management if you have concrete suggestions
how to improve the API.

Currently,
org.eclipse.tm.internal.terminal.provisional.api
contains those classes and interfaces that we intend to
make API in the future.

Thanks,
--
Martin Oberhuber
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm


Steve Elsemore wrote:
> Thanks, Martin. Embedding the terminal widget in my editor worked
> well. I did have to make use of several internal packages, however (for
> example, ITerminalListener, ITerminalConnector, TerminalState).
>
Re: Terminal Editor instead of View? [message #567777 is a reply to message #9208] Fri, 25 May 2007 01:12 Go to previous message
Michael Scharf is currently offline Michael Scharf
Messages: 298
Registered: July 2009
Senior Member
Steve Elsemore wrote:
> Thanks, Martin. Embedding the terminal widget in my editor worked
> well. I did have to make use of several internal packages, however (for
> example, ITerminalListener, ITerminalConnector, TerminalState).
>

Hi Steve,
I am currently heavily refactoring the terminal. It would be
very interesting for me to know how exactly you are using
the terminal inside the editor. Unfortunately the refactoring
work is not my highest priority, so it might take a while
to finish. This means there will be several releases with
changing APIs :-(

I don't know what kind of project you are working on and
if you consider making it open source. But the terminal in
an editor would be a great example project for the
terminal. It could also help making currently internal
classes API...

...and as Marting suggested: bugzilla is your friend ;-)

Michael

--
Michael Scharf
Wind River Systems GmbH
http://www.WindRiver.com
http://MichaelScharf.blogspot.com/
Re: Terminal Editor instead of View? [message #567806 is a reply to message #10221] Fri, 25 May 2007 15:40 Go to previous message
Mark Phippard is currently offline Mark Phippard
Messages: 129
Registered: July 2009
Senior Member
On 5/24/07 9:12 PM, in article 465637E9.1020205@windriver.com, "Michael
Scharf" <Michael.Scharf@windriver.com> wrote:

> Steve Elsemore wrote:
>> Thanks, Martin. Embedding the terminal widget in my editor worked
>> well. I did have to make use of several internal packages, however (for
>> example, ITerminalListener, ITerminalConnector, TerminalState).
>>
>
> Hi Steve,
> I am currently heavily refactoring the terminal. It would be
> very interesting for me to know how exactly you are using
> the terminal inside the editor. Unfortunately the refactoring
> work is not my highest priority, so it might take a while
> to finish. This means there will be several releases with
> changing APIs :-(

Steve has been on a mini-vacation. So I will answer for him as best I can.

We basically just wrapped the Terminal widget with an editor as opposed to a
view. I think it works better for our perspective layout as the Terminal
editor has the right "shape" to support what someone would want when using
it.

We are only supporting SSH, and we made the editor allow us to open it to a
specific host. I do not think we have done a lot more than re-use your
controls, hook up the menus and toolbar actions etc. It works pretty cool.

In terms of your refactoring, aren't you getting pretty close to lockdown
for Eclipse 3.3 release? We would not try to release anything before then.

> I don't know what kind of project you are working on and
> if you consider making it open source. But the terminal in
> an editor would be a great example project for the
> terminal. It could also help making currently internal
> classes API...
>
> ..and as Marting suggested: bugzilla is your friend ;-)

I think our needs are pretty lite. We probably would not need to ask for
much if anything. We'd be happy to contribute what we have done back to
you. We might not have the time to prepare it as a proper submission
though. But if you just want the code as an example, we would be happy to
do so.

Mark
Re: Terminal Editor instead of View? [message #567901 is a reply to message #10252] Tue, 29 May 2007 16:49 Go to previous message
Martin Oberhuber is currently offline Martin Oberhuber
Messages: 984
Registered: July 2009
Senior Member
Yes we're locking down TM 2.0, and while doing so
we decided that the Terminal was not quite ready
for locking down an official public API that would
be supportable over multiple releases.

So we refactored it to
org.eclipse.tm.internal.terminal.provisional.api
for now. Which doesn't mean it's unusable, it just
means that it may change next year with TM 3.0.

Yes if you'd like to submit your code that would
be very interesting. We could probably make an
Example for embedding the terminal out of it.
I'd suggest submitting as a bugzilla enhancement
request and attaching the code to it.

For having it usable in Eclipse, it would be best
if you could license it under EPL. And verify that
you are the original authors of it (without copying
any non-EPL stuff. See the TM and RSE FAQ for
details:
http://wiki.eclipse.org/index.php/TM_and_RSE_FAQ

Thanks,
--
Martin Oberhuber
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm


Mark Phippard wrote:
> On 5/24/07 9:12 PM, in article 465637E9.1020205@windriver.com, "Michael
> Scharf" <Michael.Scharf@windriver.com> wrote:
>
>> Steve Elsemore wrote:
>>> Thanks, Martin. Embedding the terminal widget in my editor worked
>>> well. I did have to make use of several internal packages, however (for
>>> example, ITerminalListener, ITerminalConnector, TerminalState).
>>>
>> Hi Steve,
>> I am currently heavily refactoring the terminal. It would be
>> very interesting for me to know how exactly you are using
>> the terminal inside the editor. Unfortunately the refactoring
>> work is not my highest priority, so it might take a while
>> to finish. This means there will be several releases with
>> changing APIs :-(
>
> Steve has been on a mini-vacation. So I will answer for him as best I can.
>
> We basically just wrapped the Terminal widget with an editor as opposed to a
> view. I think it works better for our perspective layout as the Terminal
> editor has the right "shape" to support what someone would want when using
> it.
>
> We are only supporting SSH, and we made the editor allow us to open it to a
> specific host. I do not think we have done a lot more than re-use your
> controls, hook up the menus and toolbar actions etc. It works pretty cool.
>
> In terms of your refactoring, aren't you getting pretty close to lockdown
> for Eclipse 3.3 release? We would not try to release anything before then.
>
>> I don't know what kind of project you are working on and
>> if you consider making it open source. But the terminal in
>> an editor would be a great example project for the
>> terminal. It could also help making currently internal
>> classes API...
>>
>> ..and as Marting suggested: bugzilla is your friend ;-)
>
> I think our needs are pretty lite. We probably would not need to ask for
> much if anything. We'd be happy to contribute what we have done back to
> you. We might not have the time to prepare it as a proper submission
> though. But if you just want the code as an example, we would be happy to
> do so.
>
> Mark
>
>
Re: Terminal Editor instead of View? [message #568367 is a reply to message #10221] Fri, 15 June 2007 21:07 Go to previous message
Mark Phippard is currently offline Mark Phippard
Messages: 129
Registered: July 2009
Senior Member
On 5/24/07 9:12 PM, in article 465637E9.1020205@windriver.com, "Michael
Scharf" <Michael.Scharf@windriver.com> wrote:

> Steve Elsemore wrote:
>> Thanks, Martin. Embedding the terminal widget in my editor worked
>> well. I did have to make use of several internal packages, however (for
>> example, ITerminalListener, ITerminalConnector, TerminalState).
>>
>
> Hi Steve,
> I am currently heavily refactoring the terminal. It would be
> very interesting for me to know how exactly you are using
> the terminal inside the editor. Unfortunately the refactoring
> work is not my highest priority, so it might take a while
> to finish. This means there will be several releases with
> changing APIs :-(
>
> I don't know what kind of project you are working on and
> if you consider making it open source. But the terminal in
> an editor would be a great example project for the
> terminal. It could also help making currently internal
> classes API...
>
> ..and as Marting suggested: bugzilla is your friend ;-)
>
>
> Michael

Michael,

I just updated to 2.0RC3 and you are right, you did a lot of refactoring.
Some of it looked straightforward. The only thing I seemed to have to
change was some places that used ITerminalConnector and now needed to use
ITerminalConnectorInfo.

The one thing I am stuck on is that our code used to be contructing an
SshConnector object directly and then setting that on the
ITerminalViewControl#setConnector method. This method now wants an
ITerminalConnectorInfo and I am at a loss as to how to provide it the one
for the SshConnector.

Should I just find the ID for that connector and then walk the array of
objects to get it?

I am sure there is a "right way" to do this, and I am still just
prototyping. But we basically want to open up an SSH Terminal to a host.

Mark
Re: Terminal Editor instead of View? [message #568477 is a reply to message #10828] Tue, 26 June 2007 04:18 Go to previous message
Michael Scharf is currently offline Michael Scharf
Messages: 298
Registered: July 2009
Senior Member
Mark Phippard wrote:
> I just updated to 2.0RC3 and you are right, you did a lot of refactoring.
> Some of it looked straightforward. The only thing I seemed to have to
> change was some places that used ITerminalConnector and now needed to use
> ITerminalConnectorInfo.
>
> The one thing I am stuck on is that our code used to be contructing an
> SshConnector object directly and then setting that on the
> ITerminalViewControl#setConnector method. This method now wants an
> ITerminalConnectorInfo and I am at a loss as to how to provide it the one
> for the SshConnector.

To have the same semantics, instead of setting the SshConnector,
create an instance of ITerminalConnectorInfo:

new ITerminalConnectorInfo(){
public ITerminalConnector getConnector() {
return new SshConnector(....);
}
public String getId() {
return "com.yourdomain.ssh";
}
public String getInitializationErrorMessage() {
return null;
}
public String getName() {
return "SSH";
}
public boolean isInitialized() {
return true;
}};



> Should I just find the ID for that connector and then walk the array of
> objects to get it?

That would probably be the easiest, because the extension would
create the SshConnection for you:

ITerminalConnectorInfo getSsh() {
ITerminalConnectorInfo[] c = TerminalConnectorExtension.getTerminalConnectors();
for (int i = 0; i < c.length; i++) {
if("org.eclipse.tm.internal.terminal.ssh.SshConnector".equals(c[i]))
return c[i];
}
return null;
}

This is probably more robust (in the sense that it is less
likely to change) than the method above..

> I am sure there is a "right way" to do this, and I am still just
> prototyping. But we basically want to open up an SSH Terminal to a host.

There is currently no "right way" of doing this, but I'd suggest to iterate
over the extensions.


Michael
--
http://MichaelScharf.blogspot.com/
Re: Terminal Editor instead of View? [message #568610 is a reply to message #11965] Mon, 02 July 2007 18:43 Go to previous message
Mark Phippard is currently offline Mark Phippard
Messages: 129
Registered: July 2009
Senior Member
On 6/26/07 12:18 AM, in article 4680937C.4030703@windriver.com, "Michael
Scharf" <Michael.Scharf@windriver.com> wrote:

> Mark Phippard wrote:
>> I just updated to 2.0RC3 and you are right, you did a lot of refactoring.
>> Some of it looked straightforward. The only thing I seemed to have to
>> change was some places that used ITerminalConnector and now needed to use
>> ITerminalConnectorInfo.
>>
>> The one thing I am stuck on is that our code used to be contructing an
>> SshConnector object directly and then setting that on the
>> ITerminalViewControl#setConnector method. This method now wants an
>> ITerminalConnectorInfo and I am at a loss as to how to provide it the one
>> for the SshConnector.
>
> To have the same semantics, instead of setting the SshConnector,
> create an instance of ITerminalConnectorInfo:
>
> new ITerminalConnectorInfo(){
> public ITerminalConnector getConnector() {
> return new SshConnector(....);
> }
> public String getId() {
> return "com.yourdomain.ssh";
> }
> public String getInitializationErrorMessage() {
> return null;
> }
> public String getName() {
> return "SSH";
> }
> public boolean isInitialized() {
> return true;
> }};
>
>
>
>> Should I just find the ID for that connector and then walk the array of
>> objects to get it?
>
> That would probably be the easiest, because the extension would
> create the SshConnection for you:
>
> ITerminalConnectorInfo getSsh() {
> ITerminalConnectorInfo[] c =
> TerminalConnectorExtension.getTerminalConnectors();
> for (int i = 0; i < c.length; i++) {
> if("org.eclipse.tm.internal.terminal.ssh.SshConnector".equals(c[i]))
> return c[i];
> }
> return null;
> }
>
> This is probably more robust (in the sense that it is less
> likely to change) than the method above..
>
>> I am sure there is a "right way" to do this, and I am still just
>> prototyping. But we basically want to open up an SSH Terminal to a host.
>
> There is currently no "right way" of doing this, but I'd suggest to iterate
> over the extensions.

We are using this latter approach successfully. Another question has come
up. Is there a way to provide our own connection settings page? We wanted
to customize it a bit and do things like offer to remember passwords.

Mark
Previous Topic:How to open a new connection wizard for a particular system type?
Next Topic:TM Monthly Phone Call 6-Jun -- Meeting Notes
Goto Forum:
  


Current Time: Thu Oct 02 16:40:21 GMT 2014

Powered by FUDForum. Page generated in 0.03862 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software