Eclipse Community Forums: EMF "Technology" (Ecore Tools, EMFatic, etc) » [Texo] "clear list" feature causes ConcurrentModificationException

Home » Modeling » EMF "Technology" (Ecore Tools, EMFatic, etc) » [Texo] "clear list" feature causes ConcurrentModificationException(Generated code seems invalid)

Show: Today's Messages :: Show Polls :: Message Navigator

[Texo] "clear list" feature causes ConcurrentModificationException [message #756811]

Tue, 15 November 2011 08:56

R. Oldenburg

Messages: 24
Registered: September 2011

Junior Member

Hi,

don't know if I am using the latest Texo version (downloaded it approx. 1 month ago).
Will have a look at it.

So maybe this is already fixed.

The issue:
When generating bi-directional support for a ordered 1:n-relation then there are some generated features handling the changes that need to be applied to the "n"-list.

The method "clearXYZ" seems to be generated incorrectly as it:
- iterates over the list with an foreach (for XYZ xyz : XYZs)
- and calls "removeXYZ" for every entry (which handles the bi-directional remove)

This consequently leads to an ConcurrentModificationException because the list ( which it currently iterates on) is being modified (entries are removed).

Imo there are two possible solutions:
- Iterate over a copy of the org. list (i.e. for (XYZ xyz : new ArrayList<XYZ>(XYZs))
or
- simply remove the first entry from the list until it is empty

while (!XYZs.isEmpty()) {
 removeXYZ(XYZs.get(0));
}

Keep on the good work.
Thanks a lot for this tool and regards,
Roland

Report message to a moderator

Re: [Texo] "clear list" feature causes ConcurrentModificationException [message #756863 is a reply to message #756811]

Tue, 15 November 2011 11:35

Martin Taal

Messages: 5468
Registered: July 2009

Senior Member

Hi Roland,
Seems indeed like a bug, can you enter a bugzilla on Texo?
https://bugs.eclipse.org/bugs/enter_bug.cgi?product=EMFT&component=Texo&version=0.5

with the same description/text then I will pick it up.

gr. Martin

On 11/15/2011 09:56 AM, R. Oldenburg wrote:
> Hi,
>
> don't know if I am using the latest Texo version (downloaded it approx. 1 month ago).
> Will have a look at it.
>
> So maybe this is already fixed.
>
> The issue:
> When generating bi-directional support for a ordered 1:n-relation then there are some generated features handling the
> changes that need to be applied to the "n"-list.
>
> The method "clearXYZ" seems to be generated incorrectly as it:
> - iterates over the list with an foreach (for XYZ xyz : XYZs)
> - and calls "removeXYZ" for every entry (which handles the bi-directional remove)
>
> This consequently leads to an ConcurrentModificationException because the list ( which it currently iterates on) is
> being modified (entries are removed).
>
> Imo there are two possible solutions:
> - Iterate over a copy of the org. list (i.e. for (XYZ xyz : new ArrayList<XYZ>(XYZs))
> or
> - simply remove the first entry from the list until it is empty
> while (!XYZs.isEmpty()) {
> removeXYZ(XYZs.get(0));
> }
>
> Keep on the good work.
> Thanks a lot for this tool and regards,
> Roland

--

With Regards, Martin Taal

Springsite/Elver.org
Office: Hardwareweg 4, 3821 BV Amersfoort
Postal: Nassaulaan 7, 3941 EC Doorn
The Netherlands
Cell: +31 (0)6 288 48 943
Tel: +31 (0)84 420 2397
Fax: +31 (0)84 225 9307
Mail: mtaal@springsite.com - mtaal@elver.org
Web: www.springsite.com - www.elver.org

Report message to a moderator

Previous Topic:	Using EMF generated codes in external java codes
Next Topic:	Duplicated ecore models !!

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Apr 26 06:01:57 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter