Eclipse Community Forums: Eclipse Platform » CompareEditor showing Comments

Help

Home

Home » Eclipse Projects » Eclipse Platform » CompareEditor showing Comments

Show: Today's Messages :: Show Polls :: Message Navigator

CompareEditor showing Comments [message #660956]

Tue, 22 March 2011 13:58

Nadav

Messages: 29
Registered: July 2009

Junior Member

We have a plugin which creates markers on resources. Users need to see the markers in the CompareEditor.

The problem is that this only works for Java files.

Is this a fundamental difference between JavaMergeViewer and TextMergeViewer i.e. that only the former supports showing markers? Is there some way to get the TextMergeViewer to also show markers?

Report message to a moderator

Re: CompareEditor showing Comments [message #661148 is a reply to message #660956]

Wed, 23 March 2011 11:36

Tomasz Zarna

Messages: 172
Registered: July 2009

Senior Member

The trick JDT made was switching to the new API in Compare added in 3.5. The crucial part is org.eclipse.compare.contentmergeviewer.TextMergeViewer.getEd itorInput(ISourceViewer), which allows JavaMergeViewer to create a CompilationUnitEditorAdapter object (a subclass of JavaEditor, a real editor, not a viewer).

Report message to a moderator

Re: CompareEditor showing Comments [message #661154 is a reply to message #661148]

Wed, 23 March 2011 11:56

Nadav

Messages: 29
Registered: July 2009

Junior Member

Ok, so it's feasable that the CDT MergeViewer and the TextMergeViewer will eventually also switch to the new interface and support displaying markers.

Any idea when that might happen?

Is there some place where I can viewer planned features related to CompareEditor functionality?

Thanks,

Nadav

Report message to a moderator

Re: CompareEditor showing Comments [message #661399 is a reply to message #661154]

Thu, 24 March 2011 14:24

Tomasz Zarna

Messages: 172
Registered: July 2009

Senior Member

Nadav wrote on Wed, 23 March 2011 12:56

Any idea when that might happen?

For TextMergeViewer see this bug. Don't know if guys from CDT have something similar on their list.

Nadav wrote on Wed, 23 March 2011 12:56

Is there some place where I can viewer planned features related to CompareEditor functionality?

For each release we create a dev plan draft on wiki and a little bit later a final version of the plan gets published on Team component page. For 3.8/4.1 we'll probably act in a similar manner.

Report message to a moderator

Re: CompareEditor showing Comments [message #661467 is a reply to message #661399]

Thu, 24 March 2011 18:44

Nadav

Messages: 29
Registered: July 2009

Junior Member

Tomasz Zarna wrote on Thu, 24 March 2011 10:24

Nadav wrote on Wed, 23 March 2011 12:56

Any idea when that might happen?

For TextMergeViewer see this bug. Don't know if guys from CDT have something similar on their list.

Thanks Tomasz!

Is there anywhere we could voice our support for fixing this bug sooner rather than later?(or at least the Displaying-Markers for TextMergeViewer part?)

Just to describe our need: we have a code review tool with 500 active users and growing. Most of the users like to do their code reviews in CompareEditor(in order to review only the changed code), but currently only the Java developers can actually see their comments(as markers) in the Compare Editor. It's a useful tool and it also introduces a lot of developers to Eclipse for the first time.

Report message to a moderator

Previous Topic:	Tabbed Properties Views does not try to adapt the ISelection content
Next Topic:	Eclipse damaged after uninstalling a feature

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 18 00:05:50 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter