Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Eclipse Platform » CompareEditor showing Comments
CompareEditor showing Comments [message #660956] Tue, 22 March 2011 13:58 Go to next message
Nadav is currently offline Nadav
Messages: 29
Registered: July 2009
Junior Member
We have a plugin which creates markers on resources. Users need to see the markers in the CompareEditor.

The problem is that this only works for Java files.

Is this a fundamental difference between JavaMergeViewer and TextMergeViewer i.e. that only the former supports showing markers? Is there some way to get the TextMergeViewer to also show markers?
Re: CompareEditor showing Comments [message #661148 is a reply to message #660956] Wed, 23 March 2011 11:36 Go to previous messageGo to next message
Tomasz Zarna is currently offline Tomasz Zarna
Messages: 165
Registered: July 2009
Senior Member
The trick JDT made was switching to the new API in Compare added in 3.5. The crucial part is org.eclipse.compare.contentmergeviewer.TextMergeViewer.getEd itorInput(ISourceViewer), which allows JavaMergeViewer to create a CompilationUnitEditorAdapter object (a subclass of JavaEditor, a real editor, not a viewer).
Re: CompareEditor showing Comments [message #661154 is a reply to message #661148] Wed, 23 March 2011 11:56 Go to previous messageGo to next message
Nadav is currently offline Nadav
Messages: 29
Registered: July 2009
Junior Member
Ok, so it's feasable that the CDT MergeViewer and the TextMergeViewer will eventually also switch to the new interface and support displaying markers.

Any idea when that might happen?

Is there some place where I can viewer planned features related to CompareEditor functionality?

Thanks,

Nadav
Re: CompareEditor showing Comments [message #661399 is a reply to message #661154] Thu, 24 March 2011 14:24 Go to previous messageGo to next message
Tomasz Zarna is currently offline Tomasz Zarna
Messages: 165
Registered: July 2009
Senior Member
Nadav wrote on Wed, 23 March 2011 12:56

Any idea when that might happen?


For TextMergeViewer see this bug. Don't know if guys from CDT have something similar on their list.

Nadav wrote on Wed, 23 March 2011 12:56

Is there some place where I can viewer planned features related to CompareEditor functionality?


For each release we create a dev plan draft on wiki and a little bit later a final version of the plan gets published on Team component page. For 3.8/4.1 we'll probably act in a similar manner.
Re: CompareEditor showing Comments [message #661467 is a reply to message #661399] Thu, 24 March 2011 18:44 Go to previous message
Nadav is currently offline Nadav
Messages: 29
Registered: July 2009
Junior Member
Tomasz Zarna wrote on Thu, 24 March 2011 10:24
Nadav wrote on Wed, 23 March 2011 12:56

Any idea when that might happen?


For TextMergeViewer see this bug. Don't know if guys from CDT have something similar on their list.



Thanks Tomasz!

Is there anywhere we could voice our support for fixing this bug sooner rather than later?(or at least the Displaying-Markers for TextMergeViewer part?)

Just to describe our need: we have a code review tool with 500 active users and growing. Most of the users like to do their code reviews in CompareEditor(in order to review only the changed code), but currently only the Java developers can actually see their comments(as markers) in the Compare Editor. It's a useful tool and it also introduces a lot of developers to Eclipse for the first time.
Previous Topic:Tabbed Properties Views does not try to adapt the ISelection content
Next Topic:Eclipse damaged after uninstalling a feature
Goto Forum:
  


Current Time: Fri Oct 31 08:01:11 GMT 2014

Powered by FUDForum. Page generated in 0.03488 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software