Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » GEF » [Zest] Missing GraphViewer constructor
[Zest] Missing GraphViewer constructor [message #651474] Mon, 31 January 2011 05:00 Go to next message
Daniel Krügler is currently offline Daniel Krügler
Messages: 853
Registered: July 2009
Senior Member
I recently stumbled across the following limitation of GraphViewer:

Basically all Viewer implementations provide a second constructor that
allows me to provide the hosted control (which is the Graph object for a
GraphViewer). This constructor is missing for GraphViewer, which is
really annoying.

One might think that the proper replacement of this functionality is
provided by the setControl function, but this is incorrect: This
function does *not* correctly replace the previous graph, it just adds a
second one.

I recommend two fixes:

1) Please provide a constructor that accepts a single Graph object as
basically all other Viewers do.

2) I also recommend to fix the setControl function: Either remove it (I
don't see it's current value and all standard Viewer implementations are
not capable to replace the hosted control anyway) or if you think that
replacing the control makes sense, please fix this function: It would
mean that the previously set control has to be be dispose()'ed before
assigning a new one. Personally I would simply remove this setter.

Thanks & Greetings from Bremen,

Daniel Krügler
Re: [Zest] Missing GraphViewer constructor [message #656570 is a reply to message #651474] Sat, 26 February 2011 16:16 Go to previous message
Fabian Steeg is currently offline Fabian Steeg
Messages: 72
Registered: July 2009
Member
True, it probably makes sense to be consistent with the other viewers here. I've added such a constructor and removed the setControl method in Zest 2.0 (see http://wiki.eclipse.org/Zest#Zest_2.x).
Previous Topic:Can I reverse a layout?
Next Topic:[Zest] Clearing a Graph
Goto Forum:
  


Current Time: Mon Jul 28 22:38:06 EDT 2014

Powered by FUDForum. Page generated in 0.02465 seconds