Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Mylyn » Empty password
Empty password [message #594749] Tue, 11 November 2008 05:52
Morten Hindsholm is currently offline Morten Hindsholm
Messages: 2
Registered: July 2009
Junior Member
I am developing a connector, and I think I might have spotted a minor bug.

My backend requires a login, but it is legal to have an empty password.

However, AbstractRepositorySettingsPage.isPageComplete() explicitly checks -
via the private method isMissingCredentials() - against empty passwords.

This means that I cannot easily implement isPageComplete() in my
RepositorySettings class which extends AbstractRepositorySettingsPage, because
I cannot call super.isPageComplete() with an empty password, and I also cannot
bypass AbstractRepositorySettingsPage and call isPageComplete() in its
superclass AbstractTaskRepositoryPage. If you understand...

I think a reasonable fix would be to make
AbstractRepositorySettingsPage.isMissingCredentials() protected instead of
private.

--
/\/\orten
Previous Topic:Could not load repository template extension repository
Next Topic:Mylyn WikiText Stand-Alone Package Available
Goto Forum:
  


Current Time: Tue Jul 29 13:16:38 EDT 2014

Powered by FUDForum. Page generated in 0.03146 seconds