Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Eclipse Platform » FormEditor and dirty/commit protocol
FormEditor and dirty/commit protocol [message #512982] Mon, 08 February 2010 08:56
Franck Mising name is currently offline Franck Mising name
Messages: 91
Registered: July 2009
Location: France
Member
I am confused by the dirty/commit semantics in the FormEditor and IFormPart.

According to the isDirty() javadoc in those classes, editor.isDirty() answers whether the editor needs saving, whereas part.isDirty() answers whether a GUI part has any GUI state that hasn't been commited to the model (in memory).

However the default implementations in AbstractFormPart and FormEditor mark the editor as dirty if and only if one of its parts is dirty??
So if for example a text part marks itself as dirty with each key press then commits when Return is hit or it loses focus, the editor ends up as not dirty even though the model does need saving.

Shouldn't AbstractFormPart.commit() call editor.setNeedsSaving(true) (and editorDirtyStateChanged)
and editor.isDirty() be implemented as
_needsSaving || <any contained part is dirty>?
Previous Topic:drasys.or.prob.NormalDistribution
Next Topic:Separation of Java and Eclipse Worlds
Goto Forum:
  


Current Time: Thu Jul 31 23:52:51 EDT 2014

Powered by FUDForum. Page generated in 0.01544 seconds