Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Buckminster dev » Launcher Icon Missing
Launcher Icon Missing [message #35250] Wed, 17 June 2009 17:18 Go to next message
Johannes Utzig is currently offline Johannes UtzigFriend
Messages: 329
Registered: July 2009
Senior Member
Hi,

I am building an eclipse product with the buckminster version for
3.5RC4. I noticed that no launcher icon gets created although it works
with the eclipse export product wizard.

I wanted to create a patch for that, but after some investigation I'm
really not sure which component is actually behaving wrong, so I just
post my results so far:

Let's say my workspace consists of a feature project 'feature' with a
..product file and a plugin project 'product' with the launcher icon and
the product extension.

-WS
|-product
-icon.ico
-plugin.xml
|-feature
-feature.xml
-product.product

After debugging the P2SiteGenerator#getProductDescriptor I noticed the
following:

It executes new ProductFile(productFile.getAbsolutePath())

The ProductFile starts parsing and retrieves the image paths. This is
done in the addIcon method ('value' is the location entered in the
..product file and 'location' is the absolute location of the .product file):

if(!new File(value).isAbsolute())
value = new File(location.getParentFile(),
value).getAbsolutePath();
list.add(value);

The path produced by the chooser dialog in the .product editor seems to
be relative to the workspace root. In the given example that makes
/product/icon.ico

Applying the above method will result in
/abs/path/to/workspace/feature/product/icon.ico when it really should be
/abs/path/to/workspace/product/icon.ico

So obviously this path is wrong and it's of no surprise that the icon is
missing in the produced launcher. If I manually edit the path from
/product/icon.ico to /icon.ico and copy the icon from 'product' to
'feature' everything works fine (although the .product editor complains
about a path pointing nowhere).

I hope that was a somewhat understandable description.

I'd open a bug, but I'm very unsure if it's the .product editor's fault,
the ProductFile class' fault, buckminster's fault for not doing some
secret magic the eclipse product export is doing, or my own, for a
misshaped project layout.

Please let me know if I should open a bugzilla for that (but on which
component?) or if can otherwise be of support.

Best regards,
Johannes
Re: Launcher Icon Missing [message #35312 is a reply to message #35250] Wed, 17 June 2009 18:10 Go to previous messageGo to next message
Thomas Hallgren is currently offline Thomas HallgrenFriend
Messages: 3232
Registered: July 2009
Senior Member
Hi Johannes,
Please open a bugzilla for this. Use Product=Buckminster and Component=PDE support for now. If it turns out the problem
lays elsewhere, it's easy to move the bug later on.

As always, a sample that reproduces the problem is very helpful. It's not a requirement of course but it generally saves
us a lot of time when fixing the problem. It's also a good way of verifying the fix.

Regards,
Thomas Hallgren

Johannes Utzig wrote:
> Hi,
>
> I am building an eclipse product with the buckminster version for
> 3.5RC4. I noticed that no launcher icon gets created although it works
> with the eclipse export product wizard.
>
> I wanted to create a patch for that, but after some investigation I'm
> really not sure which component is actually behaving wrong, so I just
> post my results so far:
>
> Let's say my workspace consists of a feature project 'feature' with a
> .product file and a plugin project 'product' with the launcher icon and
> the product extension.
>
> -WS
> |-product
> -icon.ico
> -plugin.xml
> |-feature
> -feature.xml
> -product.product
>
> After debugging the P2SiteGenerator#getProductDescriptor I noticed the
> following:
>
> It executes new ProductFile(productFile.getAbsolutePath())
>
> The ProductFile starts parsing and retrieves the image paths. This is
> done in the addIcon method ('value' is the location entered in the
> .product file and 'location' is the absolute location of the .product
> file):
>
> if(!new File(value).isAbsolute())
> value = new File(location.getParentFile(),
> value).getAbsolutePath();
> list.add(value);
>
> The path produced by the chooser dialog in the .product editor seems to
> be relative to the workspace root. In the given example that makes
> /product/icon.ico
>
> Applying the above method will result in
> /abs/path/to/workspace/feature/product/icon.ico when it really should be
> /abs/path/to/workspace/product/icon.ico
>
> So obviously this path is wrong and it's of no surprise that the icon is
> missing in the produced launcher. If I manually edit the path from
> /product/icon.ico to /icon.ico and copy the icon from 'product' to
> 'feature' everything works fine (although the .product editor complains
> about a path pointing nowhere).
>
> I hope that was a somewhat understandable description.
>
> I'd open a bug, but I'm very unsure if it's the .product editor's fault,
> the ProductFile class' fault, buckminster's fault for not doing some
> secret magic the eclipse product export is doing, or my own, for a
> misshaped project layout.
>
> Please let me know if I should open a bugzilla for that (but on which
> component?) or if can otherwise be of support.
>
> Best regards,
> Johannes
Re: Launcher Icon Missing [message #35380 is a reply to message #35312] Thu, 18 June 2009 10:03 Go to previous message
Johannes Utzig is currently offline Johannes UtzigFriend
Messages: 329
Registered: July 2009
Senior Member
Hi Thomas,


ok, done https://bugs.eclipse.org/bugs/show_bug.cgi?id=280721
Let me know if you need more.

Best regards,
Johannes

Thomas Hallgren schrieb:
> Hi Johannes,
> Please open a bugzilla for this. Use Product=Buckminster and
> Component=PDE support for now. If it turns out the problem lays
> elsewhere, it's easy to move the bug later on.
>
> As always, a sample that reproduces the problem is very helpful. It's
> not a requirement of course but it generally saves us a lot of time when
> fixing the problem. It's also a good way of verifying the fix.
>
> Regards,
> Thomas Hallgren
>
> Johannes Utzig wrote:
>> Hi,
>>
>> I am building an eclipse product with the buckminster version for
>> 3.5RC4. I noticed that no launcher icon gets created although it works
>> with the eclipse export product wizard.
>>
>> I wanted to create a patch for that, but after some investigation I'm
>> really not sure which component is actually behaving wrong, so I just
>> post my results so far:
>>
>> Let's say my workspace consists of a feature project 'feature' with a
>> .product file and a plugin project 'product' with the launcher icon
>> and the product extension.
>>
>> -WS
>> |-product
>> -icon.ico
>> -plugin.xml
>> |-feature
>> -feature.xml
>> -product.product
>>
>> After debugging the P2SiteGenerator#getProductDescriptor I noticed the
>> following:
>>
>> It executes new ProductFile(productFile.getAbsolutePath())
>>
>> The ProductFile starts parsing and retrieves the image paths. This is
>> done in the addIcon method ('value' is the location entered in the
>> .product file and 'location' is the absolute location of the .product
>> file):
>>
>> if(!new File(value).isAbsolute())
>> value = new File(location.getParentFile(),
>> value).getAbsolutePath();
>> list.add(value);
>>
>> The path produced by the chooser dialog in the .product editor seems
>> to be relative to the workspace root. In the given example that makes
>> /product/icon.ico
>>
>> Applying the above method will result in
>> /abs/path/to/workspace/feature/product/icon.ico when it really should
>> be /abs/path/to/workspace/product/icon.ico
>>
>> So obviously this path is wrong and it's of no surprise that the icon
>> is missing in the produced launcher. If I manually edit the path from
>> /product/icon.ico to /icon.ico and copy the icon from 'product' to
>> 'feature' everything works fine (although the .product editor
>> complains about a path pointing nowhere).
>>
>> I hope that was a somewhat understandable description.
>>
>> I'd open a bug, but I'm very unsure if it's the .product editor's
>> fault, the ProductFile class' fault, buckminster's fault for not doing
>> some secret magic the eclipse product export is doing, or my own, for
>> a misshaped project layout.
>>
>> Please let me know if I should open a bugzilla for that (but on which
>> component?) or if can otherwise be of support.
>>
>> Best regards,
>> Johannes
Previous Topic:Buckminster for Galileo RC5
Next Topic:[buckminster-dev] Committer vote for Ed Merks has concluded successfully
Goto Forum:
  


Current Time: Thu Dec 18 15:36:18 GMT 2014

Powered by FUDForum. Page generated in 0.01589 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software