Eclipse Community Forums: Eclipse SmartHome » using ExtendedDiscoveryService with MDNSDiscoveryParticipant

Help

Home

Home » Archived » Eclipse SmartHome » using ExtendedDiscoveryService with MDNSDiscoveryParticipant

Show: Today's Messages :: Show Polls :: Message Navigator

using ExtendedDiscoveryService with MDNSDiscoveryParticipant [message #1776279]

Tue, 14 November 2017 21:59

Marcel Verpaalen

Messages: 59
Registered: September 2014

Member

Hi,

I'm trying to implement ExtendedDiscoveryService for a discovery based on MDNSDiscoveryParticipant.

Unfortunately setDiscoveryServiceCallback is never called, hence any use of discoveryServiceCallback.getExistingThing(thingUID) is giving a NPE.
If I try to extend AbstractDiscoveryService and use it, it is not working in combination with the MDNSDiscoveryParticipant.

Any suggestion on how to be able to use the combination?

Report message to a moderator

Re: using ExtendedDiscoveryService with MDNSDiscoveryParticipant [message #1776300 is a reply to message #1776279]

Wed, 15 November 2017 07:45

Simon Kaufmann

Messages: 51
Registered: January 2011

Member

That's indeed right - it works only for DiscoveryService implementations currently (which in your case would be the MDSNDiscoveryService). The MDNSDiscoveryParticipants however only hook into them.

I don't see why this same mechanism couldn't be extend for participants also. It would mean that the MDSNDiscoveryService needs to implement the ExtendedDiscoveryService interface and in turn applies the same mechanism as the DiscoveryServiceRegistryImpl to any MDNSDiscoveryParticipant - i.e. if these also implement ExtendedDiscoveryService then it forwards the DiscoveryServiceCallback instance to them (and accordingly for UPnP, of course). It just gotta be done cleanly in terms of OSGi so it won't leak any stale instances.

Please file an issue on github for this enhancement - and preferably also a PR ;-)

Report message to a moderator