Eclipse Community Forums: Dynamic Languages Toolkit (DLTK)

Home » Eclipse Projects » Dynamic Languages Toolkit (DLTK) » ASTVisitor.visitGeneral

ASTVisitor.visitGeneral [message #25580]

Thu, 12 June 2008 12:25

Eclipse User

Might I suggest that your method visitGeneral have the following
implementation:

public boolean visitGeneral(ASTNode node) throws Exception {
node.traverse(this);
return true;
}

This should make sure that every node in the tree is traversed by default,
even if the visitor does nothing with each node.

Thanks,
Chuck

Re: ASTVisitor.visitGeneral [message #25619 is a reply to message #25580]

Thu, 12 June 2008 16:53

Eclipse User

Please ignore this post.
I got confused.

It is now my understanding that ASTNode and its subclasses will implement
the traverse method
to
a) call visitor.visit(this)
b) call traverse(visitor) on any child nodes
c) call visitor.endvisit(this)

Each Visitor class simple operates on each node it is passed in visit and
endvisit.

Chuck

"Chuck Doucette" <cdoucette@vaultus.com> wrote in message
news:g2rint$sae$1@build.eclipse.org...
> Might I suggest that your method visitGeneral have the following
> implementation:
>
> public boolean visitGeneral(ASTNode node) throws Exception {
> node.traverse(this);
> return true;
> }
>
> This should make sure that every node in the tree is traversed by default,
> even if the visitor does nothing with each node.
>
> Thanks,
> Chuck
>
>

Previous Topic:	(org.eclipse.dltk.ui.text.completion.)ProposalInfo.getHTMLContentReader:150 - NullPointerException
Next Topic:	type hierarchy and code completion

Goto Forum:

-=] Back to Top [=-

Current Time: Tue Jun 10 12:54:45 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter