Eclipse Community Forums: Eclipse Platform » CVS: internal error on a non-zero tag exit

Home » Eclipse Projects » Eclipse Platform » CVS: internal error on a non-zero tag exit

CVS: internal error on a non-zero tag exit [message #272736]

Mon, 27 September 2004 08:59

Eclipse User

Hi

Has anyone else seen the following:
I have commitinfo & taginfo scripts in place. These work perfectly from
the command line doing validations before commits & tags are allowed and
reporting errors and aborting when the conditions are not met.

When doing a commit from Eclipse and the commit is failed (a non-zero exit
from commit info) then Eclipse successfully displays the error.

***
cvs ci -m "This has no $Id: so it should break...."
"/testing/HelloWorld.java"

current username : ggoldsmith
current directory : /tmp/cvs-serv11763
CVS repository : /usr/local/cvsroot/testing
commit status : authorised!
./HelloWorld.java does not have CVS Id keyword
Add @version $Id$ to the class javadoc comment

cvs server: Pre-commit check failed
cvs [server aborted]: correct above errors first!
The server reported an error while performing the "cvs commit" command.
(took 0:00.406)
Error: testing: cvs server: Pre-commit check failed
Error: testing: cvs [server aborted]: correct above errors first!
***

When doing a tag which results in a non-zero exit from taginfo I simply
get an error message...

***
cvs tag "/testing/thisshouldbreak" "/testing/HelloWorld.java"
failed due to an internal error (took 0:00.312)
***

It is important for my users to see the error message explaining why the
tag was invalid. Has anyone seen this before?

Thanks

Gavin

Re: CVS: internal error on a non-zero tag exit [message #272742 is a reply to message #272736]

Mon, 27 September 2004 09:23

Eclipse User

Gavin,

There is no CVS specification for the types of errors that can be
returned. Also, errors are retuend as E text messages but the problem is
that often E messages do not reflect an error, so only those that have
been witnessed to indicate an error are recognized. The error you are
experiencing is not being recognized by the Eclipse CVS error parsers.

One of our goals for 3.1 is to improve the error handling in general. It
would be helpful if you could log a bug against Platform CVS with the
specifics of the failure you are seeing. The following URL gives the
steps to obtains a trace of all the communications between the client
and server. If you can attach that, that would be helpful to us in
devising a means of improving the error handling for this case.

http://dev.eclipse.org/viewcvs/index.cgi/%7Echeckout%7E/plat form-vcm-home/docs/online/cvs_features2.0/cvs-faq.html#misc_ 0

In the meantime, you should tell your users to work with the CVS console
enabled (preference on the Team>CVS>CVS Console preference page). The
console should give the reason why the tag failed.

Michael

Gavin Goldsmith wrote:

> Hi
>
> Has anyone else seen the following:
> I have commitinfo & taginfo scripts in place. These work perfectly from
> the command line doing validations before commits & tags are allowed and
> reporting errors and aborting when the conditions are not met.
>
>
> When doing a commit from Eclipse and the commit is failed (a non-zero exit
> from commit info) then Eclipse successfully displays the error.
>
> ***
> cvs ci -m "This has no $Id: so it should break...."
> "/testing/HelloWorld.java"
>
> current username : ggoldsmith
> current directory : /tmp/cvs-serv11763
> CVS repository : /usr/local/cvsroot/testing
> commit status : authorised!
> ./HelloWorld.java does not have CVS Id keyword
> Add @version $Id$ to the class javadoc comment
>
> cvs server: Pre-commit check failed
> cvs [server aborted]: correct above errors first!
> The server reported an error while performing the "cvs commit" command.
> (took 0:00.406)
> Error: testing: cvs server: Pre-commit check failed
> Error: testing: cvs [server aborted]: correct above errors first!
> ***
>
>
> When doing a tag which results in a non-zero exit from taginfo I simply
> get an error message...
>
> ***
> cvs tag "/testing/thisshouldbreak" "/testing/HelloWorld.java"
> failed due to an internal error (took 0:00.312)
> ***
>
>
> It is important for my users to see the error message explaining why the
> tag was invalid. Has anyone seen this before?
>
> Thanks
>
> Gavin
>
>

Re: CVS: internal error on a non-zero tag exit [message #272759 is a reply to message #272742]

Mon, 27 September 2004 11:07

Eclipse User

Hi Michael

As susggested I have logged a bug (# 75091) for the experience below. Just
to re-iterate a few points:
* The problem seems specific to a non-zero return from taginfo; commitinfo
treats this successfully

* Only the "internal error" message is being delivered to the console. The
detailed output from CVS is being 'lost'.

Thanks for your prompt & friendly responses.

From breezy but sunny Cape Town...

Gavin

Michael Valenta wrote:

> Gavin,

> There is no CVS specification for the types of errors that can be
> returned. Also, errors are retuend as E text messages but the problem is
> that often E messages do not reflect an error, so only those that have
> been witnessed to indicate an error are recognized. The error you are
> experiencing is not being recognized by the Eclipse CVS error parsers.

> One of our goals for 3.1 is to improve the error handling in general. It
> would be helpful if you could log a bug against Platform CVS with the
> specifics of the failure you are seeing. The following URL gives the
> steps to obtains a trace of all the communications between the client
> and server. If you can attach that, that would be helpful to us in
> devising a means of improving the error handling for this case.

>
http://dev.eclipse.org/viewcvs/index.cgi/%7Echeckout%7E/plat form-vcm-home/docs/online/cvs_features2.0/cvs-faq.html#misc_ 0

> In the meantime, you should tell your users to work with the CVS console
> enabled (preference on the Team>CVS>CVS Console preference page). The
> console should give the reason why the tag failed.

> Michael

> Gavin Goldsmith wrote:

> > Hi
> >
> > Has anyone else seen the following:
> > I have commitinfo & taginfo scripts in place. These work perfectly from
> > the command line doing validations before commits & tags are allowed and
> > reporting errors and aborting when the conditions are not met.
> >
> >
> > When doing a commit from Eclipse and the commit is failed (a non-zero exit
> > from commit info) then Eclipse successfully displays the error.
> >
> > ***
> > cvs ci -m "This has no $Id: so it should break...."
> > "/testing/HelloWorld.java"
> >
> > current username : ggoldsmith
> > current directory : /tmp/cvs-serv11763
> > CVS repository : /usr/local/cvsroot/testing
> > commit status : authorised!
> > ./HelloWorld.java does not have CVS Id keyword
> > Add @version $Id$ to the class javadoc comment
> >
> > cvs server: Pre-commit check failed
> > cvs [server aborted]: correct above errors first!
> > The server reported an error while performing the "cvs commit" command.
> > (took 0:00.406)
> > Error: testing: cvs server: Pre-commit check failed
> > Error: testing: cvs [server aborted]: correct above errors first!
> > ***
> >
> >
> > When doing a tag which results in a non-zero exit from taginfo I simply
> > get an error message...
> >
> > ***
> > cvs tag "/testing/thisshouldbreak" "/testing/HelloWorld.java"
> > failed due to an internal error (took 0:00.312)
> > ***
> >
> >
> > It is important for my users to see the error message explaining why the
> > tag was invalid. Has anyone seen this before?
> >
> > Thanks
> >
> > Gavin
> >
> >

Previous Topic:	How to keep same CVS repository view after versioning?
Next Topic:	Exporting preferences

Goto Forum:

-=] Back to Top [=-

Current Time: Sat Jun 14 20:59:05 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter