Eclipse Community Forums: JFace » ChangeManager#getRealm thread safety concern

Home » Eclipse Projects » JFace » ChangeManager#getRealm thread safety concern

ChangeManager#getRealm thread safety concern [message #20519]

Sun, 12 July 2009 22:09

Eclipse User

In ChangeManager (the root of many observables like WritableList), the
"realm" field is not final and getRealm() has no synchronization. My basic
and limited understanding of the Java Memory Model tells me that I have a
chance of getting null from getRealm if I access it from a different thread
than the one that created the object.

Can anyone confirm or refute this? I think making the realm field final
would be good practice regardless.

-Will

Re: ChangeManager#getRealm thread safety concern [message #20553 is a reply to message #20519]

Mon, 13 July 2009 12:13

Eclipse User

See bug 282690. The plan is to synchronize isDisposed() and to no
longer null the realm. We could probably make it final too as you have
suggested.

Matthew

Will Horn wrote:
> In ChangeManager (the root of many observables like WritableList), the
> "realm" field is not final and getRealm() has no synchronization. My
> basic and limited understanding of the Java Memory Model tells me that I
> have a chance of getting null from getRealm if I access it from a
> different thread than the one that created the object.
>
> Can anyone confirm or refute this? I think making the realm field final
> would be good practice regardless.
>
> -Will

Previous Topic:	[databinding] Binding same TableViewer with 2nd input
Next Topic:	ObservableCollectionTreeContentProvider duplicate TreeNode creation

Goto Forum:

-=] Back to Top [=-

Current Time: Thu Jul 17 19:39:24 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter