| Markers or more general annotations? [message #164471] |
Tue, 02 December 2003 04:43  |
Eclipse User |
|
|
|
Originally posted by: clemas.uk.ibm.com
Hi,
I work on the AspectJ Development Tools for Eclipse. We are in the midst
of a major rewrite and one of the problems we want to address is
scalability.
In the current version we represent AspectJ advice against source files
with 'markers'. There could potentially be many hundreds of markers on a
large file, thousands across a project and we are worried about the
performance of this kind of system.
Our markers are relatively lightweight, mostly consisting of just a java
resource handle for the 'source' of the advice, a line number within that
'source' - *But* I imagine to address some of the memory usage concerns
I'd like to implement some kind of memory management system that manages
many of these markers on disk until required.
I'm wondering if markers are the right solution for managing these kind of
markups on files or should I look to providing my own kind of annotations
(subclassing org.eclipse.jface.text.source.AnnotationModel) - I can't seem
to find an example of a non-marker related subclass of AnnotationModel?
Or is there yet another option I don't know about?
Oh, I should add, although we have our own editor that wants to show these
markers, I will want to contribute them for display in the standard JDT
editor too - does that makes a difference to which route I take?
any thoughts appreciated !!
thanks,
Andy.
---
Andy Clement
AJDT Development
|
|
|
| Re: Markers or more general annotations? [message #164567 is a reply to message #164471] |
Tue, 02 December 2003 08:06  |
| Eclipse User |
|
|
|
Originally posted by: bob.objfac.com
If the markers are light weight and you have only thousands, what's the
issue? Have you measured significant performance overhead?
Bob
"Andy Clement" <clemas@uk.ibm.com> wrote in message
news:bqhms4$bcm$1@eclipse.org...
> Hi,
>
> I work on the AspectJ Development Tools for Eclipse. We are in the midst
> of a major rewrite and one of the problems we want to address is
> scalability.
>
> In the current version we represent AspectJ advice against source files
> with 'markers'. There could potentially be many hundreds of markers on a
> large file, thousands across a project and we are worried about the
> performance of this kind of system.
>
> Our markers are relatively lightweight, mostly consisting of just a java
> resource handle for the 'source' of the advice, a line number within that
> 'source' - *But* I imagine to address some of the memory usage concerns
> I'd like to implement some kind of memory management system that manages
> many of these markers on disk until required.
>
> I'm wondering if markers are the right solution for managing these kind of
> markups on files or should I look to providing my own kind of annotations
> (subclassing org.eclipse.jface.text.source.AnnotationModel) - I can't seem
> to find an example of a non-marker related subclass of AnnotationModel?
> Or is there yet another option I don't know about?
>
> Oh, I should add, although we have our own editor that wants to show these
> markers, I will want to contribute them for display in the standard JDT
> editor too - does that makes a difference to which route I take?
>
> any thoughts appreciated !!
>
> thanks,
> Andy.
>
> ---
> Andy Clement
> AJDT Development
>
>
>
>
|
|
|
| Re: Markers or more general annotations? [message #164852 is a reply to message #164471] |
Tue, 02 December 2003 14:42 |
| Eclipse User |
|
|
|
Originally posted by: John_Arthorne.oti.com_
There is currently no way to have markers that are stored on disk and
lazily brought into memory. Markers and all their attributes stay in
memory all of the time. The storage format is relatively compact, but
there are at least a couple of objects in memory per marker and one
object per attribute. The core "spy" plugin (available from platform
core team page on eclipse.org) has a view (element tree spy) that
computes the total space usage of all resources, with a breakdown for
all space used by markers. You can use this to get an estimate of the
space usage.
Another major problem with markers is that there is no way to share
these annotations in a repository. Forgive my ignorance of AspectJ, but
is advice something that is generated by the aspect weaver or is it
"source" information that will need to be stored in the repository?
--
Andy Clement wrote:
> Hi,
>
> I work on the AspectJ Development Tools for Eclipse. We are in the midst
> of a major rewrite and one of the problems we want to address is
> scalability.
>
> In the current version we represent AspectJ advice against source files
> with 'markers'. There could potentially be many hundreds of markers on a
> large file, thousands across a project and we are worried about the
> performance of this kind of system.
>
> Our markers are relatively lightweight, mostly consisting of just a java
> resource handle for the 'source' of the advice, a line number within that
> 'source' - *But* I imagine to address some of the memory usage concerns
> I'd like to implement some kind of memory management system that manages
> many of these markers on disk until required.
>
> I'm wondering if markers are the right solution for managing these kind of
> markups on files or should I look to providing my own kind of annotations
> (subclassing org.eclipse.jface.text.source.AnnotationModel) - I can't seem
> to find an example of a non-marker related subclass of AnnotationModel?
> Or is there yet another option I don't know about?
>
> Oh, I should add, although we have our own editor that wants to show these
> markers, I will want to contribute them for display in the standard JDT
> editor too - does that makes a difference to which route I take?
>
> any thoughts appreciated !!
>
> thanks,
> Andy.
>
> ---
> Andy Clement
> AJDT Development
>
>
>
>
|
|
|
Powered by
FUDForum. Page generated in 0.02856 seconds
Home