Eclipse Community Forums: GMF (Graphical Modeling Framework)

Home » Modeling » GMF (Graphical Modeling Framework) » ComponentEditPolicy

Thu, 15 November 2007 09:44

Eclipse User

Originally posted by: sd10046.lanet.lv

ComponentEditPolicy -> createDeleteSemanticCommand has

....
Command semanticCmd = getHost().getCommand(editCommandRequest);
if (semanticCmd != null && semanticCmd.canExecute()) {
CompoundCommand cc = new CompoundCommand();
cc.add(semanticCmd);
return cc;
}
return createDeleteViewCommand(deleteRequest);

Am I right that even if command can't be executed, view will be deleted
anyway?
Is it correct behaviour?

--
Ty

Re: ComponentEditPolicy [message #160933 is a reply to message #160695]

Fri, 16 November 2007 08:41

Eclipse User

Ty,

Yes, your conclusion seems correct. If the logic in
shouldDeleteSemantic() is correct, then I would think that if you can't
delete the semantic element that the view should not be deleted.
However, a client may be depending on this behavior as it is now. Is it
causing you a problem?

Regards,
Cherie

Ty Phoon wrote:
> ComponentEditPolicy -> createDeleteSemanticCommand has
>
> ...
> Command semanticCmd = getHost().getCommand(editCommandRequest);
> if (semanticCmd != null && semanticCmd.canExecute()) {
> CompoundCommand cc = new CompoundCommand();
> cc.add(semanticCmd);
> return cc;
> }
> return createDeleteViewCommand(deleteRequest);
>
>
> Am I right that even if command can't be executed, view will be deleted
> anyway?
> Is it correct behaviour?
>

Previous Topic:	Canvas/DiagramEditor class generation question
Next Topic:	Setting of Edge bendpoints does not reflect visually

Goto Forum:

-=] Back to Top [=-

Current Time: Tue Jul 15 13:13:23 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter