Eclipse Community Forums: GEF » Is it ok for command to show dialogs?

Home » Eclipse Projects » GEF » Is it ok for command to show dialogs?

Is it ok for command to show dialogs? [message #119561]

Thu, 26 February 2004 08:26

Eclipse User

Originally posted by: eostroukhov.hotmail.com

When the user creates a table (using the GEF CreateTool) the command shows
the dialog (i.e. select number of columns, etc.)

Is it ok for GEF or we have some architectural constraints against doing so?
I'm asking this because one problem was encountered under special conditions
(NullPointerException in CreationTool).

Eugene

Re: Is it ok for command to show dialogs? [message #119587 is a reply to message #119561]

Thu, 26 February 2004 09:43

Eclipse User

Originally posted by: none.us.ibm.com

It is typically not a good idea because most dialogs have a "Cancel" button,
and commands cannot abort. It is not a good idea for other reasons too,
such as the potential to hold onto stuff too long in your command, which is
on the command stack, and could cause temporary memory leaks.

The alternative is to display the dialog by extending the CreationTool and
overriding performCreate(...)

"Eugene Ostroukhov" <eostroukhov@hotmail.com> wrote in message
news:c1krvq$s9v$1@eclipse.org...
> When the user creates a table (using the GEF CreateTool) the command shows
> the dialog (i.e. select number of columns, etc.)
>
> Is it ok for GEF or we have some architectural constraints against doing
so?
> I'm asking this because one problem was encountered under special
conditions
> (NullPointerException in CreationTool).
>
> Eugene
>
>

Previous Topic:	Efficiently Reloading the diagram
Next Topic:	connections leading to nowhere

Goto Forum:

-=] Back to Top [=-

Current Time: Thu Jul 10 04:40:07 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter