Eclipse Community Forums: NatTable » Select column & RowSelectionModel

Home » Eclipse Projects » NatTable » Select column & RowSelectionModel(Very long hang...)

Select column & RowSelectionModel [message #890982]

Sat, 23 June 2012 12:54

Eclipse User

Friend

There is a bug between SelectColumnCommandHandler and RowSelectionModel.

SelectColumnCommandHandler uses Integer.MAX_VALUE to identify all rows as being selected, however in RowSelectionModel, it has to iterate each row and store the values (where those rows exist). Looking up 2x10^9 rows takes a very long time however.

As a quick fix I've extended the RowSelectionModel as follows:

public void addSelection(final Rectangle range) {
if (range.y + range.height > gridLayer.getBodyDataProvider().getRowCount()) {
range.height = gridLayer.getBodyDataProvider().getRowCount() - range.y + 1;
}
super.addSelection(range);
}

Paul

Edit: version 2.3.1.1

[Updated on: Sat, 23 June 2012 14:06] by Moderator

Re: Select column & RowSelectionModel [message #891922 is a reply to message #890982]

Tue, 26 June 2012 11:14

Eclipse User

Friend

Hi Paul,

Thanks for this - I have checked in a change to RowSelectionModel.addSelection() to consider the layer rowCount in order to limit the iteration. https://bugs.eclipse.org/bugs/show_bug.cgi?id=383565

Cheers,
Edwin

Previous Topic:	Select column upon RMB click
Next Topic:	Using a different configuration gives a NullPointerException

Goto Forum:

-=] Back to Top [=-

Current Time: Tue Jul 01 02:13:51 EDT 2025

Powered by FUDForum. Page generated in 0.06307 seconds

.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top