| wtp xml editor completions not particular clever nor efficient [message #89126] |
Thu, 31 March 2005 07:16  |
Eclipse User |
|
|
|
Hi,
While working with the xml editor I was kinda disappointed to discover
that the editor did not insert required attributes and elements when
completing on a tag name and that
it did a very high number of iterations on even the simplest completions.
While investigating I saw that there exist a method called
AbstractContentModelGenerator.getRequiredText(parent, ed)
which for some reason is not called even though it generates all the
relevant info for these completions!?
I also saw that even though the matchstring is like "pro" *all* tags are
generated and then afterwards filtered away even though
you could save alot of memory and cpu-cycles by skipping tagnames that
does not start with "pro".
Is this some work in progress (some of the code look half baked) that will
be improved or do you seek contributions for it ?
-max
|
|
|
|
| Re: wtp xml editor completions not particular clever nor efficient [message #89173 is a reply to message #89126] |
Thu, 31 March 2005 10:42  |
| Eclipse User |
|
|
|
On Thu, 31 Mar 2005 14:16:59 +0200, Max Rydahl Andersen <max.andersen@jboss.com> wrote:
Thanks for opening bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=89811
I've responded there, but to re-iterate, we will always
consider high quality patches for improvements.
For something like this, which could entail a lot of work on
your part, its fair to state your interest and intent (I'd recommend doing
so in the bug/feature request you've opened) and we'd say if "we're just about to
check in changes there" or, if not, give priority/guidence on approaches
you could take, or specific ways you could help.
Thanks very much.
|
|
|
|
| Re: wtp xml editor completions not particular clever nor efficient [message #89341 is a reply to message #89264] |
Thu, 31 March 2005 22:32 |
| Eclipse User |
|
|
|
Originally posted by: jeremydyoung.sbcglobal.SPAM.ME.NOT.net
Yes, you are correct. I spoke somewhat out of turn I suppose. Sorry.
Max Rydahl Andersen wrote:
>
> I'm very much aware of it being an highly active open source project -
> that is why I
> try to get insight from the WTP team before just embarking out in
> something big ,)
>
> The code looked half baked and could just as well be on its way on which
> would make it more usefull if i got in contact with they man/woman who
> where doing it than starting/guessing by my self.
>
> /max
>
>> This is an Open Source project. If you see a problem, and are
>> capable of fixing it, then as a knowledgable user, it's you and
>> others like you that can make a huge difference in making Eclipse a
>> better product. Eclipse / Webtools is fastly becoming a significant
>> rival to other expensive commercial products, so don't take it
>> lightly that hundreds of people are volunteering their time
>> contributing to this project.
>>
>>
>>
>> Max Rydahl Andersen wrote:
>>
>>> Hi,
>>> While working with the xml editor I was kinda disappointed to discover
>>> that the editor did not insert required attributes and elements
>>> when completing on a tag name and that
>>> it did a very high number of iterations on even the simplest
>>> completions.
>>> While investigating I saw that there exist a method called
>>> AbstractContentModelGenerator.getRequiredText(parent, ed)
>>> which for some reason is not called even though it generates all
>>> the relevant info for these completions!?
>>> I also saw that even though the matchstring is like "pro" *all*
>>> tags are generated and then afterwards filtered away even though
>>> you could save alot of memory and cpu-cycles by skipping tagnames
>>> that does not start with "pro".
>>> Is this some work in progress (some of the code look half baked)
>>> that will be improved or do you seek contributions for it ?
>>> -max
>
>
>
>
|
|
|
Powered by
FUDForum. Page generated in 0.03965 seconds
Home