Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » EclipseLink » Please refactor code - use sonar -EntityManagerSetupImpl - PreDeploy has 400 lines of code
Please refactor code - use sonar -EntityManagerSetupImpl - PreDeploy has 400 lines of code [message #1775054] Tue, 24 October 2017 08:56
Nuno G. de M. is currently offline Nuno G. de M.Friend
Messages: 30
Registered: September 2012
Member

Hi,

The class:
org.eclipse.persistence.internal.jpa.EntityManagerSetupImpl

Is a class with a size of daunting proportions.
if this is not the Largest class in EclipseLInk - I will be chocked.

In this class, I have come accross a method that i was interested in understanding what it is doing:
public synchronized ClassTransformer predeploy(PersistenceUnitInfo info, Map extendedProperties) {

This method has over 400 lines of code...

I believe It is obvious that this needs to be refactored!

Using sonar in search for Critical violatons might not be a bad idea.

Many thanks for taking a look at this.

Kindest regards.
Previous Topic:Cache Coordination not Working properly
Next Topic:2 or more constraints when doing anyOf
Goto Forum:
  


Current Time: Mon Dec 11 09:41:05 GMT 2017

Powered by FUDForum. Page generated in 0.02458 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software